From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: claudiu beznea <claudiu.beznea@tuxon.dev>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
netdev@vger.kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH net-next 07/12] can: rcar_canfd: Use DT clock names in the probe message
Date: Thu, 12 Nov 2026 10:20:41 -0800 [thread overview]
Message-ID: <20261112102041.0857478e@kernel.org> (raw)
In-Reply-To: <20261112-private-tangible-dragonfly-3de373-mkl@pengutronix.de>
On Thu, 12 Nov 2026 14:44:43 +0100 Marc Kleine-Budde wrote:
> > RZ/G3E, RZ/V2H, RZ/V2N have input clocks named in the HW manual as pclk,
> > clk_ram and canfd. These are described in [1] page 3365, [2] page 3286, [3]
> > page 3160.
> >
> > All these have external_clk = 0, fcan_pclk = 0 and the patch here will print
> > "canfd clk" for them, as it is actually defined in HW, and as the previous
> > code did.
> >
> > It is true the commit message mentions it uses DT binding clock names. Maybe
> > that should be amended.
> >
> > With the current binding names and various usage of it across different SoCs
> > I'm not sure we can use binding names for all the cases.
> >
> > Please let me know how would you like me to proceed.
>
> I think it's fine. Let's see what the netdev people say :)
Fine by us if it's fine by you :) Thanks for chasing down
the explanation!
next prev parent reply other threads:[~2026-11-12 18:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 11:41 [PATCH net-next 0/12] pull-request: can-next 2026-11-10 Marc Kleine-Budde
2026-11-10 11:41 ` [PATCH net-next 01/12] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3S SoC Marc Kleine-Budde
2026-11-11 11:51 ` sashiko-bot
2026-11-11 12:20 ` netdev-bot+sashiko
2026-11-12 18:30 ` patchwork-bot+netdevbpf
2026-11-10 11:41 ` [PATCH net-next 02/12] can: rcar_canfd: Fix typos in macro names Marc Kleine-Budde
2026-11-11 11:51 ` sashiko-bot
2026-11-10 11:41 ` [PATCH net-next 03/12] can: rcar_canfd: Allow the CAN FD clock to be sourced from fck Marc Kleine-Budde
2026-11-11 11:51 ` sashiko-bot
2026-11-11 12:20 ` netdev-bot+sashiko
2026-11-10 11:41 ` [PATCH net-next 04/12] can: rcar_canfd: Do not set registers selecting the CAN mode Marc Kleine-Budde
2026-11-10 11:41 ` [PATCH net-next 05/12] can: rcar_canfd: Add support for Renesas RZ/G3S Marc Kleine-Budde
2026-11-11 12:20 ` netdev-bot+sashiko
2026-11-10 11:41 ` [PATCH net-next 06/12] can: rcar_canfd: Check can_clk request for errors Marc Kleine-Budde
2026-11-11 12:20 ` netdev-bot+sashiko
2026-11-10 11:41 ` [PATCH net-next 07/12] can: rcar_canfd: Use DT clock names in the probe message Marc Kleine-Budde
2026-11-11 11:51 ` sashiko-bot
2026-11-11 12:01 ` Marc Kleine-Budde
2026-11-12 12:25 ` Marc Kleine-Budde
2026-11-12 13:39 ` claudiu beznea
2026-11-12 13:44 ` Marc Kleine-Budde
2026-11-12 18:20 ` Jakub Kicinski [this message]
2026-11-11 12:20 ` netdev-bot+sashiko
2026-11-10 11:41 ` [PATCH net-next 08/12] dt-bindings: can: renesas,rcar-canfd: Restrict resets in top-level Marc Kleine-Budde
2026-11-11 11:51 ` sashiko-bot
2026-11-11 12:20 ` netdev-bot+sashiko
2026-11-10 11:41 ` [PATCH net-next 09/12] dt-bindings: can: renesas,rcar-canfd: Simplify renesas,no-can-fd description Marc Kleine-Budde
2026-11-10 11:41 ` [PATCH net-next 10/12] can: rcar_canfd: Document that RZ/G3S has no Classical CAN mode Marc Kleine-Budde
2026-11-11 12:20 ` netdev-bot+sashiko
2026-11-10 11:41 ` [PATCH net-next 11/12] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC Marc Kleine-Budde
2026-11-11 11:51 ` sashiko-bot
2026-11-11 12:20 ` netdev-bot+sashiko
2026-11-10 11:41 ` [PATCH net-next 12/12] can: rcar_canfd: Add support for Renesas RZ/G3L Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112102041.0857478e@kernel.org \
--to=kuba@kernel.org \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox