From: Marc Kleine-Budde <mkl@pengutronix.de>
To: yegor_sub1@visionsystems.de
Cc: yegorslists@googlemail.com, linux-can@vger.kernel.org
Subject: Re: [PATCH 2/2] can-utils: add Makefile for Android build system
Date: Thu, 22 Mar 2012 11:51:29 +0100 [thread overview]
Message-ID: <4F6B0431.1020803@pengutronix.de> (raw)
In-Reply-To: <4F6AFBCE.40305@visionsystems.de>
[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]
On 03/22/2012 11:15 AM, Yegor Yefremov wrote:
> Am 20.03.2012 11:08, schrieb Marc Kleine-Budde:
>> On 03/20/2012 10:47 AM, yegorslists@googlemail.com wrote:
>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>
>>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> Looks a bit ugly to me (as a non Android developer) repeating some
>> variables so many times. Is it usual to write android makefiles like this?
>
> Yes, it is really ugly :-( I'd like Android to have Buildroot like
> build system, so that native autotools/cmake/ etc. could be used
> directly. I've looked at other external packages in Android and took
> their Android.mk as a template.
Okay...seems you know what you're doing :)
>> There are some trailing whitespaces. No need to recommit the patch, I've
>> removed them.
>
> Working with quilt was easier regarding trailing white spaces. I'm
> looking for git way of removing them.
>
> I've seen the first patch committed, this is one is still not
> committed as far as I can see. Do I need to rework something?
No - I just wanted to have a statement on the ugliness :) I'll commit
the patch now.
Thanks, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-03-22 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 9:47 [PATCH 1/2] can-utils: cleanup headers yegorslists
2012-03-20 9:47 ` [PATCH 2/2] can-utils: add Makefile for Android build system yegorslists
2012-03-20 10:08 ` Marc Kleine-Budde
2012-03-22 10:15 ` Yegor Yefremov
2012-03-22 10:51 ` Marc Kleine-Budde [this message]
2012-03-20 10:10 ` [PATCH 1/2] can-utils: cleanup headers Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6B0431.1020803@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=yegor_sub1@visionsystems.de \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox