Re: [RFC PATCH 0/4] Net namespaces for SocketCAN

[Oliver Hartkopp <socketcan@hartkopp.net>]

Hi Andri,

On 27.09.2015 20:22, Andri Yngvason wrote:

> I've added net namespace support for raw and gw sockets. BCM needs work.
>
> I've done some preliminary testing and everything seems to work, but I would
> like to have some input from you guys before continuing.
>
> In particular I'm worried that I might have missed something with regard to
> receive lists. Devices still share the same "rcv_cache" across namespaces.

What I know from net namespaces is that you can create virtual interfaces 
(veth) which are 'peered' to another veth and can be 'bridged' to a real 
interface.

As the receive lists are interface specific (for real and virtual CAN 
interfaces, see dev->ml_priv in find_dev_rcv_lists()) you would need to make 
the virtual CAN driver namespace aware.

And you would need to implement some 'bind' and 'peering' between the 
interfaces to connect your virtual CAN to other vcan's or real CAN interfaces.

Net namespaces sounds fancy but I wonder what kind of use case you have in 
mind that cannot be realized by virtual CAN interfaces and can-gw routing 
assigments?

Regards,
Oliver

>
> Please tell me what you think.
>
> Thanks,
> Andri
>
> Andri Yngvason (4):
>    net: can: make af_can header global
>    net: can: rename structures
>    net: can: move shared data into net namespace
>    net: can: remove net namespace restrictions
>
>   include/linux/can/core.h    |   4 +-
>   include/net/af_can.h        | 131 +++++++++++++++++++
>   include/net/net_namespace.h |   4 +
>   include/net/netns/can.h     |  20 +++
>   net/can/af_can.c            | 183 ++++++++++++++------------
>   net/can/af_can.h            | 126 ------------------
>   net/can/bcm.c               |  29 +++--
>   net/can/gw.c                |  13 +-
>   net/can/proc.c              | 307 ++++++++++++++++++++++++--------------------
>   net/can/raw.c               |  34 +++--
>   10 files changed, 466 insertions(+), 385 deletions(-)
>   create mode 100644 include/net/af_can.h
>   create mode 100644 include/net/netns/can.h
>   delete mode 100644 net/can/af_can.h
>