Linux CAN drivers development
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Andri Yngvason <andri.yngvason@marel.com>, linux-can@vger.kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [RFC PATCH 0/4] Net namespaces for SocketCAN
Date: Tue, 29 Sep 2015 19:56:13 +0200	[thread overview]
Message-ID: <560AD0BD.6040803@hartkopp.net> (raw)
In-Reply-To: <20150929103032.1141.50295@maxwell.marel.net>

Hi Andri,

On 29.09.2015 12:30, Andri Yngvason wrote:
> Quoting Oliver Hartkopp (2015-09-28 17:54:35)
>> On 27.09.2015 20:22, Andri Yngvason wrote:
>>
>>> I've added net namespace support for raw and gw sockets. BCM needs work.

Do you think about the procfs stuff?

>>> I've done some preliminary testing and everything seems to work, but I would
>>> like to have some input from you guys before continuing.

I'm not a namespace specialist though. But at least it looks consistent.

>>> In particular I'm worried that I might have missed something with regard to
>>> receive lists. Devices still share the same "rcv_cache" across namespaces.

AFAIK the rcv_cache is just a better API to handle small data structures like 
the can_receiver. As the devices are separated and inside their specific 
namespace (right?) the ml_priv is per interface anyway.

So why not use a common rcv_cache ?

>>
>> What I know from net namespaces is that you can create virtual interfaces
>> (veth) which are 'peered' to another veth and can be 'bridged' to a real
>> interface.
>>
> Yes. I'm not actually interested in that though. I just want to be able to run
> vcan on LXC.

Ok - and when you create a vcan inside a namespace with

ip netns add myns

ip link add dev vcan0 type vcan

ip link set vcan0 netns myns

This just works inside the namespace 'myns' ??

---

Generally I appreciate your work after trying to understand it ;-)
So hopefully it doesn't break things we've overlooked.

How do you bridge two vcans over TCP?

Do you have an example for that?

Regards,
Oliver


  reply	other threads:[~2015-09-29 17:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-27 18:22 [RFC PATCH 0/4] Net namespaces for SocketCAN Andri Yngvason
2015-09-28 17:54 ` Oliver Hartkopp
2015-09-29 10:30   ` Andri Yngvason
2015-09-29 17:56     ` Oliver Hartkopp [this message]
2015-09-29 19:07       ` Andri Yngvason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560AD0BD.6040803@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=andri.yngvason@marel.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox