[PATCH v2] dt-bindings: net: can: holt,hi3110: Convert to DT schema

[PATCH v2] dt-bindings: net: can: holt,hi3110: Convert to DT schema

[Quchaosheng]

Convert the Holt HI-311X stand-alone CAN controller binding from
free-form text to DT schema, and reference the common can-controller.yaml
schema.

The controller is connected over SPI, so reference
spi-peripheral-props.yaml as well, otherwise the standard SPI properties
such as spi-max-frequency would be rejected by unevaluatedProperties.

The old text listed clocks as required, but the driver obtains the clock
with devm_clk_get_optional() and falls back to the "clock-frequency"
property when no clock is provided, so either one of the two must be
present and neither is required on its own. This is expressed with an
anyOf block, and clock-frequency is documented, as it was previously
undocumented. The maximum supported clock frequency of 40000000 is
enforced, as that is the limit the driver applies.

unevaluatedProperties is used rather than additionalProperties so that
properties provided by can-controller.yaml remain usable.

Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
---
v2:
 - Reference spi-peripheral-props.yaml. Without it, unevaluatedProperties
   rejected the standard SPI properties, spi-max-frequency among them.
   Reported by Sashiko.

 - Add a maximum of 40000000 to clock-frequency. The description stated
   the limit but did not enforce it. Reported by Sashiko.
---
 .../bindings/net/can/holt,hi311x.yaml         | 81 +++++++++++++++++++
 .../bindings/net/can/holt_hi311x.txt          | 23 ------
 2 files changed, 81 insertions(+), 23 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/can/holt_hi311x.txt

diff --git a/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
new file mode 100644
index 000000000..36497b114
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/holt,hi311x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Holt HI-311X stand-alone CAN controller
+
+maintainers:
+  - Marc Kleine-Budde <mkl@pengutronix.de>
+
+description:
+  The Holt HI-3110 is a stand-alone CAN controller with an SPI interface.
+
+allOf:
+  - $ref: can-controller.yaml#
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    const: holt,hi3110
+
+  reg:
+    description: SPI chip select.
+    maxItems: 1
+
+  clocks:
+    description:
+      The clock feeding the CAN controller. If this property is not present
+      clock-frequency must be specified instead.
+    maxItems: 1
+
+  clock-frequency:
+    description:
+      Frequency of the clock feeding the CAN controller, in Hz. Used when
+      no clocks property is provided.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    maximum: 40000000
+
+  interrupts:
+    description: IRQ line for the CAN controller.
+    maxItems: 1
+
+  vdd-supply:
+    description: Regulator that powers the CAN controller.
+
+  xceiver-supply:
+    description: Regulator that powers the CAN transceiver.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+anyOf:
+  - required:
+      - clocks
+  - required:
+      - clock-frequency
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        can@1 {
+            compatible = "holt,hi3110";
+            reg = <1>;
+            clocks = <&clk32m>;
+            interrupt-parent = <&gpio4>;
+            interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
+            vdd-supply = <&reg5v0>;
+            xceiver-supply = <&reg5v0>;
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/net/can/holt_hi311x.txt b/Documentation/devicetree/bindings/net/can/holt_hi311x.txt
deleted file mode 100644
index 3a9926f99..000000000
--- a/Documentation/devicetree/bindings/net/can/holt_hi311x.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-* Holt HI-311X stand-alone CAN controller device tree bindings
-
-Required properties:
- - compatible: Should be one of the following:
-   - "holt,hi3110" for HI-3110
- - reg: SPI chip select.
- - clocks: The clock feeding the CAN controller.
- - interrupts: Should contain IRQ line for the CAN controller.
-
-Optional properties:
- - vdd-supply: Regulator that powers the CAN controller.
- - xceiver-supply: Regulator that powers the CAN transceiver.
-
-Example:
-	can0: can@1 {
-		compatible = "holt,hi3110";
-		reg = <1>;
-		clocks = <&clk32m>;
-		interrupt-parent = <&gpio4>;
-		interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
-		vdd-supply = <&reg5v0>;
-		xceiver-supply = <&reg5v0>;
-	};
-- 
2.43.0

[PATCH v2] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema

[Quchaosheng]

Convert the Freescale MPC5xxx MSCAN controller binding from free-form
text to DT schema, and reference the common can-controller.yaml schema.

The original text described the two compatible strings and their clock
source properties in separate sections. "fsl,mpc5200b-mscan" is added as
a fallback of "fsl,mpc5200-mscan", the way existing device trees such as
mpc5200b.dtsi use it. The allowed values of fsl,mscan-clock-source are
constrained to the strings the driver accepts: the driver compares
against "ip", "sys" and "ref" and rejects anything else.

The clocks and clock-names properties are documented as well. The driver
looks up the "ipg", "ips", "sys", "ref" and "mclk" clocks by name, and
the existing MPC5121 device trees provide exactly those. They were not
described by the old text.

The note that the MPC5121 Rev. 1 processor is not supported is kept from
the original text.

unevaluatedProperties is used rather than additionalProperties so that
properties provided by can-controller.yaml remain usable.

Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
---
v2:
 - Add "fsl,mpc5200b-mscan" as a fallback compatible. mpc5200b.dtsi uses
   "fsl,mpc5200b-mscan", "fsl,mpc5200-mscan" and the strict enum would
   have rejected those existing device trees. Reported by Sashiko.

 - Describe the clocks and clock-names properties and add them to the
   example. The driver requires them on MPC5121, which the v1 example did
   not show. Reported by Sashiko.
---
 .../bindings/net/can/fsl,mpc5xxx-mscan.yaml   | 105 ++++++++++++++++++
 .../bindings/net/can/mpc5xxx-mscan.txt        |  53 ---------
 2 files changed, 105 insertions(+), 53 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/can/mpc5xxx-mscan.txt

diff --git a/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml b/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml
new file mode 100644
index 000000000..cece49caf
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/fsl,mpc5xxx-mscan.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale MPC5xxx MSCAN controller
+
+maintainers:
+  - Marc Kleine-Budde <mkl@pengutronix.de>
+
+description:
+  The MSCAN controller found on Freescale MPC5200 and MPC5121 SoCs. Note that
+  the MPC5121 Rev. 1 processor is not supported.
+
+allOf:
+  - $ref: can-controller.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - fsl,mpc5200b-mscan
+          - const: fsl,mpc5200-mscan
+      - enum:
+          - fsl,mpc5200-mscan
+          - fsl,mpc5121-mscan
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    description:
+      Clocks the controller needs. On MPC5121 the driver looks up "ipg",
+      "ips", "sys", "ref" and "mclk" by name.
+    maxItems: 5
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: ips
+      - const: sys
+      - const: ref
+      - const: mclk
+
+  fsl,mscan-clock-source:
+    description:
+      Clock source used for the controller. Valid values are "ip" for the IP
+      bus clock, "ref" for the reference clock (XTAL) and "sys" for the
+      system clock. "sys" is only available on MPC5121. When the property is
+      absent, an optimal clock source based on the system clock is selected,
+      falling back to the reference clock.
+    enum: [ip, ref, sys]
+
+  fsl,mscan-clock-divider:
+    description:
+      Additional clock divider for the reference and system clock sources.
+      Defaults to 1 when not specified.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    default: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/mpc512x-clock.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    can@1300 {
+        compatible = "fsl,mpc5121-mscan";
+        reg = <0x1300 0x80>;
+        interrupts = <12 IRQ_TYPE_LEVEL_LOW>;
+        interrupt-parent = <&ipic>;
+        clocks = <&clks MPC512x_CLK_BDLC>,
+                 <&clks MPC512x_CLK_IPS>,
+                 <&clks MPC512x_CLK_SYS>,
+                 <&clks MPC512x_CLK_REF>,
+                 <&clks MPC512x_CLK_MSCAN0_MCLK>;
+        clock-names = "ipg", "ips", "sys", "ref", "mclk";
+    };
+
+    can@1380 {
+        compatible = "fsl,mpc5121-mscan";
+        reg = <0x1380 0x80>;
+        interrupts = <13 IRQ_TYPE_LEVEL_LOW>;
+        interrupt-parent = <&ipic>;
+        clocks = <&clks MPC512x_CLK_BDLC>,
+                 <&clks MPC512x_CLK_IPS>,
+                 <&clks MPC512x_CLK_SYS>,
+                 <&clks MPC512x_CLK_REF>,
+                 <&clks MPC512x_CLK_MSCAN1_MCLK>;
+        clock-names = "ipg", "ips", "sys", "ref", "mclk";
+        fsl,mscan-clock-source = "ref";
+        fsl,mscan-clock-divider = <3>;
+    };
+...
diff --git a/Documentation/devicetree/bindings/net/can/mpc5xxx-mscan.txt b/Documentation/devicetree/bindings/net/can/mpc5xxx-mscan.txt
deleted file mode 100644
index 2fa4fcd38..000000000
--- a/Documentation/devicetree/bindings/net/can/mpc5xxx-mscan.txt
+++ /dev/null
@@ -1,53 +0,0 @@
-CAN Device Tree Bindings
-------------------------
-
-(c) 2006-2009 Secret Lab Technologies Ltd
-Grant Likely <grant.likely@secretlab.ca>
-
-fsl,mpc5200-mscan nodes
------------------------
-In addition to the required compatible-, reg- and interrupt-properties, you can
-also specify which clock source shall be used for the controller:
-
-- fsl,mscan-clock-source : a string describing the clock source. Valid values
-			   are:	"ip" for ip bus clock
-				 "ref" for reference clock (XTAL)
-			   "ref" is default in case this property is not
-			   present.
-
-fsl,mpc5121-mscan nodes
------------------------
-In addition to the required compatible-, reg- and interrupt-properties, you can
-also specify which clock source and divider shall be used for the controller:
-
-- fsl,mscan-clock-source : a string describing the clock source. Valid values
-			   are:	"ip" for ip bus clock
-				"ref" for reference clock
-				"sys" for system clock
-			   If this property is not present, an optimal CAN
-			   clock source and frequency based on the system
-			   clock will be selected. If this is not possible,
-			   the reference clock will be used.
-
-- fsl,mscan-clock-divider: for the reference and system clock, an additional
-			   clock divider can be specified. By default, a
-			   value of 1 is used.
-
-Note that the MPC5121 Rev. 1 processor is not supported.
-
-Examples:
-	can@1300 {
-		compatible = "fsl,mpc5121-mscan";
-		interrupts = <12 0x8>;
-		interrupt-parent = <&ipic>;
-		reg = <0x1300 0x80>;
-	};
-
-	can@1380 {
-		compatible = "fsl,mpc5121-mscan";
-		interrupts = <13 0x8>;
-		interrupt-parent = <&ipic>;
-		reg = <0x1380 0x80>;
-		fsl,mscan-clock-source = "ref";
-		fsl,mscan-clock-divider = <3>;
-	};
-- 
2.43.0

Re: [PATCH v2] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The YAML binding fails to enforce variant-specific property constraints using conditional blocks, allowing invalid device trees to pass validation.
--

commit 92a1abcb0821a0c5c2127da5be10ac0403eb2966
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema

This commit converts the Freescale MPC5xxx MSCAN controller binding from text
to DT schema. It also documents clock and clock-name properties that the
MPC5121 driver uses.

> diff --git a/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml b/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml
[ ... ]
> +  fsl,mscan-clock-source:
> +    description:
> +      Clock source used for the controller. Valid values are "ip" for the IP
> +      bus clock, "ref" for the reference clock (XTAL) and "sys" for the
> +      system clock. "sys" is only available on MPC5121. When the property is
> +      absent, an optimal clock source based on the system clock is selected,
> +      falling back to the reference clock.
> +    enum: [ip, ref, sys]

[Severity: Medium]
Since "sys" is documented as only being available on MPC5121, does this global
enum allow older hardware variants like MPC5200 to pass validation if they
specify "sys"?

Could this be caught during schema validation by using an allOf / if-then
conditional block that restricts the "sys" value to just the MPC5121
compatible strings?

[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - interrupts

[Severity: Medium]
Because the description for clocks mentions that the MPC5121 driver looks up
"ipg", "ips", "sys", "ref" and "mclk" by name, should clocks and clock-names
be added to the required list specifically for MPC5121?

Without an allOf conditional block enforcing these variant-specific
properties, would an incomplete device tree node missing these clocks
silently pass validation but fail later during the driver's probe routine?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914055608.495084-2-quchaosheng000406@163.com?part=1

Re: [PATCH v2] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema

[Krzysztof Kozlowski]

On 14/09/2026 07:56, Quchaosheng wrote:
> Convert the Freescale MPC5xxx MSCAN controller binding from free-form
> text to DT schema, and reference the common can-controller.yaml schema.
> 
> The original text described the two compatible strings and their clock
> source properties in separate sections. "fsl,mpc5200b-mscan" is added as
> a fallback of "fsl,mpc5200-mscan", the way existing device trees such as
> mpc5200b.dtsi use it. The allowed values of fsl,mscan-clock-source are
> constrained to the strings the driver accepts: the driver compares
> against "ip", "sys" and "ref" and rejects anything else.
> 
> The clocks and clock-names properties are documented as well. The driver

Don't paste here LLM output.

> looks up the "ipg", "ips", "sys", "ref" and "mclk" clocks by name, and
> the existing MPC5121 device trees provide exactly those. They were not
> described by the old text.

You write complicated paragraphs and complicated sentences in some
passive voice. Please look at other commits how the commit msg is written.

> 
> The note that the MPC5121 Rev. 1 processor is not supported is kept from
> the original text.
> 
> unevaluatedProperties is used rather than additionalProperties so that
> properties provided by can-controller.yaml remain usable.

Same problems.

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830


Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema

[Krzysztof Kozlowski]

On 14/09/2026 09:31, Krzysztof Kozlowski wrote:
> On 14/09/2026 07:56, Quchaosheng wrote:
>> Convert the Freescale MPC5xxx MSCAN controller binding from free-form
>> text to DT schema, and reference the common can-controller.yaml schema.
>>
>> The original text described the two compatible strings and their clock
>> source properties in separate sections. "fsl,mpc5200b-mscan" is added as
>> a fallback of "fsl,mpc5200-mscan", the way existing device trees such as
>> mpc5200b.dtsi use it. The allowed values of fsl,mscan-clock-source are
>> constrained to the strings the driver accepts: the driver compares
>> against "ip", "sys" and "ref" and rejects anything else.
>>
>> The clocks and clock-names properties are documented as well. The driver
> 
> Don't paste here LLM output.
> 
>> looks up the "ipg", "ips", "sys", "ref" and "mclk" clocks by name, and
>> the existing MPC5121 device trees provide exactly those. They were not
>> described by the old text.
> 
> You write complicated paragraphs and complicated sentences in some
> passive voice. Please look at other commits how the commit msg is written.


Also, submitting patches gives some advice, which you used in the first
paragraph but then stopped completely in the rest.

See longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: net: can: holt,hi3110: Convert to DT schema

[Krzysztof Kozlowski]

On 14/09/2026 07:56, Quchaosheng wrote:
> Convert the Holt HI-311X stand-alone CAN controller binding from
> free-form text to DT schema, and reference the common can-controller.yaml
> schema.
> 

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830


> The controller is connected over SPI, so reference
> spi-peripheral-props.yaml as well, otherwise the standard SPI properties
> such as spi-max-frequency would be rejected by unevaluatedProperties.

Redundant, drop.

> 
> The old text listed clocks as required, but the driver obtains the clock
> with devm_clk_get_optional() and falls back to the "clock-frequency"

No, read the git log history. It's only for ACPI. You cannot add ABI
post factum on the basis of "but someone added it to the driver code".

> property when no clock is provided, so either one of the two must be
> present and neither is required on its own. This is expressed with an
> anyOf block, and clock-frequency is documented, as it was previously
> undocumented. The maximum supported clock frequency of 40000000 is
> enforced, as that is the limit the driver applies.
> 
> unevaluatedProperties is used rather than additionalProperties so that
> properties provided by can-controller.yaml remain usable.

All this is redundant. You just paste here LLM explanations, so let me
stop you right here - do not ever paste us LLM text. It's pointless.

Explain the changes done to the binding ONLY.

> 
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> ---
> v2:
>  - Reference spi-peripheral-props.yaml. Without it, unevaluatedProperties
>    rejected the standard SPI properties, spi-max-frequency among them.
>    Reported by Sashiko.
> 
>  - Add a maximum of 40000000 to clock-frequency. The description stated
>    the limit but did not enforce it. Reported by Sashiko.
> ---
>  .../bindings/net/can/holt,hi311x.yaml         | 81 +++++++++++++++++++
>  .../bindings/net/can/holt_hi311x.txt          | 23 ------
>  2 files changed, 81 insertions(+), 23 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/can/holt_hi311x.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
> new file mode 100644
> index 000000000..36497b114
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/can/holt,hi311x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Holt HI-311X stand-alone CAN controller
> +
> +maintainers:
> +  - Marc Kleine-Budde <mkl@pengutronix.de>
> +
> +description:
> +  The Holt HI-3110 is a stand-alone CAN controller with an SPI interface.
> +
> +allOf:
> +  - $ref: can-controller.yaml#
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    const: holt,hi3110
> +
> +  reg:
> +    description: SPI chip select.
> +    maxItems: 1
> +
> +  clocks:
> +    description:
> +      The clock feeding the CAN controller. If this property is not present
> +      clock-frequency must be specified instead.
> +    maxItems: 1
> +
> +  clock-frequency:
> +    description:
> +      Frequency of the clock feeding the CAN controller, in Hz. Used when
> +      no clocks property is provided.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    maximum: 40000000

No

> +
> +  interrupts:
> +    description: IRQ line for the CAN controller.
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Regulator that powers the CAN controller.
> +
> +  xceiver-supply:
> +    description: Regulator that powers the CAN transceiver.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +anyOf:
> +  - required:
> +      - clocks
> +  - required:
> +      - clock-frequency

No


Best regards,
Krzysztof