Re: [PATCH v9 3/4] can: m_can: Return ERR_PTR on error in allocation

[Kendall Willis <k-willis@ti.com>]

On 8/20/25 07:42, Markus Schneider-Pargmann wrote:
> We have more detailed error values available, return them in the core
> driver and the calling drivers to return proper errors to callers.
> 
> Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
>   drivers/net/can/m_can/m_can.c          | 6 +++---
>   drivers/net/can/m_can/m_can_pci.c      | 4 ++--
>   drivers/net/can/m_can/m_can_platform.c | 4 ++--
>   drivers/net/can/m_can/tcan4x5x-core.c  | 4 ++--
>   4 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index c68c95cc97075ddf72dbd2f177a999a09b8a21ca..e08fae5ddf5efa8345670dd50d50954ec5d52b29 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -2392,7 +2392,7 @@ struct m_can_classdev *m_can_class_allocate_dev(struct device *dev,
>   					     sizeof(mram_config_vals) / 4);
>   	if (ret) {
>   		dev_err(dev, "Could not get Message RAM configuration.");
> -		goto out;
> +		return ERR_PTR(ret);
>   	}
>   
>   	if (dev->of_node && of_property_read_bool(dev->of_node, "wakeup-source"))
> @@ -2407,7 +2407,7 @@ struct m_can_classdev *m_can_class_allocate_dev(struct device *dev,
>   	net_dev = alloc_candev(sizeof_priv, tx_fifo_size);
>   	if (!net_dev) {
>   		dev_err(dev, "Failed to allocate CAN device");
> -		goto out;
> +		return ERR_PTR(-ENOMEM);
>   	}
>   
>   	class_dev = netdev_priv(net_dev);
> @@ -2417,7 +2417,7 @@ struct m_can_classdev *m_can_class_allocate_dev(struct device *dev,
>   
>   	m_can_of_parse_mram(class_dev, mram_config_vals);
>   	spin_lock_init(&class_dev->tx_handling_spinlock);
> -out:
> +
>   	return class_dev;
>   }
>   EXPORT_SYMBOL_GPL(m_can_class_allocate_dev);
> diff --git a/drivers/net/can/m_can/m_can_pci.c b/drivers/net/can/m_can/m_can_pci.c
> index 9ad7419f88f83016e93667f4847fe536eca39ad1..eb31ed1f964491ab41c7811be317706a09951390 100644
> --- a/drivers/net/can/m_can/m_can_pci.c
> +++ b/drivers/net/can/m_can/m_can_pci.c
> @@ -111,8 +111,8 @@ static int m_can_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
>   
>   	mcan_class = m_can_class_allocate_dev(&pci->dev,
>   					      sizeof(struct m_can_pci_priv));
> -	if (!mcan_class)
> -		return -ENOMEM;
> +	if (IS_ERR(mcan_class))
> +		return PTR_ERR(mcan_class);
>   
>   	priv = cdev_to_priv(mcan_class);
>   
> diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
> index b832566efda042929486578fad1879c7ad4a0cff..40bd10f71f0e2fab847c40c5bd5f7d85d3d46712 100644
> --- a/drivers/net/can/m_can/m_can_platform.c
> +++ b/drivers/net/can/m_can/m_can_platform.c
> @@ -87,8 +87,8 @@ static int m_can_plat_probe(struct platform_device *pdev)
>   
>   	mcan_class = m_can_class_allocate_dev(&pdev->dev,
>   					      sizeof(struct m_can_plat_priv));
> -	if (!mcan_class)
> -		return -ENOMEM;
> +	if (IS_ERR(mcan_class))
> +		return PTR_ERR(mcan_class);
>   
>   	priv = cdev_to_priv(mcan_class);
>   
> diff --git a/drivers/net/can/m_can/tcan4x5x-core.c b/drivers/net/can/m_can/tcan4x5x-core.c
> index 39b0b5277b11f5cf86137528e7ebea93a6d29c80..31cc9d0abd45360de8700d0a0270af8d3e42967d 100644
> --- a/drivers/net/can/m_can/tcan4x5x-core.c
> +++ b/drivers/net/can/m_can/tcan4x5x-core.c
> @@ -416,8 +416,8 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
>   
>   	mcan_class = m_can_class_allocate_dev(&spi->dev,
>   					      sizeof(struct tcan4x5x_priv));
> -	if (!mcan_class)
> -		return -ENOMEM;
> +	if (IS_ERR(mcan_class))
> +		return PTR_ERR(mcan_class);
>   
>   	ret = m_can_check_mram_cfg(mcan_class, TCAN4X5X_MRAM_SIZE);
>   	if (ret)
> 

Reviewed-by: Kendall Willis <k-willis@ti.com>