From: Christoph Fritz <christoph.fritz@hexdev.de>
To: Ryan Edwards <ryan.edwards@gmail.com>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Pavel Pisa <pisa@cmp.felk.cvut.cz>,
Andreas Lauser <andreas.lauser@mbition.io>,
Richard Weinberger <richard@nod.at>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/2] LIN support for Linux
Date: Mon, 28 Nov 2022 22:48:07 +0100 [thread overview]
Message-ID: <Y4UslxhfRPVGXzS/@mars> (raw)
In-Reply-To: <CAEVdEgBtikDjQ-cVOq-MkoS_0q_hGJRVSS=9L=htHhh7YvSUgA@mail.gmail.com>
Thanks for all the participation and feedback. Here is my attempt at a
summary of what we have discussed so far:
- Common goal: A solid LIN UAPI and API
- LIN fits CAN well and could be embedded into Linux CAN infrastructure
- LIN support cannot be a tty-line-discipline driver for all devices
out there
- slLIN should become a user of this API
- slLIN itself needs some more options in the line-discipline
configuraion (to tweak UART FIFO settings and e.g. enable
LIN-break-detection for supported UARTs) _or_ tty-LIN support
becomes something more like RS485 and get integrated into
tty-drivers directly.
- LIN devices with off loading capabilities are a bit special.
- one approach is to have a kfifo for the slavetable (64 entries a 8
bytes + checksum and some extra flags for some LIN special cases)
while updating it from userland through CAN or a simple sysfs
interface
- when we agree that "dumb" UARTs have no need for an
in-kernel-off-load slavetable (because of RT-Linux), then there
are only devices left (e.g. some USB adapters) maintaining their
own table, so a simple e.g. sysfs update mechanism would be
enough (without the need for an in-kernel kfifo buffer).
- LIN slavetable might need another name
- LIN needs rx, tx, set bitrate, set checksum variant and maybe update
a slavetable (or whatever it is called then...)
What do you think? Any objections, corrections, enhancements?
My question is: Which approach of an API is favored: Patch 1 or 2 of
this RFC series or something completely different?
Thanks
-- Christoph
next prev parent reply other threads:[~2022-11-28 21:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 19:02 [RFC][PATCH 0/2] LIN support for Linux Christoph Fritz
2022-11-27 19:02 ` [PATCH 1/2] [RFC] can: Introduce LIN bus as CANFD abstraction Christoph Fritz
2022-11-27 19:02 ` [PATCH 2/2] [RFC] can: Add LIN proto skeleton Christoph Fritz
2022-11-28 8:21 ` [RFC][PATCH 0/2] LIN support for Linux Oliver Hartkopp
2022-11-28 10:16 ` Christoph Fritz
2022-11-28 14:49 ` Pavel Pisa
2022-11-28 17:02 ` Ryan Edwards
2022-11-28 17:52 ` Pavel Pisa
2022-11-28 18:47 ` Ryan Edwards
2022-11-28 21:48 ` Christoph Fritz [this message]
2022-11-28 22:47 ` Andrew Lunn
2022-11-30 21:02 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4UslxhfRPVGXzS/@mars \
--to=christoph.fritz@hexdev.de \
--cc=andreas.lauser@mbition.io \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=richard@nod.at \
--cc=ryan.edwards@gmail.com \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox