* [PATCH] Fix error in J1939 documentation.
@ 2024-10-23 14:52 Alexander Hölzl
2024-10-23 15:17 ` Oleksij Rempel
2024-10-23 15:28 ` Paolo Abeni
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Hölzl @ 2024-10-23 14:52 UTC (permalink / raw)
To: robin, socketcan, mkl, davem, edumazet, kuba, pabeni, corbet
Cc: Alexander Hölzl, kernel, linux-can, linux-kernel
The description of PDU1 format usage mistakenly referred to PDU2 format.
Signed-off-by: Alexander Hölzl <alexander.hoelzl@gmx.net>
---
Documentation/networking/j1939.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst
index e4bd7aa1f5aa..544bad175aae 100644
--- a/Documentation/networking/j1939.rst
+++ b/Documentation/networking/j1939.rst
@@ -121,7 +121,7 @@ format, the Group Extension is set in the PS-field.
On the other hand, when using PDU1 format, the PS-field contains a so-called
Destination Address, which is _not_ part of the PGN. When communicating a PGN
-from user space to kernel (or vice versa) and PDU2 format is used, the PS-field
+from user space to kernel (or vice versa) and PDU1 format is used, the PS-field
of the PGN shall be set to zero. The Destination Address shall be set
elsewhere.
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix error in J1939 documentation.
2024-10-23 14:52 [PATCH] Fix error in J1939 documentation Alexander Hölzl
@ 2024-10-23 15:17 ` Oleksij Rempel
2024-10-23 15:28 ` Paolo Abeni
1 sibling, 0 replies; 4+ messages in thread
From: Oleksij Rempel @ 2024-10-23 15:17 UTC (permalink / raw)
To: Alexander Hölzl
Cc: robin, socketcan, mkl, davem, edumazet, kuba, pabeni, corbet,
kernel, linux-can, linux-kernel, o.rempel
On Wed, Oct 23, 2024 at 04:52:57PM +0200, Alexander Hölzl wrote:
> The description of PDU1 format usage mistakenly referred to PDU2 format.
>
> Signed-off-by: Alexander Hölzl <alexander.hoelzl@gmx.net>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix error in J1939 documentation.
2024-10-23 14:52 [PATCH] Fix error in J1939 documentation Alexander Hölzl
2024-10-23 15:17 ` Oleksij Rempel
@ 2024-10-23 15:28 ` Paolo Abeni
2024-10-23 15:46 ` Vincent MAILHOL
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Abeni @ 2024-10-23 15:28 UTC (permalink / raw)
To: Alexander Hölzl, robin, socketcan, mkl, davem, edumazet,
kuba, corbet
Cc: kernel, linux-can, linux-kernel
On 10/23/24 16:52, Alexander Hölzl wrote:
> The description of PDU1 format usage mistakenly referred to PDU2 format.
>
> Signed-off-by: Alexander Hölzl <alexander.hoelzl@gmx.net>
> ---
> Documentation/networking/j1939.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst
> index e4bd7aa1f5aa..544bad175aae 100644
> --- a/Documentation/networking/j1939.rst
> +++ b/Documentation/networking/j1939.rst
> @@ -121,7 +121,7 @@ format, the Group Extension is set in the PS-field.
>
> On the other hand, when using PDU1 format, the PS-field contains a so-called
> Destination Address, which is _not_ part of the PGN. When communicating a PGN
> -from user space to kernel (or vice versa) and PDU2 format is used, the PS-field
> +from user space to kernel (or vice versa) and PDU1 format is used, the PS-field
> of the PGN shall be set to zero. The Destination Address shall be set
> elsewhere.
You need to CC netdev or this patch will be lost,
Thanks,
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix error in J1939 documentation.
2024-10-23 15:28 ` Paolo Abeni
@ 2024-10-23 15:46 ` Vincent MAILHOL
0 siblings, 0 replies; 4+ messages in thread
From: Vincent MAILHOL @ 2024-10-23 15:46 UTC (permalink / raw)
To: Paolo Abeni
Cc: Alexander Hölzl, robin, socketcan, mkl, davem, edumazet,
kuba, corbet, kernel, linux-can, linux-kernel
On Thu. 24 Oct. 2024 at 00:29, Paolo Abeni <pabeni@redhat.com> wrote:
> On 10/23/24 16:52, Alexander Hölzl wrote:
> > The description of PDU1 format usage mistakenly referred to PDU2 format.
> >
> > Signed-off-by: Alexander Hölzl <alexander.hoelzl@gmx.net>
Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> > ---
> > Documentation/networking/j1939.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/networking/j1939.rst b/Documentation/networking/j1939.rst
> > index e4bd7aa1f5aa..544bad175aae 100644
> > --- a/Documentation/networking/j1939.rst
> > +++ b/Documentation/networking/j1939.rst
> > @@ -121,7 +121,7 @@ format, the Group Extension is set in the PS-field.
> >
> > On the other hand, when using PDU1 format, the PS-field contains a so-called
> > Destination Address, which is _not_ part of the PGN. When communicating a PGN
> > -from user space to kernel (or vice versa) and PDU2 format is used, the PS-field
> > +from user space to kernel (or vice versa) and PDU1 format is used, the PS-field
> > of the PGN shall be set to zero. The Destination Address shall be set
> > elsewhere.
>
> You need to CC netdev or this patch will be lost,
linux-can is a sub tree of netdev. This patch has the linux-can
mailing and all the linux-can maintainers in CC, so it will not be
lost. It is true that according to the process, netdev should also be
put in CC, but for a patch like this which is really specific to the
CAN protocol, I think it is acceptable to omit netdev.
Regardless, thanks for your comment!
Yours sincerely,
Vincent Mailhol
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-23 15:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 14:52 [PATCH] Fix error in J1939 documentation Alexander Hölzl
2024-10-23 15:17 ` Oleksij Rempel
2024-10-23 15:28 ` Paolo Abeni
2024-10-23 15:46 ` Vincent MAILHOL
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox