From: Filippo Storniolo <fstornio@redhat.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Jakub Kicinski <kuba@kernel.org>,
sashiko-reviews@lists.linux.dev,
Vincent Mailhol <mailhol@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can@vger.kernel.org
Subject: Re: [PATCH can-next v3 3/3] can: add can diag interface
Date: Tue, 20 Oct 2026 18:33:24 +0200 [thread overview]
Message-ID: <ateWxIr8FNtNqWt1@storniolo-redhat> (raw)
In-Reply-To: <20261020-reliable-loris-of-typhoon-255038-mkl@pengutronix.de>
On Tue, Oct 20, 2026 at 02:27:25PM +0200, Marc Kleine-Budde wrote:
>On 19.10.2026 13:45:00, Jakub Kicinski wrote:
>>
>> Sort of up to you, TBH. The AI loves to point this out,
>> but I think the fact most Netlink families don't handle
>> the inconsistency for 20 years almost proves that we're
>> fine without it?
>
>Ok, I think we accept these, too. Filippo, can you update the patch
>description with this information to make the bots happy.
>
>pw-bot: cr
>
>Can you fold in this patch that adds context-analysis (and removes not
>needed "depends on CAN"). Compile with >= clang-23, see
>Documentation/dev-tools/context-analysis.rst for details.
>
>Also pleae adjust the subject to always start with "can:".
>
>regards,
>Marc
>
Hi, thank you both for the feedback.
I'll soon send the v4 with the changes you suggested here and in the other
threads.
Best regards,
Filippo
next prev parent reply other threads:[~2026-10-20 16:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 14:12 [PATCH can-next v3 0/3] Introduce diag support for CAN Filippo Storniolo
2026-09-04 14:12 ` [PATCH can-next v3 1/3] af_can: ensure sk_protocol is always set on socket creation Filippo Storniolo
2026-10-20 15:26 ` Marc Kleine-Budde
2026-09-04 14:12 ` [PATCH can-next v3 2/3] af_can: store socket pointers in struct netns_can Filippo Storniolo
2026-09-04 14:12 ` [PATCH can-next v3 3/3] can: add can diag interface Filippo Storniolo
2026-09-04 14:26 ` sashiko-bot
2026-10-16 16:00 ` Filippo Storniolo
2026-10-17 10:10 ` Marc Kleine-Budde
2026-10-19 20:45 ` Jakub Kicinski
2026-10-20 12:27 ` Marc Kleine-Budde
2026-10-20 16:33 ` Filippo Storniolo [this message]
2026-10-21 9:11 ` Marc Kleine-Budde
2026-10-20 15:50 ` [PATCH can-next v3 0/3] Introduce diag support for CAN Marc Kleine-Budde
2026-10-20 16:20 ` Oliver Hartkopp
2026-10-21 7:37 ` Marc Kleine-Budde
2026-10-21 8:26 ` Filippo Storniolo
2026-10-21 8:35 ` Oliver Hartkopp
2026-10-21 16:34 ` Filippo Storniolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ateWxIr8FNtNqWt1@storniolo-redhat \
--to=fstornio@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=sashiko-reviews@lists.linux.dev \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox