Linux CAN drivers development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org,
	"Oliver Hartkopp" <socketcan@hartkopp.net>,
	"Vincent Mailhol" <mailhol@kernel.org>,
	"Oleksij Rempel" <o.rempel@pengutronix.de>
Subject: Re: [PATCH net-next 3/7] dt-bindings: net: can: holt,hi311x: Convert to DT schema
Date: Fri, 13 Nov 2026 07:38:06 +0000	[thread overview]
Message-ID: <sashiko-outbox-212357@kernel.org> (raw)
In-Reply-To: <20261113071325.4092169-4-mkl@pengutronix.de>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] dt-bindings: net: can: single-word handle Quchaosheng in
  Signed-off-by
--

commit 10f7c3c38441fe802ef963f0ba282453f08176ed
Author: Quchaosheng <quchaosheng000406@163.com>

> dt-bindings: net: can: holt,hi311x: Convert to DT schema
>
> Convert the Holt HI-311X binding from free-form text to DT schema.
>
> Reference can-controller.yaml and spi/spi-peripheral-props.yaml. The
> HI-3110 sits on an SPI bus, so its node carries the standard SPI
> properties, spi-max-frequency among them. With unevaluatedProperties:
> false and no reference to spi-peripheral-props.yaml, dtbs_check rejects
> those properties:
>
>   can@1 (holt,hi3110): Unevaluated properties are not allowed
>     ('spi-max-frequency' was unexpected)
>
> Keep the properties and the example as the original text describes them,
> including clocks as a required property.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Link: https://sashiko.dev/#/patchset/20260922084542.104788-1-quchaosheng000406@163.com?part=2
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> Link: https://patch.msgid.link/20260922102258.138753-3-quchaosheng000406@163.com
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

[Severity: High]
The Author header and Signed-off-by trailer use the single-word handle
"Quchaosheng" rather than a full name as required by the Developer's
Certificate of Origin in Documentation/process/submitting-patches.rst.
Should both use "Chaosheng Qu <quchaosheng000406@163.com>", matching
commit "dt-bindings: net: can: bosch,cc770: Convert to DT schema" in
this series?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113071325.4092169-1-mkl@pengutronix.de?part=3

  reply	other threads:[~2026-11-13  7:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  7:08 [PATCH net-next 0/7] pull-request: can-next 2026-11-13 Marc Kleine-Budde
2026-11-13  7:08 ` [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema Marc Kleine-Budde
2026-11-13  7:38   ` sashiko-bot
2026-11-13  7:45     ` Marc Kleine-Budde
2026-11-13  7:08 ` [PATCH net-next 2/7] dt-bindings: net: can: bosch,cc770: " Marc Kleine-Budde
2026-11-13  7:08 ` [PATCH net-next 3/7] dt-bindings: net: can: holt,hi311x: " Marc Kleine-Budde
2026-11-13  7:38   ` sashiko-bot [this message]
2026-11-13  7:45     ` Marc Kleine-Budde
2026-11-13  7:08 ` [PATCH net-next 4/7] net: can: cc770: update the binding file reference in the driver comment Marc Kleine-Budde
2026-11-13  7:08 ` [PATCH net-next 5/7] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema Marc Kleine-Budde
2026-11-13  7:08 ` [PATCH net-next 6/7] dt-bindings: net: can: convert grcan " Marc Kleine-Budde
2026-11-13  7:08 ` [PATCH net-next 7/7] net: can: grcan: update the binding file reference in the driver comment Marc Kleine-Budde
2026-11-13  7:38   ` sashiko-bot
2026-11-13  7:46     ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-212357@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=o.rempel@pengutronix.de \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox