Re: [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] dt-bindings: net: can: single-word name in Author and
  Signed-off-by
- [Low] dt-bindings: net: can: commit message claims unused
  IRQ_TYPE_EDGE_RISING
--

commit 20b578f1ac5dfb3641ca1495585b6a04db880f29
Author: Quchaosheng <quchaosheng000406@163.com>

> dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema
>
> Convert the IFI CAN-FD controller binding from free-form text to DT
> schema.
>
> Reference can-controller.yaml. interrupts is required: the driver obtains
> it with platform_get_irq().
>
> The example now uses the GIC and irq header defines instead of raw numbers.
> The values are unchanged: GIC_SPI is 0, IRQ_TYPE_NONE is 0 and 1 is
> IRQ_TYPE_EDGE_RISING. Rename the example node from canfd to can so that it
> matches the $nodename pattern in can-controller.yaml.
>
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Link: https://patch.msgid.link/20260922102258.138753-2-quchaosheng000406@163.com
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

[Severity: High]
Under Documentation/process/submitting-patches.rst, the Author header and
Signed-off-by trailer must use a known real full name with given and family
names separated by a space (for example, Qu Chaosheng or Chaosheng Qu)
rather than a single concatenated word.

> diff --git a/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
> new file mode 100644
> index 0000000000000..c8c3105c727b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    can@ff220000 {
> +        compatible = "ifi,canfd-1.0";
> +        reg = <0xff220000 0x1000>;
> +        interrupts = <GIC_SPI 43 IRQ_TYPE_NONE>;
> +    };

[Severity: Low]
The commit message states that "1 is IRQ_TYPE_EDGE_RISING", but neither 1
nor IRQ_TYPE_EDGE_RISING appears in the old <0 43 0> example or in this new
example.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113071325.4092169-1-mkl@pengutronix.de?part=1