* [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema
2026-11-13 7:08 [PATCH net-next 0/7] pull-request: can-next 2026-11-13 Marc Kleine-Budde
@ 2026-11-13 7:08 ` Marc Kleine-Budde
2026-11-13 7:38 ` sashiko-bot
2026-11-13 7:08 ` [PATCH net-next 2/7] dt-bindings: net: can: bosch,cc770: " Marc Kleine-Budde
` (5 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:08 UTC (permalink / raw)
To: netdev
Cc: davem, kuba, linux-can, kernel, Quchaosheng, Rob Herring (Arm),
Marc Kleine-Budde
From: Quchaosheng <quchaosheng000406@163.com>
Convert the IFI CAN-FD controller binding from free-form text to DT
schema.
Reference can-controller.yaml. interrupts is required: the driver obtains
it with platform_get_irq().
The example now uses the GIC and irq header defines instead of raw numbers.
The values are unchanged: GIC_SPI is 0, IRQ_TYPE_NONE is 0 and 1 is
IRQ_TYPE_EDGE_RISING. Rename the example node from canfd to can so that it
matches the $nodename pattern in can-controller.yaml.
Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20260922102258.138753-2-quchaosheng000406@163.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
.../bindings/net/can/ifi,canfd.yaml | 46 +++++++++++++++++++
.../devicetree/bindings/net/can/ifi_canfd.txt | 15 ------
2 files changed, 46 insertions(+), 15 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
delete mode 100644 Documentation/devicetree/bindings/net/can/ifi_canfd.txt
diff --git a/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
new file mode 100644
index 000000000000..c8c3105c727b
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/ifi,canfd.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: IFI CAN-FD Controller
+
+maintainers:
+ - Marc Kleine-Budde <mkl@pengutronix.de>
+
+description:
+ The I/F/I CAN-FD soft IP block connected to the platform bus. It is most
+ often synthesised into an FPGA or CPLD.
+
+allOf:
+ - $ref: can-controller.yaml#
+
+properties:
+ compatible:
+ const: ifi,canfd-1.0
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ can@ff220000 {
+ compatible = "ifi,canfd-1.0";
+ reg = <0xff220000 0x1000>;
+ interrupts = <GIC_SPI 43 IRQ_TYPE_NONE>;
+ };
+...
diff --git a/Documentation/devicetree/bindings/net/can/ifi_canfd.txt b/Documentation/devicetree/bindings/net/can/ifi_canfd.txt
deleted file mode 100644
index 20ea5c70ab82..000000000000
--- a/Documentation/devicetree/bindings/net/can/ifi_canfd.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-IFI CANFD controller
---------------------
-
-Required properties:
- - compatible: Should be "ifi,canfd-1.0"
- - reg: Should contain CAN controller registers location and length
- - interrupts: Should contain IRQ line for the CAN controller
-
-Example:
-
- canfd0: canfd@ff220000 {
- compatible = "ifi,canfd-1.0";
- reg = <0xff220000 0x00001000>;
- interrupts = <0 43 0>;
- };
base-commit: 573af801552999954caa8347e4490b04cf4763f0
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema
2026-11-13 7:08 ` [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema Marc Kleine-Budde
@ 2026-11-13 7:38 ` sashiko-bot
2026-11-13 7:45 ` Marc Kleine-Budde
0 siblings, 1 reply; 14+ messages in thread
From: sashiko-bot @ 2026-11-13 7:38 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: linux-can, Oliver Hartkopp, Vincent Mailhol, Oleksij Rempel
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] dt-bindings: net: can: single-word name in Author and
Signed-off-by
- [Low] dt-bindings: net: can: commit message claims unused
IRQ_TYPE_EDGE_RISING
--
commit 20b578f1ac5dfb3641ca1495585b6a04db880f29
Author: Quchaosheng <quchaosheng000406@163.com>
> dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema
>
> Convert the IFI CAN-FD controller binding from free-form text to DT
> schema.
>
> Reference can-controller.yaml. interrupts is required: the driver obtains
> it with platform_get_irq().
>
> The example now uses the GIC and irq header defines instead of raw numbers.
> The values are unchanged: GIC_SPI is 0, IRQ_TYPE_NONE is 0 and 1 is
> IRQ_TYPE_EDGE_RISING. Rename the example node from canfd to can so that it
> matches the $nodename pattern in can-controller.yaml.
>
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Link: https://patch.msgid.link/20260922102258.138753-2-quchaosheng000406@163.com
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
[Severity: High]
Under Documentation/process/submitting-patches.rst, the Author header and
Signed-off-by trailer must use a known real full name with given and family
names separated by a space (for example, Qu Chaosheng or Chaosheng Qu)
rather than a single concatenated word.
> diff --git a/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
> new file mode 100644
> index 0000000000000..c8c3105c727b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
[ ... ]
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + can@ff220000 {
> + compatible = "ifi,canfd-1.0";
> + reg = <0xff220000 0x1000>;
> + interrupts = <GIC_SPI 43 IRQ_TYPE_NONE>;
> + };
[Severity: Low]
The commit message states that "1 is IRQ_TYPE_EDGE_RISING", but neither 1
nor IRQ_TYPE_EDGE_RISING appears in the old <0 43 0> example or in this new
example.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113071325.4092169-1-mkl@pengutronix.de?part=1
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema
2026-11-13 7:38 ` sashiko-bot
@ 2026-11-13 7:45 ` Marc Kleine-Budde
0 siblings, 0 replies; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:45 UTC (permalink / raw)
To: sashiko-bot
Cc: Marc Kleine-Budde, linux-can, Oliver Hartkopp, Vincent Mailhol,
Oleksij Rempel
[-- Attachment #1: Type: text/plain, Size: 3141 bytes --]
On 13.11.2026 07:38:05, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issues to consider:
> - [High] dt-bindings: net: can: single-word name in Author and
> Signed-off-by
> - [Low] dt-bindings: net: can: commit message claims unused
> IRQ_TYPE_EDGE_RISING
> --
>
> commit 20b578f1ac5dfb3641ca1495585b6a04db880f29
> Author: Quchaosheng <quchaosheng000406@163.com>
>
> > dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema
> >
> > Convert the IFI CAN-FD controller binding from free-form text to DT
> > schema.
> >
> > Reference can-controller.yaml. interrupts is required: the driver obtains
> > it with platform_get_irq().
> >
> > The example now uses the GIC and irq header defines instead of raw numbers.
> > The values are unchanged: GIC_SPI is 0, IRQ_TYPE_NONE is 0 and 1 is
> > IRQ_TYPE_EDGE_RISING. Rename the example node from canfd to can so that it
> > matches the $nodename pattern in can-controller.yaml.
> >
> > Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > Link: https://patch.msgid.link/20260922102258.138753-2-quchaosheng000406@163.com
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> [Severity: High]
> Under Documentation/process/submitting-patches.rst, the Author header and
> Signed-off-by trailer must use a known real full name with given and family
> names separated by a space (for example, Qu Chaosheng or Chaosheng Qu)
> rather than a single concatenated word.
IMHO this is outdated information. Since d4563201f33a ("Documentation:
simplify and clarify DCO contribution example language")
submitting-patches.rst requires a "known identity" not a real name.
>
> > diff --git a/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
> > new file mode 100644
> > index 0000000000000..c8c3105c727b5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
>
> [ ... ]
>
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > + can@ff220000 {
> > + compatible = "ifi,canfd-1.0";
> > + reg = <0xff220000 0x1000>;
> > + interrupts = <GIC_SPI 43 IRQ_TYPE_NONE>;
> > + };
>
> [Severity: Low]
> The commit message states that "1 is IRQ_TYPE_EDGE_RISING", but neither 1
> nor IRQ_TYPE_EDGE_RISING appears in the old <0 43 0> example or in this new
> example.
Bad bot! The commit message says the meaning of the 3rd value of the
interrupts property is unchanged, it's the standard meaning as defined
in "dt-bindings/interrupt-controller/irq.h". The example lists only one
example, not all possibilities.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH net-next 2/7] dt-bindings: net: can: bosch,cc770: Convert to DT schema
2026-11-13 7:08 [PATCH net-next 0/7] pull-request: can-next 2026-11-13 Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema Marc Kleine-Budde
@ 2026-11-13 7:08 ` Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 3/7] dt-bindings: net: can: holt,hi311x: " Marc Kleine-Budde
` (4 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:08 UTC (permalink / raw)
To: netdev
Cc: davem, kuba, linux-can, kernel, Chaosheng Qu, Conor Dooley,
Marc Kleine-Budde
From: Chaosheng Qu <quchaosheng000406@163.com>
Convert the Bosch CC770 and Intel AN82527 controller binding from
free-form text to DT schema, and reference the common can-controller.yaml
schema.
The driver reads one more property than the old text documented:
"bosch,no-comperator-bypass", which is checked at cc770_platform.c:94.
It is documented here so that it can be used. Its spelling is kept as
the driver spells it.
The interrupt is obtained with platform_get_irq(), so interrupts is
required. The register window is described with the chip select, the
address offset and the size, as the original text and the existing
device trees on the local bus use three cells. The size is usually 0x80.
unevaluatedProperties is used rather than additionalProperties so that
properties provided by can-controller.yaml, such as termination-gpios,
remain usable.
Signed-off-by: Chaosheng Qu <quchaosheng000406@163.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://patch.msgid.link/20261009105557.301855-2-quchaosheng000406@163.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Notes:
FAQ:
Q: What about the comment in drivers/net/can/cc770/cc770_platform.c?
A: It's changed in the next patch.
.../bindings/net/can/bosch,cc770.yaml | 109 ++++++++++++++++++
.../devicetree/bindings/net/can/cc770.txt | 53 ---------
2 files changed, 109 insertions(+), 53 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/can/bosch,cc770.yaml
delete mode 100644 Documentation/devicetree/bindings/net/can/cc770.txt
diff --git a/Documentation/devicetree/bindings/net/can/bosch,cc770.yaml b/Documentation/devicetree/bindings/net/can/bosch,cc770.yaml
new file mode 100644
index 000000000000..448d5b4f74b5
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/bosch,cc770.yaml
@@ -0,0 +1,109 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/bosch,cc770.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bosch CC770 and Intel AN82527 CAN controllers
+
+maintainers:
+ - Marc Kleine-Budde <mkl@pengutronix.de>
+
+description:
+ The CC770 is a CAN controller from Bosch which is 100% compatible with the
+ older AN82527 from Intel, except that some bugs have been fixed.
+
+allOf:
+ - $ref: can-controller.yaml#
+
+properties:
+ compatible:
+ enum:
+ - bosch,cc770
+ - intc,82527
+
+ reg:
+ description:
+ Register window of the controller. On a PowerPC system the controller
+ sits on the local bus and the property describes the chip select, the
+ address offset and the size, the size usually being 0x80.
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ bosch,external-clock-frequency:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Frequency of the external oscillator clock in Hz. The internal clock
+ frequency used by the controller is half of this value.
+ default: 16000000
+
+ bosch,clock-out-frequency:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Clock frequency in Hz on the CLKOUT pin. If not specified or if the
+ value is 0 the CLKOUT pin is disabled.
+ default: 0
+
+ bosch,slew-rate:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Slew rate of the CLKOUT signal. If not specified a reasonable value
+ is calculated. Only used when bosch,clock-out-frequency is set.
+
+ bosch,divide-memory-clock:
+ description: Divide the memory clock for slower memories.
+ type: boolean
+
+ bosch,iso-low-speed-mux:
+ description: Use the ISO low speed multiplexed bus configuration.
+ type: boolean
+
+ bosch,no-comperator-bypass:
+ description:
+ Disable the comparator bypass. When this property is absent the
+ comparator bypass is enabled.
+ type: boolean
+
+ bosch,disconnect-rx0-input:
+ description: Disconnect the RX0 input.
+ type: boolean
+
+ bosch,disconnect-rx1-input:
+ description: Disconnect the RX1 input.
+ type: boolean
+
+ bosch,disconnect-tx1-output:
+ description: Disconnect the TX1 output.
+ type: boolean
+
+ bosch,polarity-dominant:
+ description: Use dominant polarity on the bus.
+ type: boolean
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ localbus {
+ #address-cells = <2>;
+ #size-cells = <1>;
+
+ can@2,100 {
+ compatible = "bosch,cc770";
+ reg = <2 0x100 0x100>;
+ interrupts = <4 1>;
+ interrupt-parent = <&mpic>;
+ bosch,external-clock-frequency = <16000000>;
+ bosch,disconnect-rx1-input;
+ bosch,disconnect-tx1-output;
+ bosch,iso-low-speed-mux;
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/net/can/cc770.txt b/Documentation/devicetree/bindings/net/can/cc770.txt
deleted file mode 100644
index 042200cf4419..000000000000
--- a/Documentation/devicetree/bindings/net/can/cc770.txt
+++ /dev/null
@@ -1,53 +0,0 @@
-Memory mapped Bosch CC770 and Intel AN82527 CAN controller
-
-Note: The CC770 is a CAN controller from Bosch, which is 100%
-compatible with the old AN82527 from Intel, but with "bugs" being fixed.
-
-Required properties:
-
-- compatible : should be "bosch,cc770" for the CC770 and "intc,82527"
- for the AN82527.
-
-- reg : should specify the chip select, address offset and size required
- to map the registers of the controller. The size is usually 0x80.
-
-- interrupts : property with a value describing the interrupt source
- (number and sensitivity) required for the controller.
-
-Optional properties:
-
-- bosch,external-clock-frequency : frequency of the external oscillator
- clock in Hz. Note that the internal clock frequency used by the
- controller is half of that value. If not specified, a default
- value of 16000000 (16 MHz) is used.
-
-- bosch,clock-out-frequency : slock frequency in Hz on the CLKOUT pin.
- If not specified or if the specified value is 0, the CLKOUT pin
- will be disabled.
-
-- bosch,slew-rate : slew rate of the CLKOUT signal. If not specified,
- a reasonable value will be calculated.
-
-- bosch,disconnect-rx0-input : see data sheet.
-
-- bosch,disconnect-rx1-input : see data sheet.
-
-- bosch,disconnect-tx1-output : see data sheet.
-
-- bosch,polarity-dominant : see data sheet.
-
-- bosch,divide-memory-clock : see data sheet.
-
-- bosch,iso-low-speed-mux : see data sheet.
-
-For further information, please have a look to the CC770 or AN82527.
-
-Examples:
-
-can@3,100 {
- compatible = "bosch,cc770";
- reg = <3 0x100 0x80>;
- interrupts = <2 0>;
- interrupt-parent = <&mpic>;
- bosch,external-clock-frequency = <16000000>;
-};
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH net-next 3/7] dt-bindings: net: can: holt,hi311x: Convert to DT schema
2026-11-13 7:08 [PATCH net-next 0/7] pull-request: can-next 2026-11-13 Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 1/7] dt-bindings: net: can: ifi,canfd-1.0: Convert to DT schema Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 2/7] dt-bindings: net: can: bosch,cc770: " Marc Kleine-Budde
@ 2026-11-13 7:08 ` Marc Kleine-Budde
2026-11-13 7:38 ` sashiko-bot
2026-11-13 7:08 ` [PATCH net-next 4/7] net: can: cc770: update the binding file reference in the driver comment Marc Kleine-Budde
` (3 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:08 UTC (permalink / raw)
To: netdev
Cc: davem, kuba, linux-can, kernel, Quchaosheng, Sashiko,
Rob Herring (Arm), Marc Kleine-Budde
From: Quchaosheng <quchaosheng000406@163.com>
Convert the Holt HI-311X binding from free-form text to DT schema.
Reference can-controller.yaml and spi/spi-peripheral-props.yaml. The
HI-3110 sits on an SPI bus, so its node carries the standard SPI
properties, spi-max-frequency among them. With unevaluatedProperties:
false and no reference to spi-peripheral-props.yaml, dtbs_check rejects
those properties:
can@1 (holt,hi3110): Unevaluated properties are not allowed
('spi-max-frequency' was unexpected)
Keep the properties and the example as the original text describes them,
including clocks as a required property.
Reported-by: Sashiko <sashiko-bot@kernel.org>
Link: https://sashiko.dev/#/patchset/20260922084542.104788-1-quchaosheng000406@163.com?part=2
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
Link: https://patch.msgid.link/20260922102258.138753-3-quchaosheng000406@163.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
.../bindings/net/can/holt,hi311x.yaml | 67 +++++++++++++++++++
.../bindings/net/can/holt_hi311x.txt | 23 -------
2 files changed, 67 insertions(+), 23 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
delete mode 100644 Documentation/devicetree/bindings/net/can/holt_hi311x.txt
diff --git a/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
new file mode 100644
index 000000000000..9ec6abb1279a
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/holt,hi311x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Holt HI-311X stand-alone CAN controller
+
+maintainers:
+ - Marc Kleine-Budde <mkl@pengutronix.de>
+
+description:
+ The Holt HI-3110 is a stand-alone CAN controller with an SPI interface.
+
+allOf:
+ - $ref: can-controller.yaml#
+ - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+ compatible:
+ const: holt,hi3110
+
+ reg:
+ description: SPI chip select.
+ maxItems: 1
+
+ clocks:
+ description: The clock feeding the CAN controller.
+ maxItems: 1
+
+ interrupts:
+ description: IRQ line for the CAN controller.
+ maxItems: 1
+
+ vdd-supply:
+ description: Regulator that powers the CAN controller.
+
+ xceiver-supply:
+ description: Regulator that powers the CAN transceiver.
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ can@1 {
+ compatible = "holt,hi3110";
+ reg = <1>;
+ clocks = <&clk32m>;
+ interrupt-parent = <&gpio4>;
+ interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
+ vdd-supply = <®5v0>;
+ xceiver-supply = <®5v0>;
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/net/can/holt_hi311x.txt b/Documentation/devicetree/bindings/net/can/holt_hi311x.txt
deleted file mode 100644
index 3a9926f99937..000000000000
--- a/Documentation/devicetree/bindings/net/can/holt_hi311x.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-* Holt HI-311X stand-alone CAN controller device tree bindings
-
-Required properties:
- - compatible: Should be one of the following:
- - "holt,hi3110" for HI-3110
- - reg: SPI chip select.
- - clocks: The clock feeding the CAN controller.
- - interrupts: Should contain IRQ line for the CAN controller.
-
-Optional properties:
- - vdd-supply: Regulator that powers the CAN controller.
- - xceiver-supply: Regulator that powers the CAN transceiver.
-
-Example:
- can0: can@1 {
- compatible = "holt,hi3110";
- reg = <1>;
- clocks = <&clk32m>;
- interrupt-parent = <&gpio4>;
- interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
- vdd-supply = <®5v0>;
- xceiver-supply = <®5v0>;
- };
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH net-next 3/7] dt-bindings: net: can: holt,hi311x: Convert to DT schema
2026-11-13 7:08 ` [PATCH net-next 3/7] dt-bindings: net: can: holt,hi311x: " Marc Kleine-Budde
@ 2026-11-13 7:38 ` sashiko-bot
2026-11-13 7:45 ` Marc Kleine-Budde
0 siblings, 1 reply; 14+ messages in thread
From: sashiko-bot @ 2026-11-13 7:38 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: linux-can, Oliver Hartkopp, Vincent Mailhol, Oleksij Rempel
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] dt-bindings: net: can: single-word handle Quchaosheng in
Signed-off-by
--
commit 10f7c3c38441fe802ef963f0ba282453f08176ed
Author: Quchaosheng <quchaosheng000406@163.com>
> dt-bindings: net: can: holt,hi311x: Convert to DT schema
>
> Convert the Holt HI-311X binding from free-form text to DT schema.
>
> Reference can-controller.yaml and spi/spi-peripheral-props.yaml. The
> HI-3110 sits on an SPI bus, so its node carries the standard SPI
> properties, spi-max-frequency among them. With unevaluatedProperties:
> false and no reference to spi-peripheral-props.yaml, dtbs_check rejects
> those properties:
>
> can@1 (holt,hi3110): Unevaluated properties are not allowed
> ('spi-max-frequency' was unexpected)
>
> Keep the properties and the example as the original text describes them,
> including clocks as a required property.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Link: https://sashiko.dev/#/patchset/20260922084542.104788-1-quchaosheng000406@163.com?part=2
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> Link: https://patch.msgid.link/20260922102258.138753-3-quchaosheng000406@163.com
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
[Severity: High]
The Author header and Signed-off-by trailer use the single-word handle
"Quchaosheng" rather than a full name as required by the Developer's
Certificate of Origin in Documentation/process/submitting-patches.rst.
Should both use "Chaosheng Qu <quchaosheng000406@163.com>", matching
commit "dt-bindings: net: can: bosch,cc770: Convert to DT schema" in
this series?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113071325.4092169-1-mkl@pengutronix.de?part=3
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH net-next 3/7] dt-bindings: net: can: holt,hi311x: Convert to DT schema
2026-11-13 7:38 ` sashiko-bot
@ 2026-11-13 7:45 ` Marc Kleine-Budde
0 siblings, 0 replies; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:45 UTC (permalink / raw)
To: sashiko-bot; +Cc: linux-can, Oliver Hartkopp, Vincent Mailhol, Oleksij Rempel
[-- Attachment #1: Type: text/plain, Size: 2355 bytes --]
On 13.11.2026 07:38:06, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] dt-bindings: net: can: single-word handle Quchaosheng in
> Signed-off-by
> --
>
> commit 10f7c3c38441fe802ef963f0ba282453f08176ed
> Author: Quchaosheng <quchaosheng000406@163.com>
>
> > dt-bindings: net: can: holt,hi311x: Convert to DT schema
> >
> > Convert the Holt HI-311X binding from free-form text to DT schema.
> >
> > Reference can-controller.yaml and spi/spi-peripheral-props.yaml. The
> > HI-3110 sits on an SPI bus, so its node carries the standard SPI
> > properties, spi-max-frequency among them. With unevaluatedProperties:
> > false and no reference to spi-peripheral-props.yaml, dtbs_check rejects
> > those properties:
> >
> > can@1 (holt,hi3110): Unevaluated properties are not allowed
> > ('spi-max-frequency' was unexpected)
> >
> > Keep the properties and the example as the original text describes them,
> > including clocks as a required property.
> >
> > Reported-by: Sashiko <sashiko-bot@kernel.org>
> > Link: https://sashiko.dev/#/patchset/20260922084542.104788-1-quchaosheng000406@163.com?part=2
> > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> > Link: https://patch.msgid.link/20260922102258.138753-3-quchaosheng000406@163.com
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> [Severity: High]
> The Author header and Signed-off-by trailer use the single-word handle
> "Quchaosheng" rather than a full name as required by the Developer's
> Certificate of Origin in Documentation/process/submitting-patches.rst.
> Should both use "Chaosheng Qu <quchaosheng000406@163.com>", matching
> commit "dt-bindings: net: can: bosch,cc770: Convert to DT schema" in
> this series?
IMHO this is outdated information. Since d4563201f33a ("Documentation:
simplify and clarify DCO contribution example language")
submitting-patches.rst requires a "known identity" not a real name.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH net-next 4/7] net: can: cc770: update the binding file reference in the driver comment
2026-11-13 7:08 [PATCH net-next 0/7] pull-request: can-next 2026-11-13 Marc Kleine-Budde
` (2 preceding siblings ...)
2026-11-13 7:08 ` [PATCH net-next 3/7] dt-bindings: net: can: holt,hi311x: " Marc Kleine-Budde
@ 2026-11-13 7:08 ` Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 5/7] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema Marc Kleine-Budde
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:08 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, linux-can, kernel, Chaosheng Qu, Marc Kleine-Budde
From: Chaosheng Qu <quchaosheng000406@163.com>
The cc770 binding was converted from cc770.txt to bosch,cc770.yaml, so
update the path mentioned in the comment at the top of the platform
driver.
Signed-off-by: Chaosheng Qu <quchaosheng000406@163.com>
Link: https://patch.msgid.link/20261009105557.301855-3-quchaosheng000406@163.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/cc770/cc770_platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/cc770/cc770_platform.c b/drivers/net/can/cc770/cc770_platform.c
index b6c4f02ffb97..b690167c454f 100644
--- a/drivers/net/can/cc770/cc770_platform.c
+++ b/drivers/net/can/cc770/cc770_platform.c
@@ -30,8 +30,8 @@
* bosch,external-clock-frequency = <16000000>;
* };
*
- * See "Documentation/devicetree/bindings/net/can/cc770.txt" for further
- * information.
+ * See "Documentation/devicetree/bindings/net/can/bosch,cc770.yaml" for
+ * further information.
*/
#include <linux/kernel.h>
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH net-next 5/7] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema
2026-11-13 7:08 [PATCH net-next 0/7] pull-request: can-next 2026-11-13 Marc Kleine-Budde
` (3 preceding siblings ...)
2026-11-13 7:08 ` [PATCH net-next 4/7] net: can: cc770: update the binding file reference in the driver comment Marc Kleine-Budde
@ 2026-11-13 7:08 ` Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 6/7] dt-bindings: net: can: convert grcan " Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 7/7] net: can: grcan: update the binding file reference in the driver comment Marc Kleine-Budde
6 siblings, 0 replies; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:08 UTC (permalink / raw)
To: netdev
Cc: davem, kuba, linux-can, kernel, Quchaosheng, Rob Herring (Arm),
Marc Kleine-Budde
From: Quchaosheng <quchaosheng000406@163.com>
Convert the Freescale MPC5xxx MSCAN binding from free-form text to DT
schema.
The original text documents fsl,mpc5200-mscan and fsl,mpc5121-mscan in two
separate sections. Keep that split: fsl,mscan-clock-source takes "ip" or
"ref" on fsl,mpc5200-mscan, and "ip", "ref" or "sys" on fsl,mpc5121-mscan.
Add fsl,mpc5200b-mscan as a fallback of fsl,mpc5200-mscan. mpc5200b.dtsi
uses it.
Document clocks and clock-names, which the original text does not describe.
fsl,mpc5121-mscan requires the "ipg", "ips", "sys", "ref" and "mclk"
clocks in that order, as mpc5121.dtsi supplies them. MPC5200 does not use
DT clocks; it takes its frequency from the CDM block.
fsl,mscan-clock-divider divides the selected clock, so value 0 cannot be
used.
Keep the note that the MPC5121 Rev. 1 processor is not supported.
Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20260922102258.138753-4-quchaosheng000406@163.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
.../bindings/net/can/fsl,mpc5xxx-mscan.yaml | 109 ++++++++++++++++++
.../bindings/net/can/mpc5xxx-mscan.txt | 53 ---------
2 files changed, 109 insertions(+), 53 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml
delete mode 100644 Documentation/devicetree/bindings/net/can/mpc5xxx-mscan.txt
diff --git a/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml b/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml
new file mode 100644
index 000000000000..77aa46fd62ac
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml
@@ -0,0 +1,109 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/fsl,mpc5xxx-mscan.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale MPC5xxx MSCAN controller
+
+maintainers:
+ - Marc Kleine-Budde <mkl@pengutronix.de>
+
+description:
+ The MSCAN controller found on the Freescale MPC5200 and MPC5121 SoCs. The
+ MPC5121 Rev. 1 processor is not supported.
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - fsl,mpc5200b-mscan
+ - const: fsl,mpc5200-mscan
+ - enum:
+ - fsl,mpc5200-mscan
+ - fsl,mpc5121-mscan
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ description:
+ Clocks feeding the controller. fsl,mpc5200-mscan takes its frequency
+ from the CDM block and does not use DT clocks.
+ minItems: 5
+ maxItems: 5
+
+ clock-names:
+ items:
+ - const: ipg
+ - const: ips
+ - const: sys
+ - const: ref
+ - const: mclk
+
+ fsl,mscan-clock-source:
+ description:
+ Clock source used for the controller. When the property is not present,
+ fsl,mpc5200-mscan uses the reference clock, while fsl,mpc5121-mscan
+ selects an optimal clock source and frequency based on the system clock
+ and uses the reference clock when that is not possible.
+ enum: [ip, ref, sys]
+
+ fsl,mscan-clock-divider:
+ description: Additional clock divider for the reference and system clocks.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 1
+ default: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+allOf:
+ - $ref: can-controller.yaml#
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,mpc5200-mscan
+ then:
+ properties:
+ fsl,mscan-clock-source:
+ enum: [ip, ref]
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,mpc5121-mscan
+ then:
+ required:
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mpc512x-clock.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ can@1300 {
+ compatible = "fsl,mpc5121-mscan";
+ reg = <0x1300 0x80>;
+ interrupts = <12 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-parent = <&ipic>;
+ clocks = <&clks MPC512x_CLK_BDLC>, <&clks MPC512x_CLK_IPS>,
+ <&clks MPC512x_CLK_SYS>, <&clks MPC512x_CLK_REF>,
+ <&clks MPC512x_CLK_MSCAN0_MCLK>;
+ clock-names = "ipg", "ips", "sys", "ref", "mclk";
+ fsl,mscan-clock-source = "ref";
+ fsl,mscan-clock-divider = <3>;
+ };
+...
diff --git a/Documentation/devicetree/bindings/net/can/mpc5xxx-mscan.txt b/Documentation/devicetree/bindings/net/can/mpc5xxx-mscan.txt
deleted file mode 100644
index 2fa4fcd38fd6..000000000000
--- a/Documentation/devicetree/bindings/net/can/mpc5xxx-mscan.txt
+++ /dev/null
@@ -1,53 +0,0 @@
-CAN Device Tree Bindings
-------------------------
-
-(c) 2006-2009 Secret Lab Technologies Ltd
-Grant Likely <grant.likely@secretlab.ca>
-
-fsl,mpc5200-mscan nodes
------------------------
-In addition to the required compatible-, reg- and interrupt-properties, you can
-also specify which clock source shall be used for the controller:
-
-- fsl,mscan-clock-source : a string describing the clock source. Valid values
- are: "ip" for ip bus clock
- "ref" for reference clock (XTAL)
- "ref" is default in case this property is not
- present.
-
-fsl,mpc5121-mscan nodes
------------------------
-In addition to the required compatible-, reg- and interrupt-properties, you can
-also specify which clock source and divider shall be used for the controller:
-
-- fsl,mscan-clock-source : a string describing the clock source. Valid values
- are: "ip" for ip bus clock
- "ref" for reference clock
- "sys" for system clock
- If this property is not present, an optimal CAN
- clock source and frequency based on the system
- clock will be selected. If this is not possible,
- the reference clock will be used.
-
-- fsl,mscan-clock-divider: for the reference and system clock, an additional
- clock divider can be specified. By default, a
- value of 1 is used.
-
-Note that the MPC5121 Rev. 1 processor is not supported.
-
-Examples:
- can@1300 {
- compatible = "fsl,mpc5121-mscan";
- interrupts = <12 0x8>;
- interrupt-parent = <&ipic>;
- reg = <0x1300 0x80>;
- };
-
- can@1380 {
- compatible = "fsl,mpc5121-mscan";
- interrupts = <13 0x8>;
- interrupt-parent = <&ipic>;
- reg = <0x1380 0x80>;
- fsl,mscan-clock-source = "ref";
- fsl,mscan-clock-divider = <3>;
- };
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH net-next 6/7] dt-bindings: net: can: convert grcan to DT schema
2026-11-13 7:08 [PATCH net-next 0/7] pull-request: can-next 2026-11-13 Marc Kleine-Budde
` (4 preceding siblings ...)
2026-11-13 7:08 ` [PATCH net-next 5/7] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema Marc Kleine-Budde
@ 2026-11-13 7:08 ` Marc Kleine-Budde
2026-11-13 7:08 ` [PATCH net-next 7/7] net: can: grcan: update the binding file reference in the driver comment Marc Kleine-Budde
6 siblings, 0 replies; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:08 UTC (permalink / raw)
To: netdev
Cc: davem, kuba, linux-can, kernel, Quchaosheng, Rob Herring (Arm),
Marc Kleine-Budde
From: Quchaosheng <quchaosheng000406@163.com>
grcan.txt is the only CAN controller binding whose device does not have a
compatible string. There are no device tree source files for LEON SPARC,
and the nodes are built by the PROM from the AMBA plug&play information,
which carries a core name and a register window but no compatible. The
driver matches on the node name instead.
It is the last of the five CAN controller bindings that were still written
as free-form text; the other four are posted separately.
A binding without a compatible string is not selected by dtbs_check,
because nodes are matched through their compatible values. The schema
therefore needs an explicit select on the node name. This is the same
mechanism ethernet-phy.yaml uses for optional-compatible nodes, and
without it the schema would never be applied to anything.
Two further details are worth pointing out, because the text binding got
them wrong or left them implicit:
- "systemid" is not a property of the controller node. The driver and
arch/sparc/kernel/leon_kernel.c both read it from the "/ambapp0" node,
so it is described in the description rather than in properties. The
binding is stricter than the text file here, and dtbs_check now
rejects a controller node that carries it.
- The node name format is "<core name>@<irq>,<address>", as built by
ambapp_path_component() in arch/sparc/kernel/prom_32.c from the "name"
and "reg" properties of the AMBA plug&play core. The select pattern
and the example follow that format.
The "name" property of the text binding is not described: dtc enforces
that it equals the base node name and then deletes it from the output, so
it never reaches a compiled devicetree.
This binding does not reference can-controller.yaml, unlike the other CAN
controller schemas. That common schema constrains the node name to
"^can(@.*)?$", which these nodes cannot satisfy -- they are named after
the AMBA plug&play core. Referencing it makes every valid node fail.
No functional change. The driver comment is updated by a separate patch.
Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20260929073703.2748220-2-quchaosheng000406@163.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Notes:
FAQ:
Q: What about the comment in drivers/net/can/grcan.c?
A: It's changed in the next patch.
.../net/can/aeroflexgaisler,grcan.yaml | 65 +++++++++++++++++++
.../devicetree/bindings/net/can/grcan.txt | 28 --------
2 files changed, 65 insertions(+), 28 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/can/aeroflexgaisler,grcan.yaml
delete mode 100644 Documentation/devicetree/bindings/net/can/grcan.txt
diff --git a/Documentation/devicetree/bindings/net/can/aeroflexgaisler,grcan.yaml b/Documentation/devicetree/bindings/net/can/aeroflexgaisler,grcan.yaml
new file mode 100644
index 000000000000..d5cba5b1bac1
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/can/aeroflexgaisler,grcan.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/can/aeroflexgaisler,grcan.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Aeroflex Gaisler GRCAN and GRHCAN CAN controllers
+
+maintainers:
+ - Marc Kleine-Budde <mkl@pengutronix.de>
+
+description: |
+ The GRCAN and GRHCAN CAN controllers are available in the GRLIB VHDL IP
+ core library.
+
+ On a LEON SPARC system there are no device tree source files. The nodes
+ are built by the PROM from the AMBA plug&play information, which does not
+ provide a compatible string. The driver therefore matches on the node
+ name, which is built as "<core name>@<irq>,<address>" from the "name" and
+ "reg" properties of the AMBA plug&play core.
+
+ The GRLIB build ID is not a property of the controller node either. It is
+ read from the "systemid" property of the "/ambapp0" node, and the TX bug
+ workaround is enabled when that property is absent or when its least
+ significant 16 bits are smaller than 4100.
+
+select:
+ properties:
+ $nodename:
+ pattern: '^(01_034|01_03d|GAISLER_GRCAN|GAISLER_GRHCAN)@'
+ required:
+ - $nodename
+
+properties:
+ reg:
+ maxItems: 1
+
+ freq:
+ description:
+ Frequency of the external oscillator clock in Hz, which is the
+ frequency of the AMBA bus in the ordinary case.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ interrupts:
+ maxItems: 1
+ description:
+ Interrupt number of the controller, as built from the AMBA plug&play
+ information.
+
+required:
+ - reg
+ - freq
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ /* AMBA plug&play children are named "<core name>@<irq>,<address>" */
+ GAISLER_GRCAN@c,80000000 {
+ reg = <0x80000000 0x1000>;
+ freq = <40000000>;
+ interrupts = <12>;
+ };
+...
diff --git a/Documentation/devicetree/bindings/net/can/grcan.txt b/Documentation/devicetree/bindings/net/can/grcan.txt
deleted file mode 100644
index 34ef3498f887..000000000000
--- a/Documentation/devicetree/bindings/net/can/grcan.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-Aeroflex Gaisler GRCAN and GRHCAN CAN controllers.
-
-The GRCAN and CRHCAN CAN controllers are available in the GRLIB VHDL IP core
-library.
-
-Note: These properties are built from the AMBA plug&play in a Leon SPARC system
-(the ordinary environment for GRCAN and GRHCAN). There are no dts files for
-sparc.
-
-Required properties:
-
-- name : Should be "GAISLER_GRCAN", "01_03d", "GAISLER_GRHCAN" or "01_034"
-
-- reg : Address and length of the register set for the device
-
-- freq : Frequency of the external oscillator clock in Hz (the frequency of
- the amba bus in the ordinary case)
-
-- interrupts : Interrupt number for this device
-
-Optional properties:
-
-- systemid : If not present or if the value of the least significant 16 bits
- of this 32-bit property is smaller than GRCAN_TXBUG_SAFE_GRLIB_VERSION
- a bug workaround is activated.
-
-For further information look in the documentation for the GLIB IP core library:
-http://www.gaisler.com/products/grlib/grip.pdf
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH net-next 7/7] net: can: grcan: update the binding file reference in the driver comment
2026-11-13 7:08 [PATCH net-next 0/7] pull-request: can-next 2026-11-13 Marc Kleine-Budde
` (5 preceding siblings ...)
2026-11-13 7:08 ` [PATCH net-next 6/7] dt-bindings: net: can: convert grcan " Marc Kleine-Budde
@ 2026-11-13 7:08 ` Marc Kleine-Budde
2026-11-13 7:38 ` sashiko-bot
6 siblings, 1 reply; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:08 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, linux-can, kernel, Quchaosheng, Marc Kleine-Budde
From: Quchaosheng <quchaosheng000406@163.com>
grcan.txt is replaced by aeroflexgaisler,grcan.yaml. Point the comment at
the new file. No functional change.
Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
Link: https://patch.msgid.link/20260929073703.2748220-3-quchaosheng000406@163.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/grcan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c
index ce12fa6df56d..1b4944d1d06d 100644
--- a/drivers/net/can/grcan.c
+++ b/drivers/net/can/grcan.c
@@ -10,8 +10,8 @@
* Full documentation of the GRCAN core can be found here:
* http://www.gaisler.com/products/grlib/grip.pdf
*
- * See "Documentation/devicetree/bindings/net/can/grcan.txt" for information on
- * open firmware properties.
+ * See "Documentation/devicetree/bindings/net/can/aeroflexgaisler,grcan.yaml"
+ * for information on open firmware properties.
*
* See "Documentation/ABI/testing/sysfs-class-net-grcan" for information on the
* sysfs interface.
--
2.53.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH net-next 7/7] net: can: grcan: update the binding file reference in the driver comment
2026-11-13 7:08 ` [PATCH net-next 7/7] net: can: grcan: update the binding file reference in the driver comment Marc Kleine-Budde
@ 2026-11-13 7:38 ` sashiko-bot
2026-11-13 7:46 ` Marc Kleine-Budde
0 siblings, 1 reply; 14+ messages in thread
From: sashiko-bot @ 2026-11-13 7:38 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: linux-can, Oliver Hartkopp, Vincent Mailhol, Oleksij Rempel
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] net: can: grcan: single-word handle Quchaosheng in
Signed-off-by trailer
--
commit 790597b86422386244176a3f727ee476daab6ccb
Author: Quchaosheng <quchaosheng000406@163.com>
> net: can: grcan: update the binding file reference in the driver comment
>
> grcan.txt is replaced by aeroflexgaisler,grcan.yaml. Point the comment at
> the new file. No functional change.
>
> Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> Link: https://patch.msgid.link/20260929073703.2748220-3-quchaosheng000406@163.com
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
[Severity: High]
The Author header and Signed-off-by trailer use the single-word string
"Quchaosheng" instead of the spaced full name "Chaosheng Qu" used in commit
2c42ef8efdf2 ("net: can: cc770: update the binding file reference in the
driver comment"). Documentation/process/submitting-patches.rst requires a
real full name in Signed-off-by, and the unspaced form splits the author's
identity in git history.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113071325.4092169-1-mkl@pengutronix.de?part=7
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH net-next 7/7] net: can: grcan: update the binding file reference in the driver comment
2026-11-13 7:38 ` sashiko-bot
@ 2026-11-13 7:46 ` Marc Kleine-Budde
0 siblings, 0 replies; 14+ messages in thread
From: Marc Kleine-Budde @ 2026-11-13 7:46 UTC (permalink / raw)
To: sashiko-bot; +Cc: linux-can, Oliver Hartkopp, Vincent Mailhol, Oleksij Rempel
[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]
On 13.11.2026 07:38:07, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] net: can: grcan: single-word handle Quchaosheng in
> Signed-off-by trailer
> --
>
> commit 790597b86422386244176a3f727ee476daab6ccb
> Author: Quchaosheng <quchaosheng000406@163.com>
>
> > net: can: grcan: update the binding file reference in the driver comment
> >
> > grcan.txt is replaced by aeroflexgaisler,grcan.yaml. Point the comment at
> > the new file. No functional change.
> >
> > Signed-off-by: Quchaosheng <quchaosheng000406@163.com>
> > Link: https://patch.msgid.link/20260929073703.2748220-3-quchaosheng000406@163.com
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> [Severity: High]
> The Author header and Signed-off-by trailer use the single-word string
> "Quchaosheng" instead of the spaced full name "Chaosheng Qu" used in commit
> 2c42ef8efdf2 ("net: can: cc770: update the binding file reference in the
> driver comment"). Documentation/process/submitting-patches.rst requires a
> real full name in Signed-off-by, and the unspaced form splits the author's
> identity in git history.
IMHO this is outdated information. Since d4563201f33a ("Documentation:
simplify and clarify DCO contribution example language")
submitting-patches.rst requires a "known identity" not a real name.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread