* [PATCH 6/7] cifs: fix a possible use of uninit variable in SMB2_sess_setup
@ 2014-08-20 10:39 Namjae Jeon
2014-08-21 0:14 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2014-08-20 10:39 UTC (permalink / raw)
To: 'Steve French'
Cc: 'Shirish Pargaonkar', 'Pavel Shilovsky',
linux-cifs-u79uwXL29TY76Z2rM5mHXA, Ashish Sangwan
In case of error, goto ssetup_exit can be hit and we could end up using
uninitialized value of resp_buftype
Signed-off-by: Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Ashish Sangwan <a.sangwan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
fs/cifs/smb2pdu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index a40f492..ab366e5 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -531,7 +531,7 @@ SMB2_sess_setup(const unsigned int xid, struct cifs_ses *ses,
struct smb2_sess_setup_rsp *rsp = NULL;
struct kvec iov[2];
int rc = 0;
- int resp_buftype;
+ int resp_buftype = CIFS_NO_BUFFER;
__le32 phase = NtLmNegotiate; /* NTLMSSP, if needed, is multistage */
struct TCP_Server_Info *server = ses->server;
u16 blob_length = 0;
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/7] cifs: fix a possible use of uninit variable in SMB2_sess_setup
2014-08-20 10:39 [PATCH 6/7] cifs: fix a possible use of uninit variable in SMB2_sess_setup Namjae Jeon
@ 2014-08-21 0:14 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2014-08-21 0:14 UTC (permalink / raw)
To: Namjae Jeon
Cc: Shirish Pargaonkar, Pavel Shilovsky,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ashish Sangwan
merged into cifs-2.6.git for-next
On Wed, Aug 20, 2014 at 5:39 AM, Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> In case of error, goto ssetup_exit can be hit and we could end up using
> uninitialized value of resp_buftype
>
> Signed-off-by: Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Ashish Sangwan <a.sangwan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> fs/cifs/smb2pdu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index a40f492..ab366e5 100644
> --- a/fs/cifs/smb2pdu.c
> +++ b/fs/cifs/smb2pdu.c
> @@ -531,7 +531,7 @@ SMB2_sess_setup(const unsigned int xid, struct cifs_ses *ses,
> struct smb2_sess_setup_rsp *rsp = NULL;
> struct kvec iov[2];
> int rc = 0;
> - int resp_buftype;
> + int resp_buftype = CIFS_NO_BUFFER;
> __le32 phase = NtLmNegotiate; /* NTLMSSP, if needed, is multistage */
> struct TCP_Server_Info *server = ses->server;
> u16 blob_length = 0;
> --
> 1.7.7
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-21 0:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-20 10:39 [PATCH 6/7] cifs: fix a possible use of uninit variable in SMB2_sess_setup Namjae Jeon
2014-08-21 0:14 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox