* [PATCH 7/7] cifs: remove unneeded check of null checking in if condition
@ 2014-08-20 10:39 Namjae Jeon
2014-08-21 0:16 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2014-08-20 10:39 UTC (permalink / raw)
To: 'Steve French'
Cc: 'Shirish Pargaonkar', 'Pavel Shilovsky',
linux-cifs-u79uwXL29TY76Z2rM5mHXA, Ashish Sangwan
Signed-off-by: Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Ashish Sangwan <a.sangwan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
fs/cifs/smb2pdu.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index ab366e5..844c651 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -1404,8 +1404,7 @@ SMB2_close(const unsigned int xid, struct cifs_tcon *tcon,
rsp = (struct smb2_close_rsp *)iov[0].iov_base;
if (rc != 0) {
- if (tcon)
- cifs_stats_fail_inc(tcon, SMB2_CLOSE_HE);
+ cifs_stats_fail_inc(tcon, SMB2_CLOSE_HE);
goto close_exit;
}
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 7/7] cifs: remove unneeded check of null checking in if condition
2014-08-20 10:39 [PATCH 7/7] cifs: remove unneeded check of null checking in if condition Namjae Jeon
@ 2014-08-21 0:16 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2014-08-21 0:16 UTC (permalink / raw)
To: Namjae Jeon
Cc: Shirish Pargaonkar, Pavel Shilovsky,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ashish Sangwan
merged into cifs-2.6.git for-next
On Wed, Aug 20, 2014 at 5:39 AM, Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Signed-off-by: Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Ashish Sangwan <a.sangwan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> fs/cifs/smb2pdu.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index ab366e5..844c651 100644
> --- a/fs/cifs/smb2pdu.c
> +++ b/fs/cifs/smb2pdu.c
> @@ -1404,8 +1404,7 @@ SMB2_close(const unsigned int xid, struct cifs_tcon *tcon,
> rsp = (struct smb2_close_rsp *)iov[0].iov_base;
>
> if (rc != 0) {
> - if (tcon)
> - cifs_stats_fail_inc(tcon, SMB2_CLOSE_HE);
> + cifs_stats_fail_inc(tcon, SMB2_CLOSE_HE);
> goto close_exit;
> }
>
> --
> 1.7.7
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-21 0:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-20 10:39 [PATCH 7/7] cifs: remove unneeded check of null checking in if condition Namjae Jeon
2014-08-21 0:16 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox