From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Tian Tao'" <tiantao6@hisilicon.com>
Cc: <linux-cifs@vger.kernel.org>,
<linux-cifsd-devel@lists.sourceforge.net>,
"'Zhiqi Song'" <songzhiqi1@huawei.com>,
<sergey.senozhatsky@gmail.com>, <sfrench@samba.org>,
<hyc.lee@gmail.com>
Subject: RE: [PATCH] cifsd: remove unused including <linux/version.h>
Date: Thu, 8 Apr 2021 17:11:28 +0900 [thread overview]
Message-ID: <00f001d72c4e$c6a19b30$53e4d190$@samsung.com> (raw)
In-Reply-To: <1617868656-34872-1-git-send-email-tiantao6@hisilicon.com>
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Signed-off-by: Zhiqi Song <songzhiqi1@huawei.com>
There are still leftover of it...
./mgmt/user_session.c:#include <linux/version.h>
./mgmt/user_session.h:#include <linux/version.h>
./mgmt/tree_connect.c:#include <linux/version.h>
I will directly update your patch and apply it.
Thanks for your patch!
> ---
> fs/cifsd/crypto_ctx.c | 1 -
> fs/cifsd/glob.h | 1 -
> fs/cifsd/misc.c | 1 -
> fs/cifsd/vfs.c | 1 -
> fs/cifsd/vfs_cache.h | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/fs/cifsd/crypto_ctx.c b/fs/cifsd/crypto_ctx.c index 2c31e8b..8322b0f 100644
> --- a/fs/cifsd/crypto_ctx.c
> +++ b/fs/cifsd/crypto_ctx.c
> @@ -9,7 +9,6 @@
> #include <linux/slab.h>
> #include <linux/wait.h>
> #include <linux/sched.h>
> -#include <linux/version.h>
>
> #include "glob.h"
> #include "crypto_ctx.h"
> diff --git a/fs/cifsd/glob.h b/fs/cifsd/glob.h index d0bc6ed..9d70093 100644
> --- a/fs/cifsd/glob.h
> +++ b/fs/cifsd/glob.h
> @@ -8,7 +8,6 @@
> #define __KSMBD_GLOB_H
>
> #include <linux/ctype.h>
> -#include <linux/version.h>
>
> #include "unicode.h"
> #include "vfs_cache.h"
> diff --git a/fs/cifsd/misc.c b/fs/cifsd/misc.c index b6f3f08..cbaaecf 100644
> --- a/fs/cifsd/misc.c
> +++ b/fs/cifsd/misc.c
> @@ -5,7 +5,6 @@
> */
>
> #include <linux/kernel.h>
> -#include <linux/version.h>
> #include <linux/xattr.h>
> #include <linux/fs.h>
>
> diff --git a/fs/cifsd/vfs.c b/fs/cifsd/vfs.c index d388220..5985d2d 100644
> --- a/fs/cifsd/vfs.c
> +++ b/fs/cifsd/vfs.c
> @@ -9,7 +9,6 @@
> #include <linux/uaccess.h>
> #include <linux/backing-dev.h>
> #include <linux/writeback.h>
> -#include <linux/version.h>
> #include <linux/xattr.h>
> #include <linux/falloc.h>
> #include <linux/genhd.h>
> diff --git a/fs/cifsd/vfs_cache.h b/fs/cifsd/vfs_cache.h index 318dcb1..8226fdf 100644
> --- a/fs/cifsd/vfs_cache.h
> +++ b/fs/cifsd/vfs_cache.h
> @@ -6,7 +6,6 @@
> #ifndef __VFS_CACHE_H__
> #define __VFS_CACHE_H__
>
> -#include <linux/version.h>
> #include <linux/file.h>
> #include <linux/fs.h>
> #include <linux/rwsem.h>
> --
> 2.7.4
prev parent reply other threads:[~2021-04-08 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210408075720epcas1p256de791fecd957017c3ba9d848996ff1@epcas1p2.samsung.com>
2021-04-08 7:57 ` [PATCH] cifsd: remove unused including <linux/version.h> Tian Tao
2021-04-08 8:11 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00f001d72c4e$c6a19b30$53e4d190$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=hyc.lee@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-cifsd-devel@lists.sourceforge.net \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfrench@samba.org \
--cc=songzhiqi1@huawei.com \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox