* [PATCH] cifsd: remove unused including <linux/version.h>
@ 2021-04-08 7:57 ` Tian Tao
2021-04-08 8:11 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-04-08 7:57 UTC (permalink / raw)
To: namjae.jeon, sergey.senozhatsky, sfrench, hyc.lee
Cc: linux-cifs, linux-cifsd-devel, Tian Tao, Zhiqi Song
Remove including <linux/version.h> that don't need it.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Zhiqi Song <songzhiqi1@huawei.com>
---
fs/cifsd/crypto_ctx.c | 1 -
fs/cifsd/glob.h | 1 -
fs/cifsd/misc.c | 1 -
fs/cifsd/vfs.c | 1 -
fs/cifsd/vfs_cache.h | 1 -
5 files changed, 5 deletions(-)
diff --git a/fs/cifsd/crypto_ctx.c b/fs/cifsd/crypto_ctx.c
index 2c31e8b..8322b0f 100644
--- a/fs/cifsd/crypto_ctx.c
+++ b/fs/cifsd/crypto_ctx.c
@@ -9,7 +9,6 @@
#include <linux/slab.h>
#include <linux/wait.h>
#include <linux/sched.h>
-#include <linux/version.h>
#include "glob.h"
#include "crypto_ctx.h"
diff --git a/fs/cifsd/glob.h b/fs/cifsd/glob.h
index d0bc6ed..9d70093 100644
--- a/fs/cifsd/glob.h
+++ b/fs/cifsd/glob.h
@@ -8,7 +8,6 @@
#define __KSMBD_GLOB_H
#include <linux/ctype.h>
-#include <linux/version.h>
#include "unicode.h"
#include "vfs_cache.h"
diff --git a/fs/cifsd/misc.c b/fs/cifsd/misc.c
index b6f3f08..cbaaecf 100644
--- a/fs/cifsd/misc.c
+++ b/fs/cifsd/misc.c
@@ -5,7 +5,6 @@
*/
#include <linux/kernel.h>
-#include <linux/version.h>
#include <linux/xattr.h>
#include <linux/fs.h>
diff --git a/fs/cifsd/vfs.c b/fs/cifsd/vfs.c
index d388220..5985d2d 100644
--- a/fs/cifsd/vfs.c
+++ b/fs/cifsd/vfs.c
@@ -9,7 +9,6 @@
#include <linux/uaccess.h>
#include <linux/backing-dev.h>
#include <linux/writeback.h>
-#include <linux/version.h>
#include <linux/xattr.h>
#include <linux/falloc.h>
#include <linux/genhd.h>
diff --git a/fs/cifsd/vfs_cache.h b/fs/cifsd/vfs_cache.h
index 318dcb1..8226fdf 100644
--- a/fs/cifsd/vfs_cache.h
+++ b/fs/cifsd/vfs_cache.h
@@ -6,7 +6,6 @@
#ifndef __VFS_CACHE_H__
#define __VFS_CACHE_H__
-#include <linux/version.h>
#include <linux/file.h>
#include <linux/fs.h>
#include <linux/rwsem.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] cifsd: remove unused including <linux/version.h>
2021-04-08 7:57 ` [PATCH] cifsd: remove unused including <linux/version.h> Tian Tao
@ 2021-04-08 8:11 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2021-04-08 8:11 UTC (permalink / raw)
To: 'Tian Tao'
Cc: linux-cifs, linux-cifsd-devel, 'Zhiqi Song',
sergey.senozhatsky, sfrench, hyc.lee
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Signed-off-by: Zhiqi Song <songzhiqi1@huawei.com>
There are still leftover of it...
./mgmt/user_session.c:#include <linux/version.h>
./mgmt/user_session.h:#include <linux/version.h>
./mgmt/tree_connect.c:#include <linux/version.h>
I will directly update your patch and apply it.
Thanks for your patch!
> ---
> fs/cifsd/crypto_ctx.c | 1 -
> fs/cifsd/glob.h | 1 -
> fs/cifsd/misc.c | 1 -
> fs/cifsd/vfs.c | 1 -
> fs/cifsd/vfs_cache.h | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/fs/cifsd/crypto_ctx.c b/fs/cifsd/crypto_ctx.c index 2c31e8b..8322b0f 100644
> --- a/fs/cifsd/crypto_ctx.c
> +++ b/fs/cifsd/crypto_ctx.c
> @@ -9,7 +9,6 @@
> #include <linux/slab.h>
> #include <linux/wait.h>
> #include <linux/sched.h>
> -#include <linux/version.h>
>
> #include "glob.h"
> #include "crypto_ctx.h"
> diff --git a/fs/cifsd/glob.h b/fs/cifsd/glob.h index d0bc6ed..9d70093 100644
> --- a/fs/cifsd/glob.h
> +++ b/fs/cifsd/glob.h
> @@ -8,7 +8,6 @@
> #define __KSMBD_GLOB_H
>
> #include <linux/ctype.h>
> -#include <linux/version.h>
>
> #include "unicode.h"
> #include "vfs_cache.h"
> diff --git a/fs/cifsd/misc.c b/fs/cifsd/misc.c index b6f3f08..cbaaecf 100644
> --- a/fs/cifsd/misc.c
> +++ b/fs/cifsd/misc.c
> @@ -5,7 +5,6 @@
> */
>
> #include <linux/kernel.h>
> -#include <linux/version.h>
> #include <linux/xattr.h>
> #include <linux/fs.h>
>
> diff --git a/fs/cifsd/vfs.c b/fs/cifsd/vfs.c index d388220..5985d2d 100644
> --- a/fs/cifsd/vfs.c
> +++ b/fs/cifsd/vfs.c
> @@ -9,7 +9,6 @@
> #include <linux/uaccess.h>
> #include <linux/backing-dev.h>
> #include <linux/writeback.h>
> -#include <linux/version.h>
> #include <linux/xattr.h>
> #include <linux/falloc.h>
> #include <linux/genhd.h>
> diff --git a/fs/cifsd/vfs_cache.h b/fs/cifsd/vfs_cache.h index 318dcb1..8226fdf 100644
> --- a/fs/cifsd/vfs_cache.h
> +++ b/fs/cifsd/vfs_cache.h
> @@ -6,7 +6,6 @@
> #ifndef __VFS_CACHE_H__
> #define __VFS_CACHE_H__
>
> -#include <linux/version.h>
> #include <linux/file.h>
> #include <linux/fs.h>
> #include <linux/rwsem.h>
> --
> 2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-08 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20210408075720epcas1p256de791fecd957017c3ba9d848996ff1@epcas1p2.samsung.com>
2021-04-08 7:57 ` [PATCH] cifsd: remove unused including <linux/version.h> Tian Tao
2021-04-08 8:11 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox