Re: [Linux-cifsd-devel] [PATCH] cifsd: make xattr format of ksmbd compatible with samba's one

Re: [Linux-cifsd-devel] [PATCH] cifsd: make xattr format of ksmbd compatible with samba's one

[Steve French]

I have rebased cifsd-for-next on 5.11-rc7

Will kick off some buildbot tests with it this week - it is looking
good so far, but let me know of other PRs coming soon

On Sun, Jan 31, 2021 at 6:47 PM Namjae Jeon <namjae.jeon@samsung.com> wrote:
>
> > FYI - I have rebased the cifsd-for-next branch onto 5.11-rc6
> Let me check it!
>
> Thanks!
> >
> > https://protect2.fireeye.com/v1/url?k=776f3edf-28f407c5-776eb590-0cc47a6cba04-
> > 039abc8d8963817e&q=1&e=3337a309-5806-4005-8f00-
> > b7312c0621f1&u=https%3A%2F%2Fgithub.com%2Fsmfrench%2Fsmb3-kernel.git
> >
> > On Tue, Jan 26, 2021 at 4:46 PM Namjae Jeon via samba-technical <samba-technical@lists.samba.org>
> > wrote:
> > >
> > > 2021-01-26 23:36 GMT+09:00, Stefan Metzmacher via samba-technical
> > > <samba-technical@lists.samba.org>:
> > > > Hi Namjae,
> > > Hi Metze,
> > > >
> > > >> Samba team request that ksmbd should make xattr format of ksmbd
> > > >> compatible with samba's one. When user replace samba with ksmbd or
> > > >> replace ksmbd with samba, The written attribute and ACLs of xattr
> > > >> in file should be used on both server. This patch work the
> > > >> following ones.
> > > >>  1. make xattr prefix compaible.
> > > >>     - rename creation.time and file.attribute to DOSATTRIB.
> > > >>     - rename stream. to DosStream.
> > > >>     - rename sd. to NTACL.
> > > >>  2. use same dos attribute and ntacl structure compaible with samba.
> > > >>  3. create read/write encoding of ndr functions in ndr.c to store ndr
> > > >>     encoded metadata to xattr.
> > > >
> > > > Thanks a lot!
> > > >
> > > > Do you also have this a git commit in some repository?
> > > Yes, You can check github.com/cifsd-team/cifsd
> > > tree(https://protect2.fireeye.com/v1/url?k=abb45e79-f42f6763-abb5d536-0cc47a6cba04-
> > 4d12d0be7dd14e1f&q=1&e=3337a309-5806-4005-8f00-b7312c0621f1&u=https%3A%2F%2Fgithub.com%2Fcifsd-
> > team%2Fcifsd%2Fcommit%2F0dc106786d40457e276f50412ecc67f11422dd1e).
> > > And there is a cifsd-for-next branch in
> > > github.com/smfrench/smb3-kernel for upstream.
> > > I have made a patch for that git tree, but I haven't fully tested it yet...
> > > I'm planning to send a pull request to Steve this week after doing it.
> > > >
> > > > I played with ksmbd a bit in the last days.
> > > Cool.
> > > >
> > > > I can also test this commit and check if the resulting data is
> > > > compatible with samba.
> > > Great!  Let me know your opinion if there is something wrong:) Thank
> > > you so much for your help!
> > > >
> > > > metze
> > > >
> > > >
> > >
> >
> >
> > --
> > Thanks,
> >
> > Steve
>


-- 
Thanks,

Steve

RE: [Linux-cifsd-devel] [PATCH] cifsd: make xattr format of ksmbd compatible with samba's one

[Namjae Jeon]

> I have rebased cifsd-for-next on 5.11-rc7
Okay.

> 
> Will kick off some buildbot tests with it this week - it is looking good so far, but let me know of
> other PRs coming soon
I have just sent a PR. Please check it.
And I will test on rebased #cifsd-for-next. If you find any issue, Let me know it.

Thanks!
> 
> On Sun, Jan 31, 2021 at 6:47 PM Namjae Jeon <namjae.jeon@samsung.com> wrote:
> >
> > > FYI - I have rebased the cifsd-for-next branch onto 5.11-rc6
> > Let me check it!
> >
> > Thanks!
> > >
> > > https://protect2.fireeye.com/v1/url?k=776f3edf-28f407c5-776eb590-0cc
> > > 47a6cba04-
> > > 039abc8d8963817e&q=1&e=3337a309-5806-4005-8f00-
> > > b7312c0621f1&u=https%3A%2F%2Fgithub.com%2Fsmfrench%2Fsmb3-kernel.git
> > >
> > > On Tue, Jan 26, 2021 at 4:46 PM Namjae Jeon via samba-technical
> > > <samba-technical@lists.samba.org>
> > > wrote:
> > > >
> > > > 2021-01-26 23:36 GMT+09:00, Stefan Metzmacher via samba-technical
> > > > <samba-technical@lists.samba.org>:
> > > > > Hi Namjae,
> > > > Hi Metze,
> > > > >
> > > > >> Samba team request that ksmbd should make xattr format of ksmbd
> > > > >> compatible with samba's one. When user replace samba with ksmbd
> > > > >> or replace ksmbd with samba, The written attribute and ACLs of
> > > > >> xattr in file should be used on both server. This patch work
> > > > >> the following ones.
> > > > >>  1. make xattr prefix compaible.
> > > > >>     - rename creation.time and file.attribute to DOSATTRIB.
> > > > >>     - rename stream. to DosStream.
> > > > >>     - rename sd. to NTACL.
> > > > >>  2. use same dos attribute and ntacl structure compaible with samba.
> > > > >>  3. create read/write encoding of ndr functions in ndr.c to store ndr
> > > > >>     encoded metadata to xattr.
> > > > >
> > > > > Thanks a lot!
> > > > >
> > > > > Do you also have this a git commit in some repository?
> > > > Yes, You can check github.com/cifsd-team/cifsd
> > > > tree(https://protect2.fireeye.com/v1/url?k=abb45e79-f42f6763-abb5d
> > > > 536-0cc47a6cba04-
> > > 4d12d0be7dd14e1f&q=1&e=3337a309-5806-4005-8f00-b7312c0621f1&u=https%
> > > 3A%2F%2Fgithub.com%2Fcifsd-
> > > team%2Fcifsd%2Fcommit%2F0dc106786d40457e276f50412ecc67f11422dd1e).
> > > > And there is a cifsd-for-next branch in
> > > > github.com/smfrench/smb3-kernel for upstream.
> > > > I have made a patch for that git tree, but I haven't fully tested it yet...
> > > > I'm planning to send a pull request to Steve this week after doing it.
> > > > >
> > > > > I played with ksmbd a bit in the last days.
> > > > Cool.
> > > > >
> > > > > I can also test this commit and check if the resulting data is
> > > > > compatible with samba.
> > > > Great!  Let me know your opinion if there is something wrong:)
> > > > Thank you so much for your help!
> > > > >
> > > > > metze
> > > > >
> > > > >
> > > >
> > >
> > >
> > > --
> > > Thanks,
> > >
> > > Steve
> >
> 
> 
> --
> Thanks,
> 
> Steve