Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: linux-next workflow question for cifs
Date: Wed, 09 May 2012 15:04:01 +0100	[thread overview]
Message-ID: <1336572241.2116.3.camel@localhost> (raw)
In-Reply-To: <20120509094511.29ca89ea-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>

On Wed, 2012-05-09 at 09:45 -0400, Jeff Layton wrote:
> On Wed, 9 May 2012 08:19:05 -0500
> Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 
> > Trying to figure out the easiest way for the workflow for the new
> > cifs-2.6.git linux-next branch for this scenario:
> > 
> > - push a series of patches to cifs-2.6.git linux-next
> > - someone adds an ack to a patch in the middle, or even a coding
> > change to a patch in the middle
> > - how do I easiest make this change and repush (without constantly
> > doing git push --force)
> > 
> > Do I rename the branch on my local workstation, do a git push (what is
> > the option to delete a branch remotely...?), then switch on the local
> > box to the newly renamed branch, amend the patch (will gitk or other
> > gui tool make this easier than what I use today which is git command
> > line option which launches a vi-like interface  which is a little bit
> > of a pain), rename the branch back and then push the new linux-next
> > branch (and create it on the remote server) ....
> > 
> 
> The upstream linux-next tree is recreated from scratch every time. So,
> there's no harm in rebasing that branch, or rewriting its history. Only
> the end product matters.
> 
> I use stgit heavily, so editing a patch description in the middle of a
> stack is trivial. Not sure what you can do with regular git tools or
> something like gitk.
>
> I guess you could create a new branch and cherry-pick all of the
> patches from the old, while doing something like "git commit --amend"
> to add Reviewed-by lines and such. It's a bit cumbersome, but the basic
> git tools are sort of primitive for this sort of thing...
> 

I've used git rebase -i <commit list>
to amend the commit messages, reorder the patches and also to squash
multiple patches into a single patch. However I am not sure you can push
a branch modified in this manner to a remote server. If you are using a
fresh remote branch each time, this is a non issue.

Sachin Prabhu

  parent reply	other threads:[~2012-05-09 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 13:19 linux-next workflow question for cifs Steve French
     [not found] ` <CAH2r5mtBK-C0Uc6gVY0Dk+YfbaFE+OfCbM+A_2BmiTVzZMchmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-09 13:45   ` Jeff Layton
     [not found]     ` <20120509094511.29ca89ea-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2012-05-09 14:04       ` Sachin Prabhu [this message]
2012-05-09 14:38         ` Steve French
     [not found]           ` <CAH2r5mupvedQif+7XRxJozbwQxshqs2SJBgkP3t_9xJQdBWPwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-09 16:29             ` Jeff Layton
2012-05-09 17:52   ` J. Bruce Fields
     [not found]     ` <20120509175219.GA26477-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-05-09 18:08       ` Jeff Layton
     [not found]         ` <20120509140847.277d5c0b-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2012-05-09 19:02           ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336572241.2116.3.camel@localhost \
    --to=sprabhu-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox