Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: linux-next workflow question for cifs
Date: Wed, 9 May 2012 13:52:19 -0400	[thread overview]
Message-ID: <20120509175219.GA26477@fieldses.org> (raw)
In-Reply-To: <CAH2r5mtBK-C0Uc6gVY0Dk+YfbaFE+OfCbM+A_2BmiTVzZMchmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Wed, May 09, 2012 at 08:19:05AM -0500, Steve French wrote:
> Trying to figure out the easiest way for the workflow for the new
> cifs-2.6.git linux-next branch for this scenario:
> 
> - push a series of patches to cifs-2.6.git linux-next
> - someone adds an ack to a patch in the middle, or even a coding
> change to a patch in the middle
> - how do I easiest make this change and repush (without constantly
> doing git push --force)

The other way to deal with it is:
	- if there's a coding change, add another patch on top.
	- if an ack or attribution got lost, apologize and try to
	  do better next time.

There are advantages to clean bisectable history, and there are also
advantages to real append-only history:
	- if someone's doing extra work on top of your branch, then
	  rebasing their stuff becomes easier.
	- if someone finds a bug in your branch and fixes it, then you
	  have a record of how that actually happened.

My personal balance is to have one append-only branch that's what gets
pulled into next, and then a different tree with any works in progress
that I can point someone to if necessary.

And I try not to push to the append-only branch until I'm pretty sure
there's been a chance for review, etc.

Not saying that's perfect--there are times when I would've liked to get
a patch some more testing in -next before really committing to it, and
at least one case when someone was annoyed not to be able to improve the
change log on something they submitted.

--b.

  parent reply	other threads:[~2012-05-09 17:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 13:19 linux-next workflow question for cifs Steve French
     [not found] ` <CAH2r5mtBK-C0Uc6gVY0Dk+YfbaFE+OfCbM+A_2BmiTVzZMchmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-09 13:45   ` Jeff Layton
     [not found]     ` <20120509094511.29ca89ea-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2012-05-09 14:04       ` Sachin Prabhu
2012-05-09 14:38         ` Steve French
     [not found]           ` <CAH2r5mupvedQif+7XRxJozbwQxshqs2SJBgkP3t_9xJQdBWPwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-09 16:29             ` Jeff Layton
2012-05-09 17:52   ` J. Bruce Fields [this message]
     [not found]     ` <20120509175219.GA26477-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-05-09 18:08       ` Jeff Layton
     [not found]         ` <20120509140847.277d5c0b-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2012-05-09 19:02           ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120509175219.GA26477@fieldses.org \
    --to=bfields-uc3wqj2krung9huczpvpmw@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox