From: Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "Aurélien Aptel" <aaptel-IBi9RG/b67k@public.gmane.org>,
linux-cifs <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] cifs/dir.c: use correct path separator
Date: Wed, 07 Sep 2016 10:27:06 +0100 [thread overview]
Message-ID: <1473240426.3882.42.camel@redhat.com> (raw)
In-Reply-To: <mps60q8sy4z.fsf-IBi9RG/b67k@public.gmane.org>
On Tue, 2016-09-06 at 20:04 +0200, Aurélien Aptel wrote:
> Current code hardcodes the path separator to backslash. The loop
> after
> it that switches the slashes direction only operates on the dfs
> prefix,
> not the whole path. Use CIFS_DIR_SEP instead.
>
Hello Aurélien,
Can you please add this summary to the patch summary and repost the
patch using git send-email instead. Having the patch inline makes it a
bit easier to review the patch.
Sachin Prabhu
next prev parent reply other threads:[~2016-09-07 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 18:04 [PATCH] cifs/dir.c: use correct path separator Aurélien Aptel
[not found] ` <mps60q8sy4z.fsf-IBi9RG/b67k@public.gmane.org>
2016-09-07 9:27 ` Sachin Prabhu [this message]
[not found] ` <1473240426.3882.42.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-09-08 10:53 ` Aurélien Aptel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473240426.3882.42.camel@redhat.com \
--to=sprabhu-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=aaptel-IBi9RG/b67k@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox