From: "Aurélien Aptel" <aaptel-IBi9RG/b67k@public.gmane.org>
To: linux-cifs <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH] cifs/dir.c: use correct path separator
Date: Tue, 06 Sep 2016 20:04:28 +0200 [thread overview]
Message-ID: <mps60q8sy4z.fsf@suse.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 191 bytes --]
Current code hardcodes the path separator to backslash. The loop after
it that switches the slashes direction only operates on the dfs prefix,
not the whole path. Use CIFS_DIR_SEP instead.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-fs-cifs-dir.c-use-correct-path-separator.patch --]
[-- Type: text/x-patch, Size: 892 bytes --]
From cf6070073e817e48efc5ec72639eaeb848d6c002 Mon Sep 17 00:00:00 2001
From: Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>
Date: Tue, 6 Sep 2016 19:58:28 +0200
Subject: [PATCH] fs/cifs/dir.c: use correct path separator
Signed-off-by: Aurelien Aptel <aaptel-IBi9RG/b67k@public.gmane.org>
---
fs/cifs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index 4716c54..c753748 100644
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
@@ -163,7 +163,7 @@ cifs_bp_rename_retry:
cifs_dbg(FYI, "using cifs_sb prepath <%s>\n", cifs_sb->prepath);
memcpy(full_path+dfsplen+1, cifs_sb->prepath, pplen-1);
- full_path[dfsplen] = '\\';
+ full_path[dfsplen] = CIFS_DIR_SEP(cifs_sb);
for (i = 0; i < pplen-1; i++)
if (full_path[dfsplen+1+i] == '/')
full_path[dfsplen+1+i] = CIFS_DIR_SEP(cifs_sb);
--
2.1.4
[-- Attachment #1.3: Type: text/plain, Size: 245 bytes --]
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next reply other threads:[~2016-09-06 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 18:04 Aurélien Aptel [this message]
[not found] ` <mps60q8sy4z.fsf-IBi9RG/b67k@public.gmane.org>
2016-09-07 9:27 ` [PATCH] cifs/dir.c: use correct path separator Sachin Prabhu
[not found] ` <1473240426.3882.42.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-09-08 10:53 ` Aurélien Aptel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mps60q8sy4z.fsf@suse.com \
--to=aaptel-ibi9rg/b67k@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox