Linux CIFS filesystem development
 help / color / mirror / Atom feed
* [PATCH] cifs: Do not modify mid entry after submitting I/O in cifs_call_async
@ 2017-06-28 17:50 Long Li
  0 siblings, 0 replies; only message in thread
From: Long Li @ 2017-06-28 17:50 UTC (permalink / raw)
  To: Steve French, linux-cifs-u79uwXL29TY76Z2rM5mHXA,
	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: Long Li

From: Long Li <longli-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>

In cifs_call_async, server response may return as soon as I/O is submitted.
Do not touch it after that.

Signed-off-by: Long Li <longli-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
---
 fs/cifs/transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
index 47a125e..ba62aaf 100644
--- a/fs/cifs/transport.c
+++ b/fs/cifs/transport.c
@@ -537,10 +537,10 @@ cifs_call_async(struct TCP_Server_Info *server, struct smb_rqst *rqst,
 	spin_unlock(&GlobalMid_Lock);
 
 
+	cifs_save_when_sent(mid);
 	cifs_in_send_inc(server);
 	rc = smb_send_rqst(server, rqst, flags);
 	cifs_in_send_dec(server);
-	cifs_save_when_sent(mid);
 
 	if (rc < 0) {
 		server->sequence_number -= 2;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-06-28 17:50 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-28 17:50 [PATCH] cifs: Do not modify mid entry after submitting I/O in cifs_call_async Long Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox