[PATCH] cifs: eliminate unneeded cast of cifs_demultiplex_thread

[PATCH] cifs: eliminate unneeded cast of cifs_demultiplex_thread

[Jeff Layton]

Reported-by: Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 fs/cifs/connect.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 729514c..ceab134 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1791,8 +1791,7 @@ cifs_get_tcp_session(struct smb_vol *volume_info)
 	 * this will succeed. No need for try_module_get().
 	 */
 	__module_get(THIS_MODULE);
-	tcp_ses->tsk = kthread_run((void *)(void *)cifs_demultiplex_thread,
-				  tcp_ses, "cifsd");
+	tcp_ses->tsk = kthread_run(cifs_demultiplex_thread, tcp_ses, "cifsd");
 	if (IS_ERR(tcp_ses->tsk)) {
 		rc = PTR_ERR(tcp_ses->tsk);
 		cERROR(1, "error %d create cifsd thread", rc);
-- 
1.7.6

[PATCH] cifs: fix cast on cifs_demultiplex_thread

[Jeff Layton]

My initial pass at doing this just eliminated the cast altogether. When
I played with it today though, that caused a compiler warning. So, just
fix the cast instead.

Reported-by: Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 fs/cifs/connect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 1507ada..dc52872 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1791,7 +1791,7 @@ cifs_get_tcp_session(struct smb_vol *volume_info)
 	 * this will succeed. No need for try_module_get().
 	 */
 	__module_get(THIS_MODULE);
-	tcp_ses->tsk = kthread_run((void *)(void *)cifs_demultiplex_thread,
+	tcp_ses->tsk = kthread_run((int(*)(void *))cifs_demultiplex_thread,
 				  tcp_ses, "cifsd");
 	if (IS_ERR(tcp_ses->tsk)) {
 		rc = PTR_ERR(tcp_ses->tsk);
-- 
1.7.6

Re: [PATCH] cifs: fix cast on cifs_demultiplex_thread

[Al Viro]

On Wed, Jul 20, 2011 at 11:09:26AM -0400, Jeff Layton wrote:
> My initial pass at doing this just eliminated the cast altogether. When
> I played with it today though, that caused a compiler warning. So, just
> fix the cast instead.

See 7c97c200e2c5aa8b1067bebb99df0a7c2e12ebf3 in vfs-2.6.git...