From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: trond.myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org,
smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
rjw-KKrjLPT3xs0@public.gmane.org,
linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
john-D0fwSNaahy58zQARNC3f2A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 0/4] allow freezing of tasks with netfs calls in flight
Date: Tue, 11 Oct 2011 08:18:19 +0200 [thread overview]
Message-ID: <20111011061819.GA1377@ucw.cz> (raw)
In-Reply-To: <1317210761-11518-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hi!
> We've had a number of reports recently of people with NFS and CIFS
> mounts that were unable to suspend or hibernate their machines. Here
> are a couple of Fedora bugs that illustrate the problem:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=712088
> https://bugzilla.redhat.com/show_bug.cgi?id=717735
>
> When it occurs the problem is pretty clear. We have a task that's
> sleeping in the kernel in TASK_KILLABLE sleep, generally waiting
> for a reply to come in. Often though, userspace has already taken
> down the interface so that reply will never come. The process then
> fails to freeze and the suspend fails.
Userspace should not take interface down for suspend (*). Why do that?
> This patch fixes this by allowing the TASK_KILLABLE sleeps in NFS and
> CIFS to be awoken by the freezer and then to try to freeze. If a freeze
> event does occur, then the code will treat it as if a schedule() has
> already occured.
Looks like good idea...
(*) unless absolutely neccessary. openvpn?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2011-10-11 6:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 11:52 [PATCH 0/4] allow freezing of tasks with netfs calls in flight Jeff Layton
2011-09-28 11:52 ` [PATCH 3/4] sunrpc: make rpc_wait_bit_killable handle freeze events Jeff Layton
[not found] ` <1317210761-11518-4-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-10-11 6:19 ` Pavel Machek
2011-10-11 10:12 ` Jeff Layton
[not found] ` <20111011061221.2a4a212f-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-10-11 12:52 ` Myklebust, Trond
[not found] ` <2E1EB2CF9ED1CB4AA966F0EB76EAB4430B91E852-hX7t0kiaRRrlMGe9HJ1VYQK/GNPrWCqfQQ4Iyu8u01E@public.gmane.org>
2011-10-11 13:14 ` Jeff Layton
2011-09-28 11:52 ` [PATCH 4/4] nfs: make TASK_KILLABLE sleeps attempt to freeze Jeff Layton
[not found] ` <1317210761-11518-5-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-10-19 15:18 ` [PATCH 4/4] nfs: make TASK_KILLABLE sleeps attempt to freeze (try #2) Jeff Layton
[not found] ` <1317210761-11518-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-28 11:52 ` [PATCH 1/4] freezer: make fake_signal_wake_up wake TASK_KILLABLE tasks too Jeff Layton
[not found] ` <1317210761-11518-2-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-10-11 6:18 ` Pavel Machek
[not found] ` <20111011061847.GB1377-+ZI9xUNit7I@public.gmane.org>
2011-10-11 10:10 ` Jeff Layton
[not found] ` <20111011061000.3a3a03fe-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-10-11 19:14 ` Rafael J. Wysocki
[not found] ` <201110112114.28478.rjw-KKrjLPT3xs0@public.gmane.org>
2011-10-26 19:55 ` Jeff Layton
[not found] ` <20111026155548.4a7c3dd8-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-10-27 20:21 ` Rafael J. Wysocki
[not found] ` <201110272221.06782.rjw-KKrjLPT3xs0@public.gmane.org>
2011-10-27 20:22 ` [linux-pm] " Rafael J. Wysocki
[not found] ` <201110272222.39962.rjw-KKrjLPT3xs0@public.gmane.org>
2011-10-27 20:26 ` Steve French
2011-09-28 11:52 ` [PATCH 2/4] cifs, freezer: add wait_event_freezekillable and have cifs use it Jeff Layton
[not found] ` <1317210761-11518-3-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-09-29 4:28 ` Steve French
[not found] ` <CAH2r5mtBwUkTXLQeXzvTC6oAcz1i9jzPGfiE7XTzDTw12A6C_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-29 10:41 ` Jeff Layton
[not found] ` <20110929064119.160cb455-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-09-29 16:39 ` Steve French
[not found] ` <CAH2r5ms8pg7VW7JMa_eCUomEC1cfiM+rG_JZ6F7cHB=MtZwF0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-09-29 17:29 ` Jeff Layton
2011-10-11 6:18 ` Pavel Machek [this message]
[not found] ` <20111011061819.GA1377-+ZI9xUNit7I@public.gmane.org>
2011-10-11 10:05 ` [PATCH 0/4] allow freezing of tasks with netfs calls in flight Jeff Layton
[not found] ` <20111011060531.09bc378a-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-10-11 19:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011061819.GA1377@ucw.cz \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=john-D0fwSNaahy58zQARNC3f2A@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=rjw-KKrjLPT3xs0@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=trond.myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox