From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: sjayaraman-l3A5Bk7waGM@public.gmane.org
Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-cifs <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Alexander Swen <alex-UE4+9DRHXtc@public.gmane.org>
Subject: Re: [PATCH 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface
Date: Tue, 11 Oct 2011 12:41:59 -0400 [thread overview]
Message-ID: <20111011124159.47790262@corrin.poochiereds.net> (raw)
In-Reply-To: <4E946792.1060405-l3A5Bk7waGM@public.gmane.org>
On Tue, 11 Oct 2011 21:28:10 +0530
Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org> wrote:
> The plan is to deprecate this interface by kernel version 3.4.
>
> Reported-by: Alexander Swen <alex-UE4+9DRHXtc@public.gmane.org>
> Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> ---
> fs/cifs/cifs_debug.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
> index 2fe3cf1..b9c06a8 100644
> --- a/fs/cifs/cifs_debug.c
> +++ b/fs/cifs/cifs_debug.c
> @@ -526,6 +526,9 @@ static ssize_t cifs_oplock_proc_write(struct file *file,
> char c;
> int rc;
>
> + printk(KERN_WARNING "CIFS: The /proc/fs/cifs/OplockEnabled interface "
> + "will be removed in kernel version 3.4. Please migrate to "
> + "using the 'enable_oplocks' module parameter in cifs.ko.");
You probably want a \n at the end of that line.
> rc = get_user(c, buffer);
> if (rc)
> return rc;
--
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
prev parent reply other threads:[~2011-10-11 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 15:58 [PATCH 2/3] cifs: warn about deprecation of /proc/fs/cifs/OplockEnabled interface Suresh Jayaraman
[not found] ` <4E946792.1060405-l3A5Bk7waGM@public.gmane.org>
2011-10-11 16:41 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011124159.47790262@corrin.poochiereds.net \
--to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=alex-UE4+9DRHXtc@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sjayaraman-l3A5Bk7waGM@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox