[RFQ PATCH] cifs: Change default security error message

[RFQ PATCH] cifs: Change default security error message

[Jesper Nilsson]

Hi!

Connecting with a default security mechanism prompts an KERN_ERROR
output warning to the user that the default mechanism will be changed
in Linux 3.3.

We're now at 3.7, so we either could remove the warning completely
(if the default has been changed), or we could bump the number to
what our current target for the change is.


The below patch changes the cERROR (which turns into a printk with KERN_ERROR)
into a straight printk with KERN_WARNING and changes the text to indicate
that it was changed in 3.3.

I expect that the patch is incorrect and that we should choose
another of the alternative solutions above, but I'd like to get
some input on this.

Not-Signed-off-by: Jesper Nilsson <jesper.nilsson-VrBV9hrLPhE@public.gmane.org>
---
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index c83f5b65..968456f 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
 	supported for many years, time to update default security mechanism */
 	if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
 		warned_on_ntlm = true;
-		cERROR(1, "default security mechanism requested.  The default "
-			"security mechanism will be upgraded from ntlm to "
-			"ntlmv2 in kernel release 3.3");
+		printk(KERN_WARNING "default security mechanism requested.  "
+			"The default security mechanism was changed "
+			" from ntlm to ntlmv2 in kernel release 3.3");
 	}
 	ses->overrideSecFlg = volume_info->secFlg;
 


/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson-VrBV9hrLPhE@public.gmane.org

Re: [RFQ PATCH] cifs: Change default security error message

[Steve French]

This has already been changed in the cifs-2.6.git for-next  branch.
We had run into problems with Apple Server with ntlmv2 so it took
longer than expected to test it, and it was too late for 3.7 so the
patch to move to ntlmssp encapsulated ntlmv2 which removes this
warning is in cifs-2.6.git and queued for 3.8

On Thu, Nov 29, 2012 at 11:30 AM, Jesper Nilsson
<jesper.nilsson-VrBV9hrLPhE@public.gmane.org> wrote:
> Hi!
>
> Connecting with a default security mechanism prompts an KERN_ERROR
> output warning to the user that the default mechanism will be changed
> in Linux 3.3.
>
> We're now at 3.7, so we either could remove the warning completely
> (if the default has been changed), or we could bump the number to
> what our current target for the change is.
>
>
> The below patch changes the cERROR (which turns into a printk with KERN_ERROR)
> into a straight printk with KERN_WARNING and changes the text to indicate
> that it was changed in 3.3.
>
> I expect that the patch is incorrect and that we should choose
> another of the alternative solutions above, but I'd like to get
> some input on this.
>
> Not-Signed-off-by: Jesper Nilsson <jesper.nilsson-VrBV9hrLPhE@public.gmane.org>
> ---
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index c83f5b65..968456f 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
>         supported for many years, time to update default security mechanism */
>         if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
>                 warned_on_ntlm = true;
> -               cERROR(1, "default security mechanism requested.  The default "
> -                       "security mechanism will be upgraded from ntlm to "
> -                       "ntlmv2 in kernel release 3.3");
> +               printk(KERN_WARNING "default security mechanism requested.  "
> +                       "The default security mechanism was changed "
> +                       " from ntlm to ntlmv2 in kernel release 3.3");
>         }
>         ses->overrideSecFlg = volume_info->secFlg;
>
>
>
> /^JN - Jesper Nilsson
> --
>                Jesper Nilsson -- jesper.nilsson-VrBV9hrLPhE@public.gmane.org
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve

Re: [RFQ PATCH] cifs: Change default security error message

[Jesper Nilsson]

On Thu, Nov 29, 2012 at 11:52:03AM -0600, Steve French wrote:
> This has already been changed in the cifs-2.6.git for-next  branch.
> We had run into problems with Apple Server with ntlmv2 so it took
> longer than expected to test it, and it was too late for 3.7 so the
> patch to move to ntlmssp encapsulated ntlmv2 which removes this
> warning is in cifs-2.6.git and queued for 3.8

Oh excellent. What´s the git url for the cifs-tree?
The one referred to in MAINTAINERS doesn´t seem to work.

T:	git git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6.git

Or possibly I´m missing something. :-)

Thanks,

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson-VrBV9hrLPhE@public.gmane.org

[PATCH] MAINTAINERS: Fix cifs-tree git url

[Jesper Nilsson]

The cifs-tree is no longer found on kernel.org,
but linux-next uses the tree on samba.org, so use that instead.

Signed-off-by: Jesper Nilsson <jesper.nilsson-VrBV9hrLPhE@public.gmane.org>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 244b2f2..60d0e35 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2009,7 +2009,7 @@ L:	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
 L:	samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org (moderated for non-subscribers)
 W:	http://linux-cifs.samba.org/
 Q:	http://patchwork.ozlabs.org/project/linux-cifs-client/list/
-T:	git git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6.git
+T:	git git://git.samba.org/sfrench/cifs-2.6.git
 S:	Supported
 F:	Documentation/filesystems/cifs.txt
 F:	fs/cifs/
-- 
1.7.11.7


/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson-VrBV9hrLPhE@public.gmane.org

Re: [RFQ PATCH] cifs: Change default security error message

[Jeff Layton]

On Thu, 29 Nov 2012 18:30:53 +0100
Jesper Nilsson <jesper.nilsson-VrBV9hrLPhE@public.gmane.org> wrote:

> Hi!
> 
> Connecting with a default security mechanism prompts an KERN_ERROR
> output warning to the user that the default mechanism will be changed
> in Linux 3.3.
> 
> We're now at 3.7, so we either could remove the warning completely
> (if the default has been changed), or we could bump the number to
> what our current target for the change is.
> 
> 
> The below patch changes the cERROR (which turns into a printk with KERN_ERROR)
> into a straight printk with KERN_WARNING and changes the text to indicate
> that it was changed in 3.3.
> 
> I expect that the patch is incorrect and that we should choose
> another of the alternative solutions above, but I'd like to get
> some input on this.
> 
> Not-Signed-off-by: Jesper Nilsson <jesper.nilsson-VrBV9hrLPhE@public.gmane.org>
> ---
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index c83f5b65..968456f 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
>  	supported for many years, time to update default security mechanism */
>  	if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
>  		warned_on_ntlm = true;
> -		cERROR(1, "default security mechanism requested.  The default "
> -			"security mechanism will be upgraded from ntlm to "
> -			"ntlmv2 in kernel release 3.3");
> +		printk(KERN_WARNING "default security mechanism requested.  "
> +			"The default security mechanism was changed "
> +			" from ntlm to ntlmv2 in kernel release 3.3");
>  	}
>  	ses->overrideSecFlg = volume_info->secFlg;
>  
> 
> 
> /^JN - Jesper Nilsson

I think this warning has lived long enough and needs to go away. Steve
supposedly has a patch that finally makes this change, but it hasn't
been sent to the list yet... Steve?

-- 
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Re: [RFQ PATCH] cifs: Change default security error message

[Steve French]

On Thu, Nov 29, 2012 at 12:25 PM, Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> On Thu, 29 Nov 2012 18:30:53 +0100
> Jesper Nilsson <jesper.nilsson-VrBV9hrLPhE@public.gmane.org> wrote:
>
>> Hi!
>>
>> Connecting with a default security mechanism prompts an KERN_ERROR
>> output warning to the user that the default mechanism will be changed
>> in Linux 3.3.
>>
>> We're now at 3.7, so we either could remove the warning completely
>> (if the default has been changed), or we could bump the number to
>> what our current target for the change is.
>>
>>
>> The below patch changes the cERROR (which turns into a printk with KERN_ERROR)
>> into a straight printk with KERN_WARNING and changes the text to indicate
>> that it was changed in 3.3.
>>
>> I expect that the patch is incorrect and that we should choose
>> another of the alternative solutions above, but I'd like to get
>> some input on this.
>>
>> Not-Signed-off-by: Jesper Nilsson <jesper.nilsson-VrBV9hrLPhE@public.gmane.org>
>> ---
>> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>> index c83f5b65..968456f 100644
>> --- a/fs/cifs/connect.c
>> +++ b/fs/cifs/connect.c
>> @@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
>>       supported for many years, time to update default security mechanism */
>>       if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
>>               warned_on_ntlm = true;
>> -             cERROR(1, "default security mechanism requested.  The default "
>> -                     "security mechanism will be upgraded from ntlm to "
>> -                     "ntlmv2 in kernel release 3.3");
>> +             printk(KERN_WARNING "default security mechanism requested.  "
>> +                     "The default security mechanism was changed "
>> +                     " from ntlm to ntlmv2 in kernel release 3.3");
>>       }
>>       ses->overrideSecFlg = volume_info->secFlg;
>>
>>
>>
>> /^JN - Jesper Nilsson
>
> I think this warning has lived long enough and needs to go away. Steve
> supposedly has a patch that finally makes this change, but it hasn't
> been sent to the list yet... Steve?

It was posted to list on November 25th (and you even included it in
your git tree on samba.org ?!)

-- 
Thanks,

Steve

Re: [RFQ PATCH] cifs: Change default security error message

[Jeff Layton]

On Thu, 29 Nov 2012 12:54:41 -0600
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> On Thu, Nov 29, 2012 at 12:25 PM, Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> > On Thu, 29 Nov 2012 18:30:53 +0100
> > Jesper Nilsson <jesper.nilsson-VrBV9hrLPhE@public.gmane.org> wrote:
> >
> >> Hi!
> >>
> >> Connecting with a default security mechanism prompts an KERN_ERROR
> >> output warning to the user that the default mechanism will be changed
> >> in Linux 3.3.
> >>
> >> We're now at 3.7, so we either could remove the warning completely
> >> (if the default has been changed), or we could bump the number to
> >> what our current target for the change is.
> >>
> >>
> >> The below patch changes the cERROR (which turns into a printk with KERN_ERROR)
> >> into a straight printk with KERN_WARNING and changes the text to indicate
> >> that it was changed in 3.3.
> >>
> >> I expect that the patch is incorrect and that we should choose
> >> another of the alternative solutions above, but I'd like to get
> >> some input on this.
> >>
> >> Not-Signed-off-by: Jesper Nilsson <jesper.nilsson-VrBV9hrLPhE@public.gmane.org>
> >> ---
> >> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> >> index c83f5b65..968456f 100644
> >> --- a/fs/cifs/connect.c
> >> +++ b/fs/cifs/connect.c
> >> @@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
> >>       supported for many years, time to update default security mechanism */
> >>       if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
> >>               warned_on_ntlm = true;
> >> -             cERROR(1, "default security mechanism requested.  The default "
> >> -                     "security mechanism will be upgraded from ntlm to "
> >> -                     "ntlmv2 in kernel release 3.3");
> >> +             printk(KERN_WARNING "default security mechanism requested.  "
> >> +                     "The default security mechanism was changed "
> >> +                     " from ntlm to ntlmv2 in kernel release 3.3");
> >>       }
> >>       ses->overrideSecFlg = volume_info->secFlg;
> >>
> >>
> >>
> >> /^JN - Jesper Nilsson
> >
> > I think this warning has lived long enough and needs to go away. Steve
> > supposedly has a patch that finally makes this change, but it hasn't
> > been sent to the list yet... Steve?
> 
> It was posted to list on November 25th (and you even included it in
> your git tree on samba.org ?!)
> 

Oops, my mistake. You're quite correct...

-- 
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>