* [PATCH] ksmbd: return STATUS_BAD_NETWORK_NAME error status if share is not configured
@ 2022-08-08 12:56 Namjae Jeon
2022-08-09 2:06 ` Hyunchul Lee
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2022-08-08 12:56 UTC (permalink / raw)
To: linux-cifs; +Cc: smfrench, hyc.lee, senozhatsky, atteh.mailbox, Namjae Jeon
If share is not configured in smb.conf, smb2 tree connect should return
STATUS_BAD_NETWORK_NAME instead of STATUS_BAD_NETWORK_PATH.
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
---
fs/ksmbd/mgmt/tree_connect.c | 2 +-
fs/ksmbd/smb2pdu.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/ksmbd/mgmt/tree_connect.c b/fs/ksmbd/mgmt/tree_connect.c
index b35ea6a6abc5..dd262daa2c4a 100644
--- a/fs/ksmbd/mgmt/tree_connect.c
+++ b/fs/ksmbd/mgmt/tree_connect.c
@@ -19,7 +19,7 @@ struct ksmbd_tree_conn_status
ksmbd_tree_conn_connect(struct ksmbd_conn *conn, struct ksmbd_session *sess,
char *share_name)
{
- struct ksmbd_tree_conn_status status = {-EINVAL, NULL};
+ struct ksmbd_tree_conn_status status = {-ENOENT, NULL};
struct ksmbd_tree_connect_response *resp = NULL;
struct ksmbd_share_config *sc;
struct ksmbd_tree_connect *tree_conn = NULL;
diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
index 4c3c840df455..d478c3ea4215 100644
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -1944,8 +1944,9 @@ int smb2_tree_connect(struct ksmbd_work *work)
rsp->hdr.Status = STATUS_SUCCESS;
rc = 0;
break;
+ case -ENOENT:
case KSMBD_TREE_CONN_STATUS_NO_SHARE:
- rsp->hdr.Status = STATUS_BAD_NETWORK_PATH;
+ rsp->hdr.Status = STATUS_BAD_NETWORK_NAME;
break;
case -ENOMEM:
case KSMBD_TREE_CONN_STATUS_NOMEM:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ksmbd: return STATUS_BAD_NETWORK_NAME error status if share is not configured
2022-08-08 12:56 [PATCH] ksmbd: return STATUS_BAD_NETWORK_NAME error status if share is not configured Namjae Jeon
@ 2022-08-09 2:06 ` Hyunchul Lee
0 siblings, 0 replies; 2+ messages in thread
From: Hyunchul Lee @ 2022-08-09 2:06 UTC (permalink / raw)
To: Namjae Jeon; +Cc: linux-cifs, smfrench, senozhatsky, atteh.mailbox
2022년 8월 8일 (월) 오후 9:57, Namjae Jeon <linkinjeon@kernel.org>님이 작성:
>
> If share is not configured in smb.conf, smb2 tree connect should return
> STATUS_BAD_NETWORK_NAME instead of STATUS_BAD_NETWORK_PATH.
>
> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com>
> ---
> fs/ksmbd/mgmt/tree_connect.c | 2 +-
> fs/ksmbd/smb2pdu.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ksmbd/mgmt/tree_connect.c b/fs/ksmbd/mgmt/tree_connect.c
> index b35ea6a6abc5..dd262daa2c4a 100644
> --- a/fs/ksmbd/mgmt/tree_connect.c
> +++ b/fs/ksmbd/mgmt/tree_connect.c
> @@ -19,7 +19,7 @@ struct ksmbd_tree_conn_status
> ksmbd_tree_conn_connect(struct ksmbd_conn *conn, struct ksmbd_session *sess,
> char *share_name)
> {
> - struct ksmbd_tree_conn_status status = {-EINVAL, NULL};
> + struct ksmbd_tree_conn_status status = {-ENOENT, NULL};
> struct ksmbd_tree_connect_response *resp = NULL;
> struct ksmbd_share_config *sc;
> struct ksmbd_tree_connect *tree_conn = NULL;
> diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
> index 4c3c840df455..d478c3ea4215 100644
> --- a/fs/ksmbd/smb2pdu.c
> +++ b/fs/ksmbd/smb2pdu.c
> @@ -1944,8 +1944,9 @@ int smb2_tree_connect(struct ksmbd_work *work)
> rsp->hdr.Status = STATUS_SUCCESS;
> rc = 0;
> break;
> + case -ENOENT:
> case KSMBD_TREE_CONN_STATUS_NO_SHARE:
> - rsp->hdr.Status = STATUS_BAD_NETWORK_PATH;
> + rsp->hdr.Status = STATUS_BAD_NETWORK_NAME;
> break;
> case -ENOMEM:
> case KSMBD_TREE_CONN_STATUS_NOMEM:
> --
> 2.25.1
>
--
Thanks,
Hyunchul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-09 2:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-08 12:56 [PATCH] ksmbd: return STATUS_BAD_NETWORK_NAME error status if share is not configured Namjae Jeon
2022-08-09 2:06 ` Hyunchul Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox