* [PATCH] ksmbd: don't remove dos attribute xattr on O_TRUNC open
@ 2022-08-12 2:56 Namjae Jeon
2022-08-14 2:19 ` Hyunchul Lee
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2022-08-12 2:56 UTC (permalink / raw)
To: linux-cifs; +Cc: smfrench, hyc.lee, senozhatsky, Namjae Jeon
When smb client open file in ksmbd share with O_TRUNC, dos attribute
xattr is removed as well as data in file. This cause the FSCTL_SET_SPARSE
request from the client fails because ksmbd can't update the dos attribute
after setting ATTR_SPARSE_FILE. And this patch fix xfstests generic/469
test also.
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
---
fs/ksmbd/smb2pdu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
index b5c36657ecfd..0c2e57397dd2 100644
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -2330,9 +2330,7 @@ static int smb2_remove_smb_xattrs(struct path *path)
name += strlen(name) + 1) {
ksmbd_debug(SMB, "%s, len %zd\n", name, strlen(name));
- if (strncmp(name, XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN) &&
- strncmp(&name[XATTR_USER_PREFIX_LEN], DOS_ATTRIBUTE_PREFIX,
- DOS_ATTRIBUTE_PREFIX_LEN) &&
+ if (!strncmp(name, XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN) &&
strncmp(&name[XATTR_USER_PREFIX_LEN], STREAM_PREFIX, STREAM_PREFIX_LEN))
continue;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd: don't remove dos attribute xattr on O_TRUNC open
2022-08-12 2:56 [PATCH] ksmbd: don't remove dos attribute xattr on O_TRUNC open Namjae Jeon
@ 2022-08-14 2:19 ` Hyunchul Lee
2022-08-14 2:50 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Hyunchul Lee @ 2022-08-14 2:19 UTC (permalink / raw)
To: Namjae Jeon; +Cc: linux-cifs, smfrench, senozhatsky
2022년 8월 12일 (금) 오전 11:56, Namjae Jeon <linkinjeon@kernel.org>님이 작성:
>
> When smb client open file in ksmbd share with O_TRUNC, dos attribute
> xattr is removed as well as data in file. This cause the FSCTL_SET_SPARSE
> request from the client fails because ksmbd can't update the dos attribute
> after setting ATTR_SPARSE_FILE. And this patch fix xfstests generic/469
> test also.
>
> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
> ---
> fs/ksmbd/smb2pdu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
> index b5c36657ecfd..0c2e57397dd2 100644
> --- a/fs/ksmbd/smb2pdu.c
> +++ b/fs/ksmbd/smb2pdu.c
> @@ -2330,9 +2330,7 @@ static int smb2_remove_smb_xattrs(struct path *path)
> name += strlen(name) + 1) {
> ksmbd_debug(SMB, "%s, len %zd\n", name, strlen(name));
>
> - if (strncmp(name, XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN) &&
> - strncmp(&name[XATTR_USER_PREFIX_LEN], DOS_ATTRIBUTE_PREFIX,
> - DOS_ATTRIBUTE_PREFIX_LEN) &&
> + if (!strncmp(name, XATTR_USER_PREFIX, XATTR_USER_PREFIX_LEN) &&
> strncmp(&name[XATTR_USER_PREFIX_LEN], STREAM_PREFIX, STREAM_PREFIX_LEN))
> continue;
>
We don't need to exclude security.*, trusted.*, system.* from deletion?
> --
> 2.25.1
>
--
Thanks,
Hyunchul
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ksmbd: don't remove dos attribute xattr on O_TRUNC open
2022-08-14 2:19 ` Hyunchul Lee
@ 2022-08-14 2:50 ` Namjae Jeon
0 siblings, 0 replies; 3+ messages in thread
From: Namjae Jeon @ 2022-08-14 2:50 UTC (permalink / raw)
To: Hyunchul Lee; +Cc: linux-cifs, smfrench, senozhatsky
2022-08-14 11:19 GMT+09:00, Hyunchul Lee <hyc.lee@gmail.com>:
> 2022년 8월 12일 (금) 오전 11:56, Namjae Jeon <linkinjeon@kernel.org>님이 작성:
>>
>> When smb client open file in ksmbd share with O_TRUNC, dos attribute
>> xattr is removed as well as data in file. This cause the FSCTL_SET_SPARSE
>> request from the client fails because ksmbd can't update the dos
>> attribute
>> after setting ATTR_SPARSE_FILE. And this patch fix xfstests generic/469
>> test also.
>>
>> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
>> ---
>> fs/ksmbd/smb2pdu.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
>> index b5c36657ecfd..0c2e57397dd2 100644
>> --- a/fs/ksmbd/smb2pdu.c
>> +++ b/fs/ksmbd/smb2pdu.c
>> @@ -2330,9 +2330,7 @@ static int smb2_remove_smb_xattrs(struct path
>> *path)
>> name += strlen(name) + 1) {
>> ksmbd_debug(SMB, "%s, len %zd\n", name, strlen(name));
>>
>> - if (strncmp(name, XATTR_USER_PREFIX,
>> XATTR_USER_PREFIX_LEN) &&
>> - strncmp(&name[XATTR_USER_PREFIX_LEN],
>> DOS_ATTRIBUTE_PREFIX,
>> - DOS_ATTRIBUTE_PREFIX_LEN) &&
>> + if (!strncmp(name, XATTR_USER_PREFIX,
>> XATTR_USER_PREFIX_LEN) &&
>> strncmp(&name[XATTR_USER_PREFIX_LEN], STREAM_PREFIX,
>> STREAM_PREFIX_LEN))
>> continue;
>>
>
> We don't need to exclude security.*, trusted.*, system.* from deletion?
Right, will fix it on v2.
Thanks.
>
>> --
>> 2.25.1
>>
>
>
> --
> Thanks,
> Hyunchul
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-14 2:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-12 2:56 [PATCH] ksmbd: don't remove dos attribute xattr on O_TRUNC open Namjae Jeon
2022-08-14 2:19 ` Hyunchul Lee
2022-08-14 2:50 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox