From: Paulo Alcantara <pc@manguebit.com>
To: smfrench@gmail.com
Cc: linux-cifs@vger.kernel.org, Paulo Alcantara <pc@manguebit.com>
Subject: [PATCH v2 9/9] smb: client: fix missing mode bits for SMB symlinks
Date: Sat, 25 Nov 2023 23:55:10 -0300 [thread overview]
Message-ID: <20231126025510.28147-10-pc@manguebit.com> (raw)
In-Reply-To: <20231126025510.28147-1-pc@manguebit.com>
When instantiating inodes for SMB symlinks, add the mode bits from
@cifs_sb->ctx->file_mode as we already do for the other special files.
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
---
fs/smb/client/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/smb/client/inode.c b/fs/smb/client/inode.c
index d7d19cdb3c8c..39a08f80735d 100644
--- a/fs/smb/client/inode.c
+++ b/fs/smb/client/inode.c
@@ -791,7 +791,7 @@ bool cifs_reparse_point_to_fattr(struct cifs_sb_info *cifs_sb,
case 0: /* SMB1 symlink */
case IO_REPARSE_TAG_SYMLINK:
case IO_REPARSE_TAG_NFS:
- fattr->cf_mode = S_IFLNK;
+ fattr->cf_mode = S_IFLNK | cifs_sb->ctx->file_mode;
fattr->cf_dtype = DT_LNK;
break;
default:
--
2.43.0
next prev parent reply other threads:[~2023-11-26 2:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 2:55 [PATCH v2 0/9] reparse points work Paulo Alcantara
2023-11-26 2:55 ` [PATCH v2 1/9] smb: client: extend smb2_compound_op() to accept more commands Paulo Alcantara
2023-11-26 2:55 ` [PATCH v2 2/9] smb: client: allow creating special files via reparse points Paulo Alcantara
2023-11-26 2:55 ` [PATCH v2 3/9] smb: client: allow creating symlinks " Paulo Alcantara
2023-11-26 2:55 ` [PATCH v2 4/9] smb: client: optimise reparse point querying Paulo Alcantara
2023-11-26 2:55 ` [PATCH v2 5/9] smb: client: fix renaming of reparse points Paulo Alcantara
2023-11-26 2:55 ` [PATCH v2 6/9] smb: client: fix hardlinking " Paulo Alcantara
2023-11-26 2:55 ` [PATCH v2 7/9] smb: client: cleanup smb2_query_reparse_point() Paulo Alcantara
2023-11-26 2:55 ` [PATCH v2 8/9] smb: client: optimise dentry revalidation for reparse points Paulo Alcantara
2023-11-26 2:55 ` Paulo Alcantara [this message]
2023-11-27 4:28 ` [PATCH v2 0/9] reparse points work Steve French
2023-11-27 10:14 ` Paulo Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231126025510.28147-10-pc@manguebit.com \
--to=pc@manguebit.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox