Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Steve French <smfrench@gmail.com>
Cc: Steve French <sfrench@samba.org>,
	Paulo Alcantara <pc@manguebit.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] cifs: Add mount option -o reparse=native
Date: Fri, 11 Oct 2024 00:38:57 +0200	[thread overview]
Message-ID: <20241010223857.vasehbu7nilemato@pali> (raw)
In-Reply-To: <CAH2r5mvV7WzB62hWt4K6oF_xyrQH1EF75zc0JdfjsjFEV4SQKQ@mail.gmail.com>

On Thursday 10 October 2024 17:21:59 Steve French wrote:
> On Thu, Oct 10, 2024 at 5:17 PM Steve French <smfrench@gmail.com> wrote:
> >
> >
> >
> > On Mon, Oct 7, 2024 at 1:36 PM Pali Rohár <pali@kernel.org> wrote:
> >>
> >> Currently choosing how new symlinks are created is quite complicated.
> >>
> >> Without these patch series, by default new symlinks are created via
> >> native reparse points, even when reparse=nfs or reparse=wsl is
> >> specified. There is no possibility to create a NFS-style or WSL-style
> >> symlink yet, and this patch series address this missing functionality.
> >> When option -o sfu is specified then all new symlinks are created in
> >> SFU-style, independently of -o reparse option. And when -o mfsymlinks is
> >> specified then all new symlinks are created in mf style, independently
> >> of -o reparse and -o sfu options.
> >>
> >> This patch series does not change -o sfu and -o mfsymlinks overrides, it
> >> just changes the way how -o reparse is handled.
> >>
> 
> I lean toward something similar, and more intuitive - do not have
> "reparse=" control symlink creation - but instead use another mount
> parm (e.g. "symlink=") for that.  It would be rarely used - only if
> you don't want the default (windows default format too) for server
> symlinks or "mfsymlinks" (for client only symlinks):
> 
> 1) "symlink=" if specified can be set to one of five formats (with the
> default being the windows format)
>   a) "mfsymlinks" (Mac style which is safer for many use cases since
> they are "client only" symlinks which the server will never use)
>      Setting "symlink=mfsymlinks" will have the same effect as just
> specifying "mfsymlinks" so won't break anything
>   b) "default" (or "windows") which uses the default symlink format
> when trying to create a new symlink
>   c) "nfs"
>   d) "wsl"
>   e) "sfu"
> 2) "reparse=" will still control how special files are created (char,
> block, fifo, socket) and can be set to:
>    a) "nfs" (default)
>    b) or "wsl"
>    c) If "sfu" set on mount will cause special files to be created
> with "sfu" format instead of using reparse points to create
> 3) reading reparse points will always be supported (unless you want to
> add a new parameter "reparse=none" to treat all reparse points as
> empty directories)
> 4) reading special files via the old "sfu" will only be supported if
> you mount with "sfu"
> 
> 
> 
> 
> -- 
> Thanks,
> 
> Steve

Ok, and how to handle creating new sockets? For me it makes sense to
create new sockets in "native" AF_UNIX style - compatible with Windows
WinAPI / WinSocks. Should be there also a new parameter?

  reply	other threads:[~2024-10-10 22:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-06 10:00 [PATCH 0/7] cifs: Improve mount option -o reparse and support for native Windows sockets Pali Rohár
2024-10-06 10:00 ` [PATCH 1/7] cifs: Add mount option -o reparse=native Pali Rohár
2024-10-07  4:28   ` Steve French
2024-10-07 18:36     ` Pali Rohár
     [not found]       ` <CAH2r5mttO-aDq94QrLQm10xJRGLg=PULqX9fcfoykAweVVO+uQ@mail.gmail.com>
2024-10-10 22:21         ` Steve French
2024-10-10 22:38           ` Pali Rohár [this message]
     [not found]             ` <CAH2r5msEiD05ehJs_a05sP_rX7BkVH-9LZp8Sj6EFbpZA9bfrg@mail.gmail.com>
2024-10-10 22:44               ` Pali Rohár
2024-10-06 10:00 ` [PATCH 2/7] cifs: Add mount option -o reparse=none Pali Rohár
2024-10-06 10:00 ` [PATCH 3/7] cifs: Add support for creating native Windows sockets Pali Rohár
2024-10-10 21:47   ` Pali Rohár
2024-10-06 10:00 ` [PATCH 4/7] cifs: Add support for creating NFS-style symlinks Pali Rohár
2024-10-06 10:00 ` [PATCH 5/7] cifs: Improve guard for excluding $LXDEV xattr Pali Rohár
2024-10-06 10:00 ` [PATCH 6/7] cifs: Add support for creating WSL-style symlinks Pali Rohár
2024-10-10 21:50   ` Pali Rohár
2024-10-06 10:00 ` [PATCH 7/7] cifs: Validate content of WSL reparse point buffers Pali Rohár
2024-10-07  4:23 ` [PATCH 0/7] cifs: Improve mount option -o reparse and support for native Windows sockets Steve French
2024-10-12  8:52 ` [PATCH v2 0/7] Allow to choose symlink and socket type Pali Rohár
2024-10-12  8:55   ` [PATCH v2 1/7] cifs: Add mount option -o symlink= for choosing symlink create type Pali Rohár
2024-10-12  8:55   ` [PATCH v2 2/7] cifs: Add mount option -o reparse=none Pali Rohár
2024-10-12  8:55   ` [PATCH v2 3/7] cifs: Add support for creating native Windows sockets Pali Rohár
2024-10-12  8:56   ` [PATCH v2 4/7] cifs: Add support for creating NFS-style symlinks Pali Rohár
2024-12-09 18:00     ` Pali Rohár
2024-10-12  8:56   ` [PATCH v2 5/7] cifs: Improve guard for excluding $LXDEV xattr Pali Rohár
2024-10-12  8:56   ` [PATCH v2 6/7] cifs: Add support for creating WSL-style symlinks Pali Rohár
2024-10-12  8:56   ` [PATCH v2 7/7] cifs: Validate content of WSL reparse point buffers Pali Rohár
     [not found]   ` <CAH2r5mtGqqM35Cy5k9NN=X05rTZPk-adhb7LgoV8PGNVL9P6FQ@mail.gmail.com>
2024-10-13  4:19     ` Fwd: [PATCH v2 0/7] Allow to choose symlink and socket type Steve French
2024-10-13  8:59     ` Pali Rohár
2024-10-13 13:38     ` Pali Rohár
2024-10-14  9:32       ` Pali Rohár
2024-10-28 10:13   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241010223857.vasehbu7nilemato@pali \
    --to=pali@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pc@manguebit.com \
    --cc=ronniesahlberg@gmail.com \
    --cc=sfrench@samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox