From: Halil Pasic <pasic@linux.ibm.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Wenjia Zhang <wenjia@linux.ibm.com>,
Wen Gu <guwen@linux.alibaba.com>,
"D. Wythe" <alibuda@linux.alibaba.com>,
Tony Lu <tonylu@linux.alibaba.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Jan Karcher <jaka@linux.ibm.com>,
Gerd Bayer <gbayer@linux.ibm.com>,
Alexandra Winter <wintera@linux.ibm.com>,
Nils Hoppmann <niho@linux.ibm.com>,
Niklas Schnell <schnelle@linux.ibm.com>,
Thorsten Winkler <twinkler@linux.ibm.com>,
Karsten Graul <kgraul@linux.ibm.com>,
Stefan Raspl <raspl@linux.ibm.com>, Aswin K <aswin@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
linux-cifs@vger.kernel.org
Subject: Re: [PATCH net] net/smc: Fix lookup of netdev by using ib_device_get_netdev()
Date: Thu, 7 Nov 2024 12:56:43 +0100 [thread overview]
Message-ID: <20241107125643.04f97394.pasic@linux.ibm.com> (raw)
In-Reply-To: <20241106135910.GF5006@unreal>
On Wed, 6 Nov 2024 15:59:10 +0200
Leon Romanovsky <leon@kernel.org> wrote:
> > Does fs/smb/server/transport_rdma.c qualify as inside of RDMA core code?
>
> RDMA core code is drivers/infiniband/core/*.
Understood. So this is a violation of the no direct access to the
callbacks rule.
>
> > I would guess it is not, and I would not actually mind sending a patch
> > but I have trouble figuring out the logic behind commit ecce70cf17d9
> > ("ksmbd: fix missing RDMA-capable flag for IPoIB device in
> > ksmbd_rdma_capable_netdev()").
>
> It is strange version of RDMA-CM. All other ULPs use RDMA-CM to avoid
> GID, netdev and fabric complexity.
I'm not familiar enough with either of the subsystems. Based on your
answer my guess is that it ain't outright bugous but still a layering
violation. Copying linux-cifs@vger.kernel.org so that
the smb are aware.
Thank you very much for all the explanations!
Regards,
Halil
next parent reply other threads:[~2024-11-07 11:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241025072356.56093-1-wenjia@linux.ibm.com>
[not found] ` <20241027201857.GA1615717@unreal>
[not found] ` <8d17b403-aefa-4f36-a913-7ace41cf2551@linux.ibm.com>
[not found] ` <20241105112313.GE311159@unreal>
[not found] ` <20241106102439.4ca5effc.pasic@linux.ibm.com>
[not found] ` <20241106135910.GF5006@unreal>
2024-11-07 11:56 ` Halil Pasic [this message]
2024-11-07 12:13 ` [PATCH net] net/smc: Fix lookup of netdev by using ib_device_get_netdev() Leon Romanovsky
2024-11-07 23:40 ` Namjae Jeon
2024-11-08 17:59 ` Leon Romanovsky
2024-11-09 5:32 ` Namjae Jeon
2024-12-13 11:07 ` Kangjing Huang
2024-12-13 12:15 ` Leon Romanovsky
2024-12-14 2:33 ` Namjae Jeon
2024-12-14 6:06 ` Leon Romanovsky
2024-12-14 8:02 ` Kangjing Huang
2024-12-19 16:56 ` Leon Romanovsky
2025-01-07 22:51 ` Kangjing Huang
2025-01-08 9:31 ` Leon Romanovsky
2025-01-08 17:27 ` Tom Talpey
2025-01-08 22:40 ` Kangjing Huang
2025-01-09 7:59 ` Leon Romanovsky
2025-01-09 8:02 ` Christoph Hellwig
2025-01-09 10:43 ` Kangjing Huang
2025-01-09 17:49 ` Tom Talpey
2025-01-15 7:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107125643.04f97394.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=alibuda@linux.alibaba.com \
--cc=aswin@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gbayer@linux.ibm.com \
--cc=guwen@linux.alibaba.com \
--cc=hca@linux.ibm.com \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niho@linux.ibm.com \
--cc=pabeni@redhat.com \
--cc=raspl@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=twinkler@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox