From: Christoph Hellwig <hch@infradead.org>
To: Kangjing Huang <huangkangjing@gmail.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Namjae Jeon <linkinjeon@kernel.org>,
linux-cifs@vger.kernel.org
Subject: Re: [PATCH net] net/smc: Fix lookup of netdev by using ib_device_get_netdev()
Date: Thu, 9 Jan 2025 00:02:53 -0800 [thread overview]
Message-ID: <Z3-CrT64eQdPQIDu@infradead.org> (raw)
In-Reply-To: <CAPbmFQbyouZXsUzOiGXSoQrvjOQooVY8yHZe2VjnX3P-cscdxQ@mail.gmail.com>
On Tue, Jan 07, 2025 at 10:51:19PM +0000, Kangjing Huang wrote:
> This is good to know. However, since the SMB protocol explicitly calls
> for enumeration of all network interfaces on the server host,
> including their RDMA capabilities, I believe this is a sensible
> exception to the layering rule. Or is there anyway else to do this
> enumeration from the kernel space?
No, it's not a sensible exception. It's a massive data leak and a
completely idiotic protocol feasture Linux should not support. If the
protocol requires a lsit of network interfaces, a Linux server should
require explicitly require that list to be configured and not expose
private information to the untrusted network.
next prev parent reply other threads:[~2025-01-09 8:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241025072356.56093-1-wenjia@linux.ibm.com>
[not found] ` <20241027201857.GA1615717@unreal>
[not found] ` <8d17b403-aefa-4f36-a913-7ace41cf2551@linux.ibm.com>
[not found] ` <20241105112313.GE311159@unreal>
[not found] ` <20241106102439.4ca5effc.pasic@linux.ibm.com>
[not found] ` <20241106135910.GF5006@unreal>
2024-11-07 11:56 ` [PATCH net] net/smc: Fix lookup of netdev by using ib_device_get_netdev() Halil Pasic
2024-11-07 12:13 ` Leon Romanovsky
2024-11-07 23:40 ` Namjae Jeon
2024-11-08 17:59 ` Leon Romanovsky
2024-11-09 5:32 ` Namjae Jeon
2024-12-13 11:07 ` Kangjing Huang
2024-12-13 12:15 ` Leon Romanovsky
2024-12-14 2:33 ` Namjae Jeon
2024-12-14 6:06 ` Leon Romanovsky
2024-12-14 8:02 ` Kangjing Huang
2024-12-19 16:56 ` Leon Romanovsky
2025-01-07 22:51 ` Kangjing Huang
2025-01-08 9:31 ` Leon Romanovsky
2025-01-08 17:27 ` Tom Talpey
2025-01-08 22:40 ` Kangjing Huang
2025-01-09 7:59 ` Leon Romanovsky
2025-01-09 8:02 ` Christoph Hellwig [this message]
2025-01-09 10:43 ` Kangjing Huang
2025-01-09 17:49 ` Tom Talpey
2025-01-15 7:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3-CrT64eQdPQIDu@infradead.org \
--to=hch@infradead.org \
--cc=huangkangjing@gmail.com \
--cc=leon@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox