From: Marco Crivellari <marco.crivellari@suse.com>
To: linux-cifs@vger.kernel.org
Cc: smfrench@gmail.com, pc@manguebit.com, ronniesahlberg@gmail.com,
sprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com,
henrique.carvalho@suse.com, ematsumiya@suse.com,
Marco Crivellari <marco.crivellari@suse.com>
Subject: [PATCH] Update misleading comment in cifs_chan_update_iface
Date: Thu, 7 Nov 2024 17:40:29 +0100 [thread overview]
Message-ID: <20241107164029.322205-1-marco.crivellari@suse.com> (raw)
Since commit 8da33fd11c05 ("cifs: avoid deadlocks while updating iface")
cifs_chan_update_iface now takes the chan_lock itself, so update the
comment accordingly.
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
---
fs/smb/client/sess.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
index 3216f786908f..51614a36a100 100644
--- a/fs/smb/client/sess.c
+++ b/fs/smb/client/sess.c
@@ -359,10 +359,7 @@ cifs_disable_secondary_channels(struct cifs_ses *ses)
spin_unlock(&ses->chan_lock);
}
-/*
- * update the iface for the channel if necessary.
- * Must be called with chan_lock held.
- */
+/* update the iface for the channel if necessary. */
void
cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)
{
--
2.47.0
next reply other threads:[~2024-11-07 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 16:40 Marco Crivellari [this message]
2024-11-25 15:56 ` [PATCH] Update misleading comment in cifs_chan_update_iface Enzo Matsumiya
2024-11-25 20:06 ` Steve French
2024-11-26 8:37 ` Marco Crivellari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107164029.322205-1-marco.crivellari@suse.com \
--to=marco.crivellari@suse.com \
--cc=bharathsm@microsoft.com \
--cc=ematsumiya@suse.com \
--cc=henrique.carvalho@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox