* [PATCH] Update misleading comment in cifs_chan_update_iface
@ 2024-11-07 16:40 Marco Crivellari
2024-11-25 15:56 ` Enzo Matsumiya
0 siblings, 1 reply; 4+ messages in thread
From: Marco Crivellari @ 2024-11-07 16:40 UTC (permalink / raw)
To: linux-cifs
Cc: smfrench, pc, ronniesahlberg, sprasad, tom, bharathsm,
henrique.carvalho, ematsumiya, Marco Crivellari
Since commit 8da33fd11c05 ("cifs: avoid deadlocks while updating iface")
cifs_chan_update_iface now takes the chan_lock itself, so update the
comment accordingly.
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
---
fs/smb/client/sess.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
index 3216f786908f..51614a36a100 100644
--- a/fs/smb/client/sess.c
+++ b/fs/smb/client/sess.c
@@ -359,10 +359,7 @@ cifs_disable_secondary_channels(struct cifs_ses *ses)
spin_unlock(&ses->chan_lock);
}
-/*
- * update the iface for the channel if necessary.
- * Must be called with chan_lock held.
- */
+/* update the iface for the channel if necessary. */
void
cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)
{
--
2.47.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Update misleading comment in cifs_chan_update_iface
2024-11-07 16:40 [PATCH] Update misleading comment in cifs_chan_update_iface Marco Crivellari
@ 2024-11-25 15:56 ` Enzo Matsumiya
2024-11-25 20:06 ` Steve French
0 siblings, 1 reply; 4+ messages in thread
From: Enzo Matsumiya @ 2024-11-25 15:56 UTC (permalink / raw)
To: Marco Crivellari
Cc: linux-cifs, smfrench, pc, ronniesahlberg, sprasad, tom, bharathsm,
henrique.carvalho, ematsumiya
On 11/07, Marco Crivellari wrote:
>Since commit 8da33fd11c05 ("cifs: avoid deadlocks while updating iface")
>cifs_chan_update_iface now takes the chan_lock itself, so update the
>comment accordingly.
>
>Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
>---
> fs/smb/client/sess.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
>index 3216f786908f..51614a36a100 100644
>--- a/fs/smb/client/sess.c
>+++ b/fs/smb/client/sess.c
>@@ -359,10 +359,7 @@ cifs_disable_secondary_channels(struct cifs_ses *ses)
> spin_unlock(&ses->chan_lock);
> }
>
>-/*
>- * update the iface for the channel if necessary.
>- * Must be called with chan_lock held.
>- */
>+/* update the iface for the channel if necessary. */
> void
> cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)
> {
>--
Reviewed-by: Enzo Matsumiya <ematsumiya@suse.de>
Cheers
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Update misleading comment in cifs_chan_update_iface
2024-11-25 15:56 ` Enzo Matsumiya
@ 2024-11-25 20:06 ` Steve French
2024-11-26 8:37 ` Marco Crivellari
0 siblings, 1 reply; 4+ messages in thread
From: Steve French @ 2024-11-25 20:06 UTC (permalink / raw)
To: Enzo Matsumiya
Cc: Marco Crivellari, linux-cifs, pc, ronniesahlberg, sprasad, tom,
bharathsm, henrique.carvalho, ematsumiya
added to cifs-2.6.git for-next (and added the RB to the other three a well)
On Mon, Nov 25, 2024 at 9:58 AM Enzo Matsumiya <ematsumiya@suse.de> wrote:
>
> On 11/07, Marco Crivellari wrote:
> >Since commit 8da33fd11c05 ("cifs: avoid deadlocks while updating iface")
> >cifs_chan_update_iface now takes the chan_lock itself, so update the
> >comment accordingly.
> >
> >Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
> >---
> > fs/smb/client/sess.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> >diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
> >index 3216f786908f..51614a36a100 100644
> >--- a/fs/smb/client/sess.c
> >+++ b/fs/smb/client/sess.c
> >@@ -359,10 +359,7 @@ cifs_disable_secondary_channels(struct cifs_ses *ses)
> > spin_unlock(&ses->chan_lock);
> > }
> >
> >-/*
> >- * update the iface for the channel if necessary.
> >- * Must be called with chan_lock held.
> >- */
> >+/* update the iface for the channel if necessary. */
> > void
> > cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)
> > {
> >--
>
> Reviewed-by: Enzo Matsumiya <ematsumiya@suse.de>
>
>
> Cheers
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Update misleading comment in cifs_chan_update_iface
2024-11-25 20:06 ` Steve French
@ 2024-11-26 8:37 ` Marco Crivellari
0 siblings, 0 replies; 4+ messages in thread
From: Marco Crivellari @ 2024-11-26 8:37 UTC (permalink / raw)
To: Steve French
Cc: Enzo Matsumiya, linux-cifs, pc, ronniesahlberg, sprasad, tom,
bharathsm, henrique.carvalho, ematsumiya
Thank you,
Marco
On Mon, Nov 25, 2024 at 9:07 PM Steve French <smfrench@gmail.com> wrote:
>
> added to cifs-2.6.git for-next (and added the RB to the other three a well)
>
> On Mon, Nov 25, 2024 at 9:58 AM Enzo Matsumiya <ematsumiya@suse.de> wrote:
> >
> > On 11/07, Marco Crivellari wrote:
> > >Since commit 8da33fd11c05 ("cifs: avoid deadlocks while updating iface")
> > >cifs_chan_update_iface now takes the chan_lock itself, so update the
> > >comment accordingly.
> > >
> > >Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
> > >---
> > > fs/smb/client/sess.c | 5 +----
> > > 1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > >diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c
> > >index 3216f786908f..51614a36a100 100644
> > >--- a/fs/smb/client/sess.c
> > >+++ b/fs/smb/client/sess.c
> > >@@ -359,10 +359,7 @@ cifs_disable_secondary_channels(struct cifs_ses *ses)
> > > spin_unlock(&ses->chan_lock);
> > > }
> > >
> > >-/*
> > >- * update the iface for the channel if necessary.
> > >- * Must be called with chan_lock held.
> > >- */
> > >+/* update the iface for the channel if necessary. */
> > > void
> > > cifs_chan_update_iface(struct cifs_ses *ses, struct TCP_Server_Info *server)
> > > {
> > >--
> >
> > Reviewed-by: Enzo Matsumiya <ematsumiya@suse.de>
> >
> >
> > Cheers
>
>
>
> --
> Thanks,
>
> Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-26 8:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-07 16:40 [PATCH] Update misleading comment in cifs_chan_update_iface Marco Crivellari
2024-11-25 15:56 ` Enzo Matsumiya
2024-11-25 20:06 ` Steve French
2024-11-26 8:37 ` Marco Crivellari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox