* [PATCH] smb: client: Use str_yes_no() helper function
@ 2024-11-12 10:58 Thorsten Blum
2024-11-13 17:05 ` Steve French
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-11-12 10:58 UTC (permalink / raw)
To: Steve French, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, Bharath SM
Cc: Thorsten Blum, linux-cifs, samba-technical, linux-kernel
Remove hard-coded strings by using the str_yes_no() helper function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/smb/client/dfs_cache.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/smb/client/dfs_cache.c b/fs/smb/client/dfs_cache.c
index 110f03df012a..00820f57b434 100644
--- a/fs/smb/client/dfs_cache.c
+++ b/fs/smb/client/dfs_cache.c
@@ -173,8 +173,8 @@ static int dfscache_proc_show(struct seq_file *m, void *v)
"cache entry: path=%s,type=%s,ttl=%d,etime=%ld,hdr_flags=0x%x,ref_flags=0x%x,interlink=%s,path_consumed=%d,expired=%s\n",
ce->path, ce->srvtype == DFS_TYPE_ROOT ? "root" : "link",
ce->ttl, ce->etime.tv_nsec, ce->hdr_flags, ce->ref_flags,
- DFS_INTERLINK(ce->hdr_flags) ? "yes" : "no",
- ce->path_consumed, cache_entry_expired(ce) ? "yes" : "no");
+ str_yes_no(DFS_INTERLINK(ce->hdr_flags)),
+ ce->path_consumed, str_yes_no(cache_entry_expired(ce)));
list_for_each_entry(t, &ce->tlist, list) {
seq_printf(m, " %s%s\n",
@@ -242,9 +242,9 @@ static inline void dump_ce(const struct cache_entry *ce)
ce->srvtype == DFS_TYPE_ROOT ? "root" : "link", ce->ttl,
ce->etime.tv_nsec,
ce->hdr_flags, ce->ref_flags,
- DFS_INTERLINK(ce->hdr_flags) ? "yes" : "no",
+ str_yes_no(DFS_INTERLINK(ce->hdr_flags)),
ce->path_consumed,
- cache_entry_expired(ce) ? "yes" : "no");
+ str_yes_no(cache_entry_expired(ce)));
dump_tgts(ce);
}
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] smb: client: Use str_yes_no() helper function
2024-11-12 10:58 [PATCH] smb: client: Use str_yes_no() helper function Thorsten Blum
@ 2024-11-13 17:05 ` Steve French
0 siblings, 0 replies; 2+ messages in thread
From: Steve French @ 2024-11-13 17:05 UTC (permalink / raw)
To: Thorsten Blum
Cc: Steve French, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, Bharath SM, linux-cifs, samba-technical, linux-kernel
tentatively merged into cifs-2.6.git for-next pending testing and
additional review
On Tue, Nov 12, 2024 at 5:33 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_yes_no() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> fs/smb/client/dfs_cache.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/smb/client/dfs_cache.c b/fs/smb/client/dfs_cache.c
> index 110f03df012a..00820f57b434 100644
> --- a/fs/smb/client/dfs_cache.c
> +++ b/fs/smb/client/dfs_cache.c
> @@ -173,8 +173,8 @@ static int dfscache_proc_show(struct seq_file *m, void *v)
> "cache entry: path=%s,type=%s,ttl=%d,etime=%ld,hdr_flags=0x%x,ref_flags=0x%x,interlink=%s,path_consumed=%d,expired=%s\n",
> ce->path, ce->srvtype == DFS_TYPE_ROOT ? "root" : "link",
> ce->ttl, ce->etime.tv_nsec, ce->hdr_flags, ce->ref_flags,
> - DFS_INTERLINK(ce->hdr_flags) ? "yes" : "no",
> - ce->path_consumed, cache_entry_expired(ce) ? "yes" : "no");
> + str_yes_no(DFS_INTERLINK(ce->hdr_flags)),
> + ce->path_consumed, str_yes_no(cache_entry_expired(ce)));
>
> list_for_each_entry(t, &ce->tlist, list) {
> seq_printf(m, " %s%s\n",
> @@ -242,9 +242,9 @@ static inline void dump_ce(const struct cache_entry *ce)
> ce->srvtype == DFS_TYPE_ROOT ? "root" : "link", ce->ttl,
> ce->etime.tv_nsec,
> ce->hdr_flags, ce->ref_flags,
> - DFS_INTERLINK(ce->hdr_flags) ? "yes" : "no",
> + str_yes_no(DFS_INTERLINK(ce->hdr_flags)),
> ce->path_consumed,
> - cache_entry_expired(ce) ? "yes" : "no");
> + str_yes_no(cache_entry_expired(ce)));
> dump_tgts(ce);
> }
>
> --
> 2.47.0
>
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-13 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 10:58 [PATCH] smb: client: Use str_yes_no() helper function Thorsten Blum
2024-11-13 17:05 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox