From: "Pali Rohár" <pali@kernel.org>
To: Paulo Alcantara <pc@manguebit.com>
Cc: Ralph Boehme <slow@samba.org>,
Steven French <Steven.French@microsoft.com>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: Special files broken against Samba master
Date: Wed, 1 Jan 2025 14:39:39 +0100 [thread overview]
Message-ID: <20250101133939.5izufhh2fctxo3et@pali> (raw)
In-Reply-To: <8d0a687be2cba9cb4d2745c0752d8fbf@manguebit.com>
On Tuesday 10 December 2024 10:19:26 Paulo Alcantara wrote:
> Pali Rohár <pali@kernel.org> writes:
>
> > Ok. Would you have a time to prepare a patch? I have still feeling that
> > the smb2_compound_op() code and EAs code is rather complicated for me.
> > I would like if somebody else could look at it, as I have feeling if I
> > try to do it, it can end up with something more broken...
>
> Yeah, it's a bit tricky. I'll let you know when I have patch so I can
> try it against your old servers.
I looked at that code and it looks to be really more complicated to
implement partial parsing of the reply, as compound code is bound to
many places and code paths.
Meanwhile I have tried to implement a new version to retry the call
without querying EAs when server returns that EAs on specific paths are
unsupported:
https://patchwork.kernel.org/project/cifs-client/patch/20241224131859.3457-1-pali@kernel.org/
I think that this approach should now work correctly.
prev parent reply other threads:[~2025-01-01 13:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 19:23 Special files broken against Samba master Ralph Boehme
2024-12-02 22:40 ` Paulo Alcantara
2024-12-03 10:02 ` Ralph Boehme
2024-12-03 19:56 ` Steve French
2024-12-03 20:25 ` Ralph Boehme
2024-12-05 0:06 ` Steve French
2024-12-06 12:11 ` Ralph Boehme
2024-12-06 14:45 ` Steve French
2024-12-09 18:39 ` Pali Rohár
2024-12-09 19:28 ` Paulo Alcantara
2024-12-09 19:34 ` Pali Rohár
2024-12-09 19:42 ` Paulo Alcantara
2024-12-09 19:54 ` Pali Rohár
2024-12-10 13:19 ` Paulo Alcantara
2025-01-01 13:39 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250101133939.5izufhh2fctxo3et@pali \
--to=pali@kernel.org \
--cc=Steven.French@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=slow@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox