From: Ralph Boehme <slow@samba.org>
To: Steve French <smfrench@gmail.com>
Cc: Paulo Alcantara <pc@manguebit.com>,
Steven French <Steven.French@microsoft.com>,
CIFS <linux-cifs@vger.kernel.org>,
Namjae Jeon <linkinjeon@kernel.org>
Subject: Re: Special files broken against Samba master
Date: Tue, 3 Dec 2024 21:25:54 +0100 [thread overview]
Message-ID: <cb0a9829-203e-4d11-b9bf-277e4a1e1850@samba.org> (raw)
In-Reply-To: <CAH2r5mvrjGgtf4o+dk9KcEqM+QtvYodhbBNzcK5SDyyepK+Xog@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1114 bytes --]
Hi Steve!
Thanks for testing! ksmbd needs to be updated to implement the current
spec. The next major Samba version 4.22 will ship this stuff, so I'd be
good if cifs.ko follows along asap.
Thanks!
-slow
On 12/3/24 8:56 PM, Steve French wrote:
> Looks like a big improvement - fewer roundtrips to Samba. Haven't
> tried to Windows yet, but it does look like it breaks mounts to ksmbd
> so I may need a minor change to cifs.ko or ksmbd.
>
> On Tue, Dec 3, 2024 at 4:04 AM Ralph Boehme <slow@samba.org> wrote:
>>
>> On 12/2/24 11:40 PM, Paulo Alcantara wrote:
>>> Ralph Boehme <slow@samba.org> writes:
>>>> I'm sure I'm doing things wrong. Can you help me getting this across the
>>>> line?
>>>
>>> Patches look good, thanks. It would be great making sure it didn't
>>> regress against NFS server on Windows, but Steve can do that.
>>
>> great, thanks for taking a look! I was expecting I was likely doing some
>> stupid beginner mistakes, but if you think the changes look good, here's
>> a v2 with just my +1 added, without code changes.
>>
>> Thanks!
>> -slow
>
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2024-12-03 20:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 19:23 Special files broken against Samba master Ralph Boehme
2024-12-02 22:40 ` Paulo Alcantara
2024-12-03 10:02 ` Ralph Boehme
2024-12-03 19:56 ` Steve French
2024-12-03 20:25 ` Ralph Boehme [this message]
2024-12-05 0:06 ` Steve French
2024-12-06 12:11 ` Ralph Boehme
2024-12-06 14:45 ` Steve French
2024-12-09 18:39 ` Pali Rohár
2024-12-09 19:28 ` Paulo Alcantara
2024-12-09 19:34 ` Pali Rohár
2024-12-09 19:42 ` Paulo Alcantara
2024-12-09 19:54 ` Pali Rohár
2024-12-10 13:19 ` Paulo Alcantara
2025-01-01 13:39 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb0a9829-203e-4d11-b9bf-277e4a1e1850@samba.org \
--to=slow@samba.org \
--cc=Steven.French@microsoft.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox