* [PATCH 1/2] cifscreds: use continue instead of break when matching commands
@ 2025-01-14 20:34 tbecker
2025-01-20 16:02 ` Paulo Alcantara
0 siblings, 1 reply; 2+ messages in thread
From: tbecker @ 2025-01-14 20:34 UTC (permalink / raw)
To: linux-cifs; +Cc: Thiago Becker
From: Thiago Becker <tbecker@redhat.com>
While matching the commands in cifscreds, continue attempting to
match to detect ambiguous commands.
Signed-off-by: Thiago Becker <tbecker@redhat.com>
---
cifscreds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cifscreds.c b/cifscreds.c
index 32f2ee4..c52f495 100644
--- a/cifscreds.c
+++ b/cifscreds.c
@@ -501,7 +501,7 @@ int main(int argc, char **argv)
if (cmd->name[n] == 0) {
/* exact match */
best = cmd;
- break;
+ continue;
}
/* partial match */
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] cifscreds: use continue instead of break when matching commands
2025-01-14 20:34 [PATCH 1/2] cifscreds: use continue instead of break when matching commands tbecker
@ 2025-01-20 16:02 ` Paulo Alcantara
0 siblings, 0 replies; 2+ messages in thread
From: Paulo Alcantara @ 2025-01-20 16:02 UTC (permalink / raw)
To: tbecker, linux-cifs, Pavel Shilovsky; +Cc: Thiago Becker
tbecker@redhat.com writes:
> From: Thiago Becker <tbecker@redhat.com>
>
> While matching the commands in cifscreds, continue attempting to
> match to detect ambiguous commands.
>
> Signed-off-by: Thiago Becker <tbecker@redhat.com>
> ---
> cifscreds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-20 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-14 20:34 [PATCH 1/2] cifscreds: use continue instead of break when matching commands tbecker
2025-01-20 16:02 ` Paulo Alcantara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox