Linux CIFS filesystem development
 help / color / mirror / Atom feed
* [RFC PATCH 0/2] cifs: Organise declarations in the cifs client header files
@ 2025-09-04 21:18 David Howells
  2025-09-04 21:18 ` [RFC PATCH 1/2] cifs: Do some preparation prior to organising the function declarations David Howells
  2025-09-04 21:18 ` [RFC PATCH 2/2] cifs: Clean up declarations David Howells
  0 siblings, 2 replies; 5+ messages in thread
From: David Howells @ 2025-09-04 21:18 UTC (permalink / raw)
  To: Steve French; +Cc: David Howells, Paulo Alcantara, linux-cifs

Hi Steve,

Would you be interested in this pair of patches?  The second patch
organises the declarations in the cifs client header files, naming the
arguments the same as for the implementations, inserting divider comments,
ordering them the same as they're found in the files and dividing them
better between general, smb1 and smb2/3 categories.

The organisation is entirely scripted with the script in the second patch's
commit message.  The first patch does a bit of preparation to make sure
that the second patch's output will build.

David

David Howells (2):
  cifs: Do some preparation prior to organising the function
    declarations
  cifs: Clean up declarations

 fs/smb/client/cached_dir.h    |   19 -
 fs/smb/client/cifs_debug.c    |    4 +-
 fs/smb/client/cifs_debug.h    |    5 -
 fs/smb/client/cifs_spnego.h   |    2 -
 fs/smb/client/cifs_swn.h      |   15 +-
 fs/smb/client/cifs_unicode.c  |    1 +
 fs/smb/client/cifs_unicode.h  |   16 -
 fs/smb/client/cifsacl.c       |    1 +
 fs/smb/client/cifsfs.c        |    5 +-
 fs/smb/client/cifsfs.h        |   64 --
 fs/smb/client/cifsglob.h      |   19 +-
 fs/smb/client/cifspdu.h       |   12 -
 fs/smb/client/cifsproto.h     | 1228 ++++++++++++++++-----------------
 fs/smb/client/cifssmb.c       |    1 +
 fs/smb/client/cifstransport.c |    1 +
 fs/smb/client/compress.c      |   15 +
 fs/smb/client/compress.h      |   18 +-
 fs/smb/client/connect.c       |    1 +
 fs/smb/client/dfs.h           |    4 -
 fs/smb/client/dfs_cache.h     |   16 -
 fs/smb/client/dir.c           |    1 +
 fs/smb/client/dns_resolve.h   |    3 -
 fs/smb/client/file.c          |    1 +
 fs/smb/client/fs_context.c    |    2 +-
 fs/smb/client/fs_context.h    |    9 -
 fs/smb/client/fscache.h       |   13 +-
 fs/smb/client/inode.c         |    1 +
 fs/smb/client/ioctl.c         |    1 +
 fs/smb/client/link.c          |    1 +
 fs/smb/client/misc.c          |    1 +
 fs/smb/client/netlink.h       |    3 -
 fs/smb/client/netmisc.c       |    2 +-
 fs/smb/client/nterr.h         |    2 -
 fs/smb/client/ntlmssp.h       |   13 -
 fs/smb/client/reparse.h       |   11 -
 fs/smb/client/sess.c          |    1 +
 fs/smb/client/smb1ops.c       |    2 +
 fs/smb/client/smb1proto.h     |  230 ++++++
 fs/smb/client/smb2pdu.h       |    2 -
 fs/smb/client/smb2proto.h     |  536 +++++++-------
 fs/smb/client/smbdirect.h     |   27 +-
 41 files changed, 1157 insertions(+), 1152 deletions(-)
 create mode 100644 fs/smb/client/smb1proto.h


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-12 12:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-04 21:18 [RFC PATCH 0/2] cifs: Organise declarations in the cifs client header files David Howells
2025-09-04 21:18 ` [RFC PATCH 1/2] cifs: Do some preparation prior to organising the function declarations David Howells
2025-09-04 21:18 ` [RFC PATCH 2/2] cifs: Clean up declarations David Howells
2025-09-12  5:34   ` Stefan Metzmacher
2025-09-12 12:28     ` David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox