* [PATCH] smb: server: remove code guarded by nonexistent config option
@ 2026-06-10 1:44 Ethan Nelson-Moore
2026-06-10 2:14 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-10 1:44 UTC (permalink / raw)
To: linux-cifs
Cc: Ethan Nelson-Moore, Namjae Jeon, Steve French, Sergey Senozhatsky,
Tom Talpey
A small piece of code in fs/smb/server/smb_common.c depends on
CONFIG_SMB_INSECURE_SERVER, which has never been defined in the
mainline kernel, but was present in old out-of-tree versions of ksmbd.
Remove this dead code.
Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
fs/smb/server/smb_common.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/smb/server/smb_common.c b/fs/smb/server/smb_common.c
index 741aabdfcef5..82de4fdfe446 100644
--- a/fs/smb/server/smb_common.c
+++ b/fs/smb/server/smb_common.c
@@ -102,9 +102,6 @@ static const struct {
int version;
const char *string;
} version_strings[] = {
-#ifdef CONFIG_SMB_INSECURE_SERVER
- {SMB1_PROT, SMB1_VERSION_STRING},
-#endif
{SMB2_PROT, SMB20_VERSION_STRING},
{SMB21_PROT, SMB21_VERSION_STRING},
{SMB30_PROT, SMB30_VERSION_STRING},
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] smb: server: remove code guarded by nonexistent config option
2026-06-10 1:44 [PATCH] smb: server: remove code guarded by nonexistent config option Ethan Nelson-Moore
@ 2026-06-10 2:14 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2026-06-10 2:14 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: linux-cifs, Steve French, Sergey Senozhatsky, Tom Talpey
On Wed, Jun 10, 2026 at 10:44 AM Ethan Nelson-Moore
<enelsonmoore@gmail.com> wrote:
>
> A small piece of code in fs/smb/server/smb_common.c depends on
> CONFIG_SMB_INSECURE_SERVER, which has never been defined in the
> mainline kernel, but was present in old out-of-tree versions of ksmbd.
> Remove this dead code.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Applied it to #ksmbd-for-next-next.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-10 2:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 1:44 [PATCH] smb: server: remove code guarded by nonexistent config option Ethan Nelson-Moore
2026-06-10 2:14 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox