[PATCH 0/3] smb: update POSIX extension specification references

[PATCH 0/3] smb: update POSIX extension specification references

[ZhangGuoDong]

From: ChenXiaoSong <chenxiaosong@kylinos.cn>

ZhangGuoDong (3):
  smb/server: update POSIX extension specification references
  smb/client: update POSIX extension specification references
  smb/common: update POSIX extension specification references

 fs/smb/client/smb2pdu.h | 10 +++++++---
 fs/smb/common/fscc.h    |  3 +--
 fs/smb/server/smb2pdu.h | 16 +++++++---------
 3 files changed, 15 insertions(+), 14 deletions(-)

-- 
2.55.0

[PATCH 1/3] smb/server: update POSIX extension specification references

[ZhangGuoDong]

From: ZhangGuoDong <zhangguodong@kylinos.cn>

The POSIX extension specifications have now been published:
https://smb3posix.org/

Suggested-by: Paulo Alcantara <pc@manguebit.org>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: ZhangGuoDong <zhangguodong@kylinos.cn>
---
 fs/smb/server/smb2pdu.h | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/fs/smb/server/smb2pdu.h b/fs/smb/server/smb2pdu.h
index 95c89087553b..40d61745ef41 100644
--- a/fs/smb/server/smb2pdu.h
+++ b/fs/smb/server/smb2pdu.h
@@ -156,8 +156,7 @@ struct create_durable_rsp {
 } __packed;
 
 /*
- * See POSIX-SMB2 2.2.14.2.16
- * Link: https://gitlab.com/samba-team/smb3-posix-spec/-/blob/master/smb3_posix_extensions.md
+ * See POSIX-SMB2 2.1.3.2.1
  */
 struct create_posix_rsp {
 	struct create_context_hdr ccontext;
@@ -349,6 +348,7 @@ struct create_sd_buf_req {
 	struct smb_ntsd ntsd;
 } __packed;
 
+/* See POSIX-FSCC 2.2.1 */
 struct smb2_posix_info {
 	__le32 NextEntryOffset;
 	__u32 Ignored;
@@ -362,20 +362,18 @@ struct smb2_posix_info {
 	__le64 Inode;
 	__le32 DeviceId;
 	__le32 Zero;
-	/* beginning of POSIX Create Context Response */
+	/*
+	 * Beginning of POSIX Create Context Response
+	 * See POSIX-SMB2 2.1.3.2.1
+	 */
 	__le32 HardLinks;
 	__le32 ReparseTag;
 	__le32 Mode;
 	/* SidBuffer contain two sids (UNIX user sid(16), UNIX group sid(16)) */
 	u8 SidBuffer[32];
+	/* End of POSIX Create Context Response */
 	__le32 name_len;
 	u8 name[];
-	/*
-	 * var sized owner SID
-	 * var sized group SID
-	 * le32 filenamelength
-	 * u8  filename[]
-	 */
 } __packed;
 
 /* functions */
-- 
2.55.0

Re: [PATCH 1/3] smb/server: update POSIX extension specification references

[Namjae Jeon]

> @@ -362,20 +362,18 @@ struct smb2_posix_info {
>         __le64 Inode;
>         __le32 DeviceId;
>         __le32 Zero;
> -       /* beginning of POSIX Create Context Response */
> +       /*
> +        * Beginning of POSIX Create Context Response
> +        * See POSIX-SMB2 2.1.3.2.1
> +        */
>         __le32 HardLinks;
>         __le32 ReparseTag;
>         __le32 Mode;
>         /* SidBuffer contain two sids (UNIX user sid(16), UNIX group sid(16)) */
>         u8 SidBuffer[32];
> +       /* End of POSIX Create Context Response */
>         __le32 name_len;
>         u8 name[];
> -       /*
> -        * var sized owner SID
> -        * var sized group SID
> -        * le32 filenamelength
> -        * u8  filename[]
> -        */
Is there any reason to delete these?

Re: [PATCH 1/3] smb/server: update POSIX extension specification references

[ZhangGuoDong]

These members are already defined in the structure, so the comments can 
be removed.

On 9/20/26 22:03, Namjae Jeon wrote:
>>          /* SidBuffer contain two sids (UNIX user sid(16), UNIX group sid(16)) */
>>          u8 SidBuffer[32];
>> +       /* End of POSIX Create Context Response */
>>          __le32 name_len;
>>          u8 name[];
>> -       /*
>> -        * var sized owner SID
>> -        * var sized group SID
>> -        * le32 filenamelength
>> -        * u8  filename[]
>> -        */
> Is there any reason to delete these?

[PATCH 2/3] smb/client: update POSIX extension specification references

[ZhangGuoDong]

From: ZhangGuoDong <zhangguodong@kylinos.cn>

The POSIX extension specifications have now been published:
https://smb3posix.org/

Suggested-by: Paulo Alcantara <pc@manguebit.org>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: ZhangGuoDong <zhangguodong@kylinos.cn>
---
 fs/smb/client/smb2pdu.h | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/fs/smb/client/smb2pdu.h b/fs/smb/client/smb2pdu.h
index ab6c667bebc0..b37a1e3941a1 100644
--- a/fs/smb/client/smb2pdu.h
+++ b/fs/smb/client/smb2pdu.h
@@ -224,8 +224,7 @@ struct smb2_file_id_extd_directory_info {
 extern char smb2_padding[7];
 
 /*
- * See POSIX-SMB2 2.2.14.2.16
- * Link: https://gitlab.com/samba-team/smb3-posix-spec/-/blob/master/smb3_posix_extensions.md
+ * See POSIX-SMB2 2.1.3.2.1
  */
 struct create_posix_rsp {
 	u32 nlink;
@@ -238,6 +237,7 @@ struct create_posix_rsp {
 #define SMB2_QUERY_DIRECTORY_IOV_SIZE 2
 
 /*
+ * See POSIX-FSCC 2.2.1
  * SMB2-only POSIX info level for query dir
  *
  * See posix_info_sid_size(), posix_info_extra_size() and
@@ -256,13 +256,17 @@ struct smb2_posix_info {
 	__le64 Inode;
 	__le32 DeviceId;
 	__le32 Zero;
-	/* beginning of POSIX Create Context Response */
+	/*
+	 * Beginning of POSIX Create Context Response
+	 * See POSIX-SMB2 2.1.3.2.1
+	 */
 	__le32 HardLinks;
 	__le32 ReparseTag;
 	__le32 Mode;
 	/*
 	 * var sized owner SID
 	 * var sized group SID
+	 * End of POSIX Create Context Response
 	 * le32 filenamelength
 	 * u8  filename[]
 	 */
-- 
2.55.0

[PATCH 3/3] smb/common: update POSIX extension specification references

[ZhangGuoDong]

From: ZhangGuoDong <zhangguodong@kylinos.cn>

The POSIX extension specifications have now been published:
https://smb3posix.org/

Suggested-by: Paulo Alcantara <pc@manguebit.org>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: ZhangGuoDong <zhangguodong@kylinos.cn>
---
 fs/smb/common/fscc.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/smb/common/fscc.h b/fs/smb/common/fscc.h
index e46d3379b779..61bb1f8e4a64 100644
--- a/fs/smb/common/fscc.h
+++ b/fs/smb/common/fscc.h
@@ -575,8 +575,7 @@ struct file_notify_information {
 } __packed;
 
 /*
- * See POSIX Extensions to MS-FSCC 2.3.2.1
- * Link: https://gitlab.com/samba-team/smb3-posix-spec/-/blob/master/fscc_posix_extensions.md
+ * See POSIX-FSCC 2.3.1
  */
 typedef struct {
 	/* For undefined recommended transfer size return -1 in that field */
-- 
2.55.0

Re: [PATCH 3/3] smb/common: update POSIX extension specification references

[Namjae Jeon]

> @@ -575,8 +575,7 @@ struct file_notify_information {
>  } __packed;
>
>  /*
> - * See POSIX Extensions to MS-FSCC 2.3.2.1
> - * Link: https://gitlab.com/samba-team/smb3-posix-spec/-/blob/master/fscc_posix_extensions.md
> + * See POSIX-FSCC 2.3.1
Please also update the reference below, which still points to section 2.3.1.1.

/* See POSIX Extensions to MS-FSCC 2.3.1.1 */
#define FS_POSIX_INFORMATION            100 /* SMB3.1.1 POSIX. Query */

Thanks.