Re: [PATCH 3/7] smb: minor fix to use SMB2_NTLMV2_SESSKEY_SIZE for auth_key size

[Paulo Alcantara <pc@manguebit.org>]

Bharath SM <bharathsm.hsk@gmail.com> writes:

> Replaced hardcoded value 16 with SMB2_NTLMV2_SESSKEY_SIZE
> in the auth_key definition and memcpy call.
>
> Signed-off-by: Bharath SM <bharathsm@microsoft.com>
> ---
>  fs/smb/client/cifs_ioctl.h | 2 +-
>  fs/smb/client/ioctl.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/smb/client/cifs_ioctl.h b/fs/smb/client/cifs_ioctl.h
> index 26327442e383..b51ce64fcccf 100644
> --- a/fs/smb/client/cifs_ioctl.h
> +++ b/fs/smb/client/cifs_ioctl.h
> @@ -61,7 +61,7 @@ struct smb_query_info {
>  struct smb3_key_debug_info {
>  	__u64	Suid;
>  	__u16	cipher_type;
> -	__u8	auth_key[16]; /* SMB2_NTLMV2_SESSKEY_SIZE */
> +	__u8	auth_key[SMB2_NTLMV2_SESSKEY_SIZE];
>  	__u8	smb3encryptionkey[SMB3_SIGN_KEY_SIZE];
>  	__u8	smb3decryptionkey[SMB3_SIGN_KEY_SIZE];
>  } __packed;
> diff --git a/fs/smb/client/ioctl.c b/fs/smb/client/ioctl.c
> index 56439da4f119..0a9935ce05a5 100644
> --- a/fs/smb/client/ioctl.c
> +++ b/fs/smb/client/ioctl.c
> @@ -506,7 +506,7 @@ long cifs_ioctl(struct file *filep, unsigned int command, unsigned long arg)
>  				le16_to_cpu(tcon->ses->server->cipher_type);
>  			pkey_inf.Suid = tcon->ses->Suid;
>  			memcpy(pkey_inf.auth_key, tcon->ses->auth_key.response,
> -					16 /* SMB2_NTLMV2_SESSKEY_SIZE */);
> +				  SMB2_NTLMV2_SESSKEY_SIZE);
                                  ^ sizeof(pkey_in.auth_key)?

Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>