From: Paulo Alcantara <pc@manguebit.org>
To: Bharath SM <bharathsm.hsk@gmail.com>,
linux-cifs@vger.kernel.org, smfrench@gmail.com
Cc: Bharath SM <bharathsm@microsoft.com>
Subject: Re: [PATCH 7/7] smb: Fix memory allocation and ACL handling in cifs_xattr_set
Date: Thu, 19 Jun 2025 12:57:56 -0300 [thread overview]
Message-ID: <9bd4fae38c680b0c8a0c8957258f5934@manguebit.org> (raw)
In-Reply-To: <20250619153538.1600500-7-bharathsm@microsoft.com>
Hi Bharath,
Bharath SM <bharathsm.hsk@gmail.com> writes:
> If set_acl is NULL, then there is a chance that memory allocated
> for pacl memory doesn't get freed. Ensure proper memory deallocation
> for pacl in `cifs_xattr_set` to avoid leaks.
If ->set_acl is NULL, then the following is executed
} else {
rc = -EOPNOTSUPP;
}
if (rc == 0) /* force revalidate of the inode */
CIFS_I(inode)->time = 0;
kfree(pacl);
Can you elaborate where the potential leak is?
next prev parent reply other threads:[~2025-06-19 15:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-19 15:35 [PATCH 1/7] smb: Use loff_t for directory position in cached_dirents Bharath SM
2025-06-19 15:35 ` [PATCH 2/7] smb: minor fix to use sizeof to initialize flags_string buffer Bharath SM
2025-06-19 16:06 ` Paulo Alcantara
2025-06-20 9:36 ` Shyam Prasad N
2025-06-19 15:35 ` [PATCH 3/7] smb: minor fix to use SMB2_NTLMV2_SESSKEY_SIZE for auth_key size Bharath SM
2025-06-19 16:08 ` Paulo Alcantara
2025-06-20 9:44 ` Shyam Prasad N
2025-06-19 15:35 ` [PATCH 4/7] smb: add NULL check after kzalloc in cifsConvertToUTF16 Bharath SM
2025-06-19 16:24 ` Paulo Alcantara
2025-06-20 15:04 ` Bharath SM
2025-06-20 9:44 ` Shyam Prasad N
2025-06-19 15:35 ` [PATCH 5/7] cifs: minor cleanup to remove unused permission bit macros Bharath SM
2025-06-19 15:35 ` [PATCH 6/7] smb: Fix potential divide-by-zero issue when iface_min_speed is 0 Bharath SM
2025-06-19 16:01 ` Paulo Alcantara
2025-06-20 15:04 ` Bharath SM
2025-06-20 9:49 ` Shyam Prasad N
2025-06-19 15:35 ` [PATCH 7/7] smb: Fix memory allocation and ACL handling in cifs_xattr_set Bharath SM
2025-06-19 15:57 ` Paulo Alcantara [this message]
2025-06-19 16:05 ` [PATCH 1/7] smb: Use loff_t for directory position in cached_dirents Paulo Alcantara
2025-06-20 9:34 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd4fae38c680b0c8a0c8957258f5934@manguebit.org \
--to=pc@manguebit.org \
--cc=bharathsm.hsk@gmail.com \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox