Re: Linux 2.6.36-rc3

Re: Linux 2.6.36-rc3

[Suresh Jayaraman]

(Cc linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)

Couldn't get a chance to check this, but I guess this is perhaps due to
the recent crypto patches..

On 08/30/2010 02:17 PM, Miguel Calleja wrote:
> CIFS does not build without CRYPTO selected.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
Suresh Jayaraman

Re: Linux 2.6.36-rc3

[Shirish Pargaonkar]

On Mon, Aug 30, 2010 at 12:00 PM, Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org> wrote:
> (Cc linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
>
> Couldn't get a chance to check this, but I guess this is perhaps due to
> the recent crypto patches..

Suresh, yes, cifs auth and signing code using kernel crypto (shash) apis.

fs/cifs/Kconfig

        select CRYPTO_MD5
        select CRYPTO_ARC4


>
> On 08/30/2010 02:17 PM, Miguel Calleja wrote:
>> CIFS does not build without CRYPTO selected.
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>
>
> --
> Suresh Jayaraman
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: Linux 2.6.36-rc3

[Randy Dunlap]

On Mon, 30 Aug 2010 12:14:53 -0500 Shirish Pargaonkar wrote:

> On Mon, Aug 30, 2010 at 12:00 PM, Suresh Jayaraman <sjayaraman@suse.de> wrote:
> > (Cc linux-cifs@vger.kernel.org)
> >
> > Couldn't get a chance to check this, but I guess this is perhaps due to
> > the recent crypto patches..
> 
> Suresh, yes, cifs auth and signing code using kernel crypto (shash) apis.
> 
> fs/cifs/Kconfig
> 
>         select CRYPTO_MD5
>         select CRYPTO_ARC4
> 

Either CIFS should depend on CRYPTO:
change
	depends on INET
to
	depends on INET && CRYPTO

or it can also select CRYPTO.

> 
> >
> > On 08/30/2010 02:17 PM, Miguel Calleja wrote:
> >> CIFS does not build without CRYPTO selected.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: Linux 2.6.36-rc3

[Steve French]

On Mon, Aug 30, 2010 at 12:25 PM, Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> On Mon, 30 Aug 2010 12:14:53 -0500 Shirish Pargaonkar wrote:
>
>> On Mon, Aug 30, 2010 at 12:00 PM, Suresh Jayaraman <sjayaraman@suse.de> wrote:
>> > (Cc linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
>> >
>> > Couldn't get a chance to check this, but I guess this is perhaps due to
>> > the recent crypto patches..
>>
>> Suresh, yes, cifs auth and signing code using kernel crypto (shash) apis.
>>
>> fs/cifs/Kconfig
>>
>>         select CRYPTO_MD5
>>         select CRYPTO_ARC4
>>
>
> Either CIFS should depend on CRYPTO:
> change
>        depends on INET
> to
>        depends on INET && CRYPTO
>
> or it can also select CRYPTO.
>
>>
>> >
>> > On 08/30/2010 02:17 PM, Miguel Calleja wrote:
>> >> CIFS does not build without CRYPTO selected.

OK - will fix this for cifs.   Looks like ecryptfs chose "depends on CRYPTO"
and ubifs chose "select CRYPTO" - but for network file system seems like
"select CRYPTO" (rather than depends on) makes more sense.

The ceph file system seems like it has the same type of problem.
fs/ceph/Kconfig
has "select CRYPTO_AES" but not "select CRYPTO"



-- 
Thanks,

Steve