Linux CIFS filesystem development
 help / color / mirror / Atom feed
* [PATCH V2 0/2] smb: client: Fix use-after-free in readdir
@ 2025-05-16  9:12 Wang Zhaolong
  2025-05-16  9:12 ` [PATCH V2 1/2] smb: client: Fix use-after-free in cifs_fill_dirent Wang Zhaolong
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Wang Zhaolong @ 2025-05-16  9:12 UTC (permalink / raw)
  To: sfrench, sfrench
  Cc: linux-cifs, samba-technical, linux-kernel, chengzhihao1,
	wangzhaolong1, yi.zhang, yangerkun

V2:
  - Correct spelling mistakes in the commit message, such as 'lopp' -> 'loop'.
  - The titles of patches follow the same style.

This patch series addresses a use-after-free vulnerability in the SMB/CIFS
client readdir implementation that can be triggered during concurrent
directory reads when a signal interrupts directory enumeration.

The root cause is in the operation sequence in find_cifs_entry():
1. When query_dir_next() fails due to signal interruption (ERESTARTSYS)
2. The code continues to access last_entry pointer before checking the return code
3. This can access freed memory since the buffer may have been released

The race condition can be triggered by processes accessing the same directory
with concurrent readdir operations, especially when signals are involved.

The fix is straightforward:
1. First patch ensures we check the return code before using any pointers
2. Second patch improves defensiveness by resetting all related buffer pointers
   when freeing the network buffer

Wang Zhaolong (2):
  smb: client: Fix use-after-free in cifs_fill_dirent
  smb: client: Reset all search buffer pointers when releasing buffer

 fs/smb/client/readdir.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.39.2


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2025-08-05  2:38 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-16  9:12 [PATCH V2 0/2] smb: client: Fix use-after-free in readdir Wang Zhaolong
2025-05-16  9:12 ` [PATCH V2 1/2] smb: client: Fix use-after-free in cifs_fill_dirent Wang Zhaolong
2025-05-16  9:12 ` [PATCH V2 2/2] smb: client: Reset all search buffer pointers when releasing buffer Wang Zhaolong
2025-05-16 13:49 ` [PATCH V2 0/2] smb: client: Fix use-after-free in readdir Paulo Alcantara
2025-05-17 20:18   ` Steve French
2025-05-19  2:56     ` Wang Zhaolong
2025-05-19 15:41       ` Steve French
2025-05-22 12:53         ` Wang Zhaolong
2025-05-22 14:00         ` Wang Zhaolong
2025-05-22 15:39           ` Steve French
2025-05-23  2:33             ` Wang Zhaolong
2025-08-05  2:38           ` Wang Zhaolong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox