Linux CIFS filesystem development
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@manguebit.org>
To: linux-cifs@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>, Tom Talpey <tom@talpey.com>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Bharath SM <bharathsm@microsoft.com>,
	Namjae Jeon <linkinjeon@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 2/2] smb: client: fix fattr leaking on wsl_to_fattr() failure
Date: Tue, 15 Sep 2026 11:29:49 -0300	[thread overview]
Message-ID: <5c2bc41d3dac15a5fd153444121c827f@manguebit.org> (raw)
In-Reply-To: <20260914011052.809774-2-pc@manguebit.org>

Paulo Alcantara <pc@manguebit.org> writes:

> wsl_to_fattr() mutates fattr fields as it parses each WSL EA.  If
> validation later fails, the function returns false with partially
> mutated fattr fields that callers do not reset.
>
> Fix this by parsing into local variables and only committing them to
> fattr on success.
> ...

Applied.

  parent reply	other threads:[~2026-09-15 14:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  1:10 [PATCH 1/2] smb: client: fix unaligned access in WSL reparse point parser Paulo Alcantara
2026-09-14  1:10 ` [PATCH 2/2] smb: client: fix fattr leaking on wsl_to_fattr() failure Paulo Alcantara
2026-09-15  0:13   ` Namjae Jeon
2026-09-15 14:29   ` Paulo Alcantara [this message]
2026-09-15  0:12 ` [PATCH 1/2] smb: client: fix unaligned access in WSL reparse point parser Namjae Jeon
2026-09-15 14:29 ` Paulo Alcantara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c2bc41d3dac15a5fd153444121c827f@manguebit.org \
    --to=pc@manguebit.org \
    --cc=bharathsm@microsoft.com \
    --cc=dhowells@redhat.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=sprasad@microsoft.com \
    --cc=stable@vger.kernel.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox