From: Paulo Alcantara <pc@manguebit.org>
To: linux-cifs@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>, Tom Talpey <tom@talpey.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Bharath SM <bharathsm@microsoft.com>,
Namjae Jeon <linkinjeon@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] smb: client: fix unaligned access in WSL reparse point parser
Date: Tue, 15 Sep 2026 11:29:27 -0300 [thread overview]
Message-ID: <9cf1d88750bcaa0fc0f7b792b0a22295@manguebit.org> (raw)
In-Reply-To: <20260914011052.809774-1-pc@manguebit.org>
Paulo Alcantara <pc@manguebit.org> writes:
> When wsl_to_fattr() parses WSL extended attributes, it computes a
> payload pointer from ea->ea_data + ea_name_length + 1. Since the
> smb2_file_full_ea_info struct is __packed and all WSL xattr names are
> 6 bytes long, the value pointer always lands at an odd byte offset,
> never satisfying __le32 or __le64 alignment requirements.
>
> The code then casts this pointer to __le32 * or __le64 * and
> dereferences it directly, which may cause alignment faults on some
> architectures.
>
> Replace all such casts with get_unaligned_le32() and
> get_unaligned_le64() in reparse_mkdev(), wsl_make_kuid(),
> wsl_make_kgid() and wsl_to_fattr().
> ...
Applied.
prev parent reply other threads:[~2026-09-15 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 1:10 [PATCH 1/2] smb: client: fix unaligned access in WSL reparse point parser Paulo Alcantara
2026-09-14 1:10 ` [PATCH 2/2] smb: client: fix fattr leaking on wsl_to_fattr() failure Paulo Alcantara
2026-09-15 0:13 ` Namjae Jeon
2026-09-15 14:29 ` Paulo Alcantara
2026-09-15 0:12 ` [PATCH 1/2] smb: client: fix unaligned access in WSL reparse point parser Namjae Jeon
2026-09-15 14:29 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cf1d88750bcaa0fc0f7b792b0a22295@manguebit.org \
--to=pc@manguebit.org \
--cc=bharathsm@microsoft.com \
--cc=dhowells@redhat.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=sprasad@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox