Re: [PATCH] afs, bash: Fix open(O_CREAT) on an extant AFS file in a sticky dir

[Chet Ramey <chet.ramey@case.edu>]

[-- Attachment #1.1: Type: text/plain, Size: 1043 bytes --]

On 5/5/25 9:14 AM, Christian Brauner wrote:

>> This works around the kernel not being able to validly check the
>> current_fsuid() against i_uid on the file or the directory because the
>> uidspaces of the system and of AFS may well be disjoint.  The problem lies
>> with the uid checks in may_create_in_sticky().
>>
>> However, the bash work around is going to be removed:
> 
> Why is it removed? That's a very strange comment:

I think this question has been adequately answered.


> So then just don't remove it. I don't see a reason for us to workaround
> userspace creating a bug for itself and forcing us to add two new inode
> operations to work around it.

I think this shows that userspace applications should be very cautious
about putting in workarounds for kernel bugs, and making them as limited
in scope as possible.


-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 203 bytes --]