From: Ralph Boehme <slow@samba.org>
To: Hyunchul Lee <hyc.lee@gmail.com>, Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs <linux-cifs@vger.kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steve French <smfrench@gmail.com>
Subject: Re: [PATCH] ksmbd: improve credits management
Date: Wed, 6 Oct 2021 10:50:40 +0200 [thread overview]
Message-ID: <64519e7d-d82f-91f6-5c8c-ce9aa8935b30@samba.org> (raw)
In-Reply-To: <CANFS6basCNTcN7Myz0bAd_LTXEji43HiqLE0B8McpaemUjSp8Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 507 bytes --]
Am 06.10.21 um 10:43 schrieb Hyunchul Lee:
> Okay, I will drop this in the patch. And could you elaborate
> on the situation that clients cause the problem?
the client will just swamp you with IO requests and you've lost control
over the creditting window. Iirc in Samba this resulted in OOM due to
the many buffer allocations for the in-process IO requests.
-slow
--
Ralph Boehme, Samba Team https://samba.org/
SerNet Samba Team Lead https://sernet.de/en/team-samba
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-10-06 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 10:00 [PATCH] ksmbd: improve credits management Hyunchul Lee
2021-10-06 2:06 ` Namjae Jeon
2021-10-06 6:27 ` Hyunchul Lee
2021-10-06 6:52 ` Namjae Jeon
2021-10-06 8:36 ` Hyunchul Lee
2021-10-06 7:15 ` Ralph Boehme
2021-10-06 8:43 ` Hyunchul Lee
2021-10-06 8:50 ` Ralph Boehme [this message]
2021-10-06 9:09 ` Ralph Boehme
2021-10-07 1:11 ` Namjae Jeon
2021-10-07 6:38 ` Hyunchul Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64519e7d-d82f-91f6-5c8c-ce9aa8935b30@samba.org \
--to=slow@samba.org \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox