From: Ralph Boehme <slow@samba.org>
To: Hyunchul Lee <hyc.lee@gmail.com>, linux-cifs@vger.kernel.org
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steve French <smfrench@gmail.com>
Subject: Re: [PATCH] ksmbd: improve credits management
Date: Wed, 6 Oct 2021 09:15:47 +0200 [thread overview]
Message-ID: <de0ecb81-0313-266e-cc5b-94ec40201141@samba.org> (raw)
In-Reply-To: <20211005100026.250280-1-hyc.lee@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 649 bytes --]
Am 05.10.21 um 12:00 schrieb Hyunchul Lee:
> * For an asynchronous operation, grant credits
> for an interim response and 0 credit for the
> final response.
fwiw, Samba also does this but this can cause significant problems as it
means the server looses control over the receive window size. We've seen
aggressive client go nuts about this overwhelming the server with IO
requests leading to disconnects (iirc). So this may need careful
checking how Windows implements this server side.
Cheers!
-slow
--
Ralph Boehme, Samba Team https://samba.org/
SerNet Samba Team Lead https://sernet.de/en/team-samba
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-10-06 7:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 10:00 [PATCH] ksmbd: improve credits management Hyunchul Lee
2021-10-06 2:06 ` Namjae Jeon
2021-10-06 6:27 ` Hyunchul Lee
2021-10-06 6:52 ` Namjae Jeon
2021-10-06 8:36 ` Hyunchul Lee
2021-10-06 7:15 ` Ralph Boehme [this message]
2021-10-06 8:43 ` Hyunchul Lee
2021-10-06 8:50 ` Ralph Boehme
2021-10-06 9:09 ` Ralph Boehme
2021-10-07 1:11 ` Namjae Jeon
2021-10-07 6:38 ` Hyunchul Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de0ecb81-0313-266e-cc5b-94ec40201141@samba.org \
--to=slow@samba.org \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox